You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2021/07/23 09:43:40 UTC

[Impala-ASF-CR] IMPALA-10823: Output fewer information when external frontend is used 

Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17718


Change subject: IMPALA-10823: Output fewer information when external frontend is used
......................................................................

IMPALA-10823: Output fewer information when external frontend is used

We use ThriftDebugString() to output a TExecutePlannedStatementReq.
TExecutePlannedStatementReq can be quite large since it contains a
Frontend.TExecRequest as well.

We only need to output a redacted version of
TExecutePlannedStatementReq.statementReq.

Change-Id: Ib862bfa298855943037afef53990160dcc8321ad
---
M be/src/service/impala-hs2-server.cc
M be/src/util/thrift-debug-util.h
2 files changed, 14 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/17718/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib862bfa298855943037afef53990160dcc8321ad
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-10823: Output fewer information when external frontend is used

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17718 )

Change subject: IMPALA-10823: Output fewer information when external frontend is used
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9167/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib862bfa298855943037afef53990160dcc8321ad
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Jul 2021 09:51:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10823: Output fewer information when external frontend is used

Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17718 )

Change subject: IMPALA-10823: Output fewer information when external frontend is used
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

Looks great!

http://gerrit.cloudera.org:8080/#/c/17718/1/be/src/util/thrift-debug-util.h
File be/src/util/thrift-debug-util.h:

http://gerrit.cloudera.org:8080/#/c/17718/1/be/src/util/thrift-debug-util.h@142
PS1, Line 142:       "  *** OTHER FIELDS ARE OMITTED ***\n"
> I'd be a bit conservative about adding new query options for things like th
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/17718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib862bfa298855943037afef53990160dcc8321ad
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Jul 2021 12:54:36 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10823: Output fewer information when external frontend is used

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17718 )

Change subject: IMPALA-10823: Output fewer information when external frontend is used
......................................................................


Patch Set 4:

(2 comments)

Thanks for the comments!

http://gerrit.cloudera.org:8080/#/c/17718/3/be/src/util/thrift-debug-util.h
File be/src/util/thrift-debug-util.h:

http://gerrit.cloudera.org:8080/#/c/17718/3/be/src/util/thrift-debug-util.h@139
PS3, Line 139: st
> nit. Can this be made static so that there is only one copy of the pattern 
Done


http://gerrit.cloudera.org:8080/#/c/17718/1/be/src/util/thrift-debug-util.h
File be/src/util/thrift-debug-util.h:

http://gerrit.cloudera.org:8080/#/c/17718/1/be/src/util/thrift-debug-util.h@142
PS1, Line 142:       "  *** OTHER FIELDS ARE OMITTED ***\n"
> nit. I wonder if this can be controlled by a query option instead. Using VL
I'd be a bit conservative about adding new query options for things like this. Also, it'd mean that users would need to configure the logging via log-levels plus query options, which could be cumbersome.



-- 
To view, visit http://gerrit.cloudera.org:8080/17718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib862bfa298855943037afef53990160dcc8321ad
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Jul 2021 09:48:20 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10823: Output fewer information when external frontend is used

Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17718 )

Change subject: IMPALA-10823: Output fewer information when external frontend is used
......................................................................


Patch Set 3:

(2 comments)

Looks good!

http://gerrit.cloudera.org:8080/#/c/17718/3/be/src/util/thrift-debug-util.h
File be/src/util/thrift-debug-util.h:

http://gerrit.cloudera.org:8080/#/c/17718/3/be/src/util/thrift-debug-util.h@139
PS3, Line 139: co
nit. Can this be made static so that there is only one copy of the pattern in each impalad process?


http://gerrit.cloudera.org:8080/#/c/17718/1/be/src/util/thrift-debug-util.h
File be/src/util/thrift-debug-util.h:

http://gerrit.cloudera.org:8080/#/c/17718/1/be/src/util/thrift-debug-util.h@142
PS1, Line 142:       "  *** OTHER FIELDS ARE OMITTED ***\n"
> I added
nit. I wonder if this can be controlled by a query option instead. Using VLOG(3) will output everything at VLOG(3) level which may not be desirable.



-- 
To view, visit http://gerrit.cloudera.org:8080/17718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib862bfa298855943037afef53990160dcc8321ad
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Jul 2021 16:30:01 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10823: Output fewer information when external frontend is used

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17718 )

Change subject: IMPALA-10823: Output fewer information when external frontend is used
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9152/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib862bfa298855943037afef53990160dcc8321ad
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Jul 2021 10:05:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10823: Output fewer information when external frontend is used

Posted by "Kurt Deschler (Code Review)" <ge...@cloudera.org>.
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/17718 )

Change subject: IMPALA-10823: Output fewer information when external frontend is used
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17718/1/be/src/util/thrift-debug-util.h
File be/src/util/thrift-debug-util.h:

http://gerrit.cloudera.org:8080/#/c/17718/1/be/src/util/thrift-debug-util.h@142
PS1, Line 142:       "  *** OTHER FIELDS ARE OMITTED ***\n"
I downloaded the patch and output looks good. However, probably better to preserve the full output with DEBUG tracing and use this format with INFO.



-- 
To view, visit http://gerrit.cloudera.org:8080/17718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib862bfa298855943037afef53990160dcc8321ad
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Jul 2021 18:45:00 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10823: Output fewer information when external frontend is used

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17718 )

Change subject: IMPALA-10823: Output fewer information when external frontend is used
......................................................................


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7352/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/17718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib862bfa298855943037afef53990160dcc8321ad
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Jul 2021 12:55:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10823: Output fewer information when external frontend is used

Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17718 )

Change subject: IMPALA-10823: Output fewer information when external frontend is used
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib862bfa298855943037afef53990160dcc8321ad
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Jul 2021 18:39:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10823: Output fewer information when external frontend is used

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17718 )

Change subject: IMPALA-10823: Output fewer information when external frontend is used
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17718/4/be/src/service/impala-hs2-server.cc
File be/src/service/impala-hs2-server.cc:

http://gerrit.cloudera.org:8080/#/c/17718/4/be/src/service/impala-hs2-server.cc@560
PS4, Line 560:   VLOG(3) << "ExecutePlannedStatement(): plan=" << ThriftDebugString(request.plan);
Please make sure you don't output sensitive data with ThriftDebugString(). If so, use impala::RedactedDebugString() instead.



-- 
To view, visit http://gerrit.cloudera.org:8080/17718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib862bfa298855943037afef53990160dcc8321ad
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Jul 2021 09:48:28 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10823: Output fewer information when external frontend is used

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17718 )

Change subject: IMPALA-10823: Output fewer information when external frontend is used
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17718/3/be/src/service/impala-hs2-server.cc
File be/src/service/impala-hs2-server.cc:

http://gerrit.cloudera.org:8080/#/c/17718/3/be/src/service/impala-hs2-server.cc@560
PS3, Line 560:   VLOG(3) << "ExecutePlannedStatement(): plan=" << ThriftDebugString(request.plan);
Please make sure you don't output sensitive data with ThriftDebugString(). If so, use impala::RedactedDebugString() instead.



-- 
To view, visit http://gerrit.cloudera.org:8080/17718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib862bfa298855943037afef53990160dcc8321ad
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Jul 2021 09:38:31 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10823: Output fewer information when external frontend is used

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Kurt Deschler, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17718

to look at the new patch set (#2).

Change subject: IMPALA-10823: Output fewer information when external frontend is used
......................................................................

IMPALA-10823: Output fewer information when external frontend is used

We use ThriftDebugString() to output a TExecutePlannedStatementReq.
TExecutePlannedStatementReq can be quite large since it contains a
Frontend.TExecRequest as well.

We only need to output a redacted version of
TExecutePlannedStatementReq.statementReq. At higher log level we
output TExecutePlannedStatementReq.plan as well.

Change-Id: Ib862bfa298855943037afef53990160dcc8321ad
---
M be/src/service/impala-hs2-server.cc
M be/src/util/thrift-debug-util.h
2 files changed, 15 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/17718/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib862bfa298855943037afef53990160dcc8321ad
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>

[Impala-ASF-CR] IMPALA-10823: Output fewer information when external frontend is used

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17718 )

Change subject: IMPALA-10823: Output fewer information when external frontend is used
......................................................................


Patch Set 2:

(1 comment)

Thanks for the comment!

http://gerrit.cloudera.org:8080/#/c/17718/1/be/src/util/thrift-debug-util.h
File be/src/util/thrift-debug-util.h:

http://gerrit.cloudera.org:8080/#/c/17718/1/be/src/util/thrift-debug-util.h@142
PS1, Line 142:       "  *** OTHER FIELDS ARE OMITTED ***\n"
> I downloaded the patch and output looks good. However, probably better to p
I added

 VLOG(3) << "ExecutePlannedStatement(): plan=" << ThriftDebugString(request.plan);

to impala-hs2-server.cc. So we can still have all the information at a higher log level.



-- 
To view, visit http://gerrit.cloudera.org:8080/17718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib862bfa298855943037afef53990160dcc8321ad
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Jul 2021 09:31:36 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10823: Output fewer information when external frontend is used

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17718 )

Change subject: IMPALA-10823: Output fewer information when external frontend is used
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17718/2/be/src/service/impala-hs2-server.cc
File be/src/service/impala-hs2-server.cc:

http://gerrit.cloudera.org:8080/#/c/17718/2/be/src/service/impala-hs2-server.cc@560
PS2, Line 560:   VLOG(3) << "ExecutePlannedStatement(): plan=" << ThriftDebugString(request.plan);
Please make sure you don't output sensitive data with ThriftDebugString(). If so, use impala::RedactedDebugString() instead.



-- 
To view, visit http://gerrit.cloudera.org:8080/17718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib862bfa298855943037afef53990160dcc8321ad
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Jul 2021 09:29:57 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10823: Output fewer information when external frontend is used

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17718 )

Change subject: IMPALA-10823: Output fewer information when external frontend is used
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9168/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib862bfa298855943037afef53990160dcc8321ad
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Jul 2021 10:00:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10823: Output fewer information when external frontend is used

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Qifan Chen, Kurt Deschler, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17718

to look at the new patch set (#4).

Change subject: IMPALA-10823: Output fewer information when external frontend is used
......................................................................

IMPALA-10823: Output fewer information when external frontend is used

We use ThriftDebugString() to output a TExecutePlannedStatementReq.
TExecutePlannedStatementReq can be quite large since it contains a
Frontend.TExecRequest as well.

We only need to output a redacted version of
TExecutePlannedStatementReq.statementReq. At higher log level we
output TExecutePlannedStatementReq.plan as well.

Change-Id: Ib862bfa298855943037afef53990160dcc8321ad
---
M be/src/service/impala-hs2-server.cc
M be/src/util/thrift-debug-util.h
2 files changed, 15 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/17718/4
-- 
To view, visit http://gerrit.cloudera.org:8080/17718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib862bfa298855943037afef53990160dcc8321ad
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-10823: Output fewer information when external frontend is used

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17718 )

Change subject: IMPALA-10823: Output fewer information when external frontend is used
......................................................................


Patch Set 5: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib862bfa298855943037afef53990160dcc8321ad
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Jul 2021 19:02:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10823: Output fewer information when external frontend is used

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17718 )

Change subject: IMPALA-10823: Output fewer information when external frontend is used
......................................................................

IMPALA-10823: Output fewer information when external frontend is used

We use ThriftDebugString() to output a TExecutePlannedStatementReq.
TExecutePlannedStatementReq can be quite large since it contains a
Frontend.TExecRequest as well.

We only need to output a redacted version of
TExecutePlannedStatementReq.statementReq. At higher log level we
output TExecutePlannedStatementReq.plan as well.

Change-Id: Ib862bfa298855943037afef53990160dcc8321ad
Reviewed-on: http://gerrit.cloudera.org:8080/17718
Reviewed-by: Qifan Chen <qc...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/service/impala-hs2-server.cc
M be/src/util/thrift-debug-util.h
2 files changed, 15 insertions(+), 2 deletions(-)

Approvals:
  Qifan Chen: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/17718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib862bfa298855943037afef53990160dcc8321ad
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-10823: Output fewer information when external frontend is used

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17718 )

Change subject: IMPALA-10823: Output fewer information when external frontend is used
......................................................................


Patch Set 5:

Thanks for the review. Qifan, thank you for starting the verify job, but this patch only has +1s so far. Did you want to upgrade your vote to +2 maybe?


-- 
To view, visit http://gerrit.cloudera.org:8080/17718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib862bfa298855943037afef53990160dcc8321ad
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Jul 2021 16:37:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10823: Output fewer information when external frontend is used

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Kurt Deschler, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17718

to look at the new patch set (#3).

Change subject: IMPALA-10823: Output fewer information when external frontend is used
......................................................................

IMPALA-10823: Output fewer information when external frontend is used

We use ThriftDebugString() to output a TExecutePlannedStatementReq.
TExecutePlannedStatementReq can be quite large since it contains a
Frontend.TExecRequest as well.

We only need to output a redacted version of
TExecutePlannedStatementReq.statementReq. At higher log level we
output TExecutePlannedStatementReq.plan as well.

Change-Id: Ib862bfa298855943037afef53990160dcc8321ad
---
M be/src/service/impala-hs2-server.cc
M be/src/util/thrift-debug-util.h
2 files changed, 15 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/17718/3
-- 
To view, visit http://gerrit.cloudera.org:8080/17718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib862bfa298855943037afef53990160dcc8321ad
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-10823: Output fewer information when external frontend is used

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17718 )

Change subject: IMPALA-10823: Output fewer information when external frontend is used
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9181/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib862bfa298855943037afef53990160dcc8321ad
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Jul 2021 10:08:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10823: Output fewer information when external frontend is used

Posted by "Kurt Deschler (Code Review)" <ge...@cloudera.org>.
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/17718 )

Change subject: IMPALA-10823: Output fewer information when external frontend is used
......................................................................


Patch Set 4: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib862bfa298855943037afef53990160dcc8321ad
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Jul 2021 12:04:25 +0000
Gerrit-HasComments: No