You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by selvaganesang <gi...@git.apache.org> on 2015/10/16 20:20:50 UTC
[GitHub] incubator-trafodion pull request: [TRAFODION-1535] Explain and RMS...
GitHub user selvaganesang opened a pull request:
https://github.com/apache/incubator-trafodion/pull/129
[TRAFODION-1535] Explain and RMS statistics output are not in sync
when the vsbb is chosen for Insert/Upsert command.
See JIRA for details
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/selvaganesang/incubator-trafodion trafodion-1535
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/129.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #129
----
commit 6b8fdb4c3212c7940549799416790244c52c66bc
Author: selvaganesang <se...@esgyn.com>
Date: 2015-10-16T18:14:09Z
[TRAFODION-1535] Explain and RMS statistics output are not in sync
when the vsbb is chosen for Insert/Upsert command
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1535] Explain and RMS...
Posted by sureshsubbiah <gi...@git.apache.org>.
Github user sureshsubbiah commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/129#discussion_r42280550
--- Diff: core/sql/optimizer/RelUpdate.h ---
@@ -1830,7 +1830,8 @@ class HbaseInsert: public Insert
CollHeap *oHeap = CmpCommon::statementHeap(),
InsertType insertType = SIMPLE_INSERT)
: Insert(name,tabId,otype,child,NULL,NULL,oHeap, insertType),
- returnRow_(FALSE)
+ returnRow_(FALSE),
+ vsbbInsert_(FALSE)
--- End diff --
CopyTopNode is not carrying over this new flag. I suppose it does not matter since the flag is being set in the generator. Please consider adding that in a subsequent checkin, if you think it will be a good thing to do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1535] Explain and RMS...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/129
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1535] Explain and RMS...
Posted by selvaganesang <gi...@git.apache.org>.
Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/129#discussion_r42284259
--- Diff: core/sql/optimizer/RelUpdate.h ---
@@ -1830,7 +1830,8 @@ class HbaseInsert: public Insert
CollHeap *oHeap = CmpCommon::statementHeap(),
InsertType insertType = SIMPLE_INSERT)
: Insert(name,tabId,otype,child,NULL,NULL,oHeap, insertType),
- returnRow_(FALSE)
+ returnRow_(FALSE),
+ vsbbInsert_(FALSE)
--- End diff --
Will do just to make it consistent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---