You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/08/10 11:16:54 UTC

[GitHub] [shardingsphere] soulasuna commented on pull request #11743: Refactor shardingsphere-shadow-core first step

soulasuna commented on pull request #11743:
URL: https://github.com/apache/shardingsphere/pull/11743#issuecomment-895944327


   > please do not use a verb as the very beginning of your class name.
   > for example, `DeleteShadowDataSourceRouterJudgeEngine`, you could chang to `ShadowDataSourceRouterDeletionJudgeEngine`
   
   Thank you for your suggestion, I will fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org