You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jx2lee (via GitHub)" <gi...@apache.org> on 2025/02/18 12:59:06 UTC
[PR] Add a note `airflow users` command is available when FAB auth-manager is enabled [airflow]
jx2lee opened a new pull request, #46862:
URL: https://github.com/apache/airflow/pull/46862
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
closes: #45936
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a note `airflow users` command is available when FAB auth-manager is enabled [airflow]
Posted by "jx2lee (via GitHub)" <gi...@apache.org>.
jx2lee commented on code in PR #46862:
URL: https://github.com/apache/airflow/pull/46862#discussion_r1963458596
##########
docs/apache-airflow/start.rst:
##########
@@ -149,6 +149,9 @@ the all-in-one ``standalone`` command, you can instead run:
airflow triggerer
+.. note::
+ ``airflow users`` command is only available when `FAB auth manager <https://airflow.apache.org/docs/apache-airflow-providers-fab/stable/auth-manager/index.html>`_ is enabled.
Review Comment:
Thanks, I fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a note `airflow users` command is available when FAB auth-manager is enabled [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #46862:
URL: https://github.com/apache/airflow/pull/46862#discussion_r1961855913
##########
docs/apache-airflow/start.rst:
##########
@@ -149,6 +149,9 @@ the all-in-one ``standalone`` command, you can instead run:
airflow triggerer
+.. note::
+ ``airflow users`` command is only available when `FAB auth manager <https://airflow.apache.org/docs/apache-airflow-providers-fab/stable/auth-manager/index.html>`_ is enabled.
Review Comment:
I think it is better to link the file doc directly. So that if it gets renamed or removed, you'll be aware (doc generation will fail). I dont think it is possible to do it in `contributing-docs` because they are 2 different doc repos
```suggestion
``airflow users`` command is only available when :doc:`apache-airflow-providers-fab:auth-manager/index` is enabled.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a note `airflow users` command is available when FAB auth-manager is enabled [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #46862:
URL: https://github.com/apache/airflow/pull/46862#discussion_r1960117759
##########
contributing-docs/03_contributors_quick_start.rst:
##########
@@ -462,6 +462,8 @@ see in CI in your local environment.
--role Admin \
--email admin@example.org
+.. note::
+ ``airflow users`` command is only available when FAB auth manager is enabled.
Review Comment:
Users might not be aware of the concept of auth managers. I think we should add a link to https://airflow.apache.org/docs/apache-airflow-providers-fab/stable/auth-manager/index.html. Maybe make "FAB auth manager" clickable towards https://airflow.apache.org/docs/apache-airflow-providers-fab/stable/auth-manager/index.html?
That applies to your other changes as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a note `airflow users` command is available when FAB auth-manager is enabled [airflow]
Posted by "jx2lee (via GitHub)" <gi...@apache.org>.
jx2lee commented on code in PR #46862:
URL: https://github.com/apache/airflow/pull/46862#discussion_r1961472695
##########
contributing-docs/03_contributors_quick_start.rst:
##########
@@ -462,6 +462,8 @@ see in CI in your local environment.
--role Admin \
--email admin@example.org
+.. note::
+ ``airflow users`` command is only available when FAB auth manager is enabled.
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a note `airflow users` command is available when FAB auth-manager is enabled [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck merged PR #46862:
URL: https://github.com/apache/airflow/pull/46862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org