You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by Nathan Bubna <na...@esha.com> on 2002/05/07 17:06:00 UTC
[Veltools] revised ToolboxManager proposal & code
Gabe,
I tried to send this yesterday, but the mailer-daemon returned it to me.
Anyway, I've attached a zip file with the new classes and a patch for the
existing ones.
Changes from my last proposal are:
-changed ContextTool to ViewTool (that's "view" as in "view layer" not
"velocity view servlet")
-synchronized instantiation of session tools in ServletToolboxManager
To summarize the proposal:
Add the seven attached classes:
ToolboxManager
XMLToolboxManager
ViewTool
ToolInfo
DataInfo
ViewToolInfo
ServletToolInfo
Remove the following classes:
ServletViewToolLogger
ContextViewTool
LogEnabledViewTool
LogEnabledViewToolImpl
ServletViewTool
ThreadSafeViewTool
ViewToolLogger
The following classes are changed by the attached patch:
ServletToolboxManager (also attached as a file)
ViewContext (javadoc change only)
MultiViewsTool (implement ViewTool)
ErrorsTool (implement ViewTool. log to ServletContext directly)
FormTool (implement ViewTool)
LinkTool (implement ViewTool. log to ServletContext directly)
MessageTool (implement ViewTool. log to ServletContext directly)
DateTool (removed ThreadSafeViewTool)
MathTool (removed ThreadSafeViewTool)
ParameterParser (removed ThreadSafeViewTool)
ToolLoader (refactor to return class instance instead of directly
manipulating context)
Nathan Bubna
nathan@esha.com
Re: [Veltools] is there a problem with the Ant script?
Posted by Jeff Duska <Je...@noaa.gov>.
never mind... :-[
I figured out what was the problem. Eclipse had the one of the jar files
locked.
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [Veltools] is there a problem with the Ant script?
Posted by Jeff Duska <Je...@noaa.gov>.
I didn't see any comments on this. I'm still getting these errors with
the Ant script. I just refreshed the source from CVS to see if anyone
made a change.
Jeff.Duska wrote:
> I've been playing around with the VelTools in the both NetBeans and
> Eclipse. Both died on the project :( So, I'm building it from the Ant
> script using both the built-in support in Eclipse and at the command
> line. Is anyone else having problems with it?
>
> I'm getting BUILD FAILED at the command line.
>
> The Eclipse version shows more detail here is that output trimed to
> just the errors. I think most of it has to do with creating the
> documenation using and a missing template. The one seem the most
> imporant was the exception. It also looks like something is just wrong
> in index.xml. I just not up to speed enough on to figure what needs to
> be fixed.
>
> Anyhow here it is
>
> -------- velocity-tools-view 0.7 --------
>
> Loading stylesheet
> C:\eclipse\workspace\jakarta-velocity-tools\xdocs\site.dvsl
> [error] ResourceManager : unable to find resource
> 'VM_global_library.vm' in any resource loader.
>
> Transforming into C:\eclipse\workspace\jakarta-velocity-tools\view\docs
> Processing
> C:\eclipse\workspace\jakarta-velocity-tools\view\xdocs\velservlet.xml
> to C:\eclipse\workspace\jakarta-velocity-tools\view\docs\velservlet.html
> Loading stylesheet
> C:\eclipse\workspace\jakarta-velocity-tools\xdocs\site.dvsl
> [error] ResourceManager : unable to find resource
> 'VM_global_library.vm' in any resource loader.
>
> -------- velocity-tools-library 0.2 --------
>
> Loading stylesheet
> C:\eclipse\workspace\jakarta-velocity-tools\xdocs\site.dvsl
> [error] ResourceManager : unable to find resource
> 'VM_global_library.vm' in any resource loader.
>
> Loading stylesheet
> C:\eclipse\workspace\jakarta-velocity-tools\xdocs\site.dvsl
> [error] ResourceManager : unable to find resource
> 'VM_global_library.vm' in any resource loader.
>
> -------- velocity-tools-struts 0.8 --------
>
> Loading stylesheet
> C:\eclipse\workspace\jakarta-velocity-tools\xdocs\site.dvsl
> [error] ResourceManager : unable to find resource
> 'VM_global_library.vm' in any resource loader.
>
> Loading stylesheet
> C:\eclipse\workspace\jakarta-velocity-tools\xdocs\site.dvsl
> [error] ResourceManager : unable to find resource
> 'VM_global_library.vm' in any resource loader.
>
> -------- VelocityStruts Example --------
> Compiling 10 source files to
> C:\eclipse\workspace\jakarta-velocity-tools\struts\examples\struts\WEB-INF\classes
>
> Copying 2 files to
> C:\eclipse\workspace\jakarta-velocity-tools\struts\examples\struts\WEB-INF\classes
>
> Building jar:
> C:\eclipse\workspace\jakarta-velocity-tools\struts\examples\velstruts.war
> Warning: selected jar files include a META-INF/MANIFEST.MF which will
> be ignored (please use manifest attribute to jar task)
>
> -------- velocity-tools 0.1 --------
> Loading stylesheet
> C:\eclipse\workspace\jakarta-velocity-tools\xdocs\site.dvsl
> [error] ResourceManager : unable to find resource
> 'VM_global_library.vm' in any resource loader.
>
> Processing C:\eclipse\workspace\jakarta-velocity-tools\xdocs\index.xml
> to C:\eclipse\workspace\jakarta-velocity-tools\docs\index.html
> [error] Method selectSingleNode threw exception for reference $node in
> template document at [59,22]
> [error] Method applyTemplates threw exception for reference $context
> in template null at [5,14]
> Failed to process
> C:\eclipse\workspace\jakarta-velocity-tools\xdocs\index.xml
> Build exception:
> C:\eclipse\workspace\jakarta-velocity-tools\build.xml:213:
> org.apache.velocity.exception.MethodInvocationException: Invocation of
> method 'applyTemplates' in class org.apache.tools.dvsl.Transformer
> threw exception class
> org.apache.velocity.exception.MethodInvocationException : Invocation
> of method 'selectSingleNode' in class
> org.apache.tools.dvsl.dom4j.Dom4jNodeImpl threw exception class
> org.dom4j.XPathException : Exception occurred evaluting XPath:
> document('xdocs/menue.xml')/project. Exception: Failed to parse
> doucment for URI: xdocs/menue.xml
> Build exception:
> C:\eclipse\workspace\jakarta-velocity-tools\build.xml:213:
> org.apache.velocity.exception.MethodInvocationException: Invocation of
> method 'applyTemplates' in class org.apache.tools.dvsl.Transformer
> threw exception class
> org.apache.velocity.exception.MethodInvocationException : Invocation
> of method 'selectSingleNode' in class
> org.apache.tools.dvsl.dom4j.Dom4jNodeImpl threw exception class
> org.dom4j.XPathException : Exception occurred evaluting XPath:
> document('xdocs/menue.xml')/project. Exception: Failed to parse
> doucment for URI: xdocs/menue.xml
> C:\eclipse\workspace\jakarta-velocity-tools\build.xml:213:
> org.apache.velocity.exception.MethodInvocationException: Invocation of
> method 'applyTemplates' in class org.apache.tools.dvsl.Transformer
> threw exception class
> org.apache.velocity.exception.MethodInvocationException : Invocation
> of method 'selectSingleNode' in class
> org.apache.tools.dvsl.dom4j.Dom4jNodeImpl threw exception class
> org.dom4j.XPathException : Exception occurred evaluting XPath:
> document('xdocs/menue.xml')/project. Exception: Failed to parse
> doucment for URI: xdocs/menue.xml
> at org.apache.tools.dvsl.DVSLTask.process(DVSLTask.java:597)
> at org.apache.tools.dvsl.DVSLTask.execute(DVSLTask.java:355)
> at
> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:104)
> at org.apache.tools.ant.Task.perform(Task.java:217)
> at org.apache.tools.ant.Target.execute(Target.java:184)
> at org.apache.tools.ant.Target.performTasks(Target.java:202)
> at org.apache.tools.ant.Project.executeTarget(Project.java:601)
> at org.apache.tools.ant.Project.executeTargets(Project.java:560)
> at
> org.eclipse.ant.internal.core.ant.InternalAntRunner.run(InternalAntRunner.java:262)
>
> at java.lang.reflect.Method.invoke(Native Method)
> at org.eclipse.ant.core.AntRunner.run(AntRunner.java:150)
> at
> org.eclipse.ui.externaltools.internal.core.AntFileRunner.execute(AntFileRunner.java:53)
>
> at
> org.eclipse.ui.externaltools.internal.core.DefaultRunnerContext.executeRunner(DefaultRunnerContext.java:193)
>
> at
> org.eclipse.ui.externaltools.internal.core.DefaultRunnerContext.run(DefaultRunnerContext.java:243)
>
> at
> org.eclipse.ui.externaltools.internal.ui.AntLaunchWizard$1.run(AntLaunchWizard.java:116)
>
> at
> org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:98)
>
> --- Nested Exception ---
> org.apache.velocity.exception.MethodInvocationException: Invocation of
> method 'applyTemplates' in class org.apache.tools.dvsl.Transformer
> threw exception class
> org.apache.velocity.exception.MethodInvocationException : Invocation
> of method 'selectSingleNode' in class
> org.apache.tools.dvsl.dom4j.Dom4jNodeImpl threw exception class
> org.dom4j.XPathException : Exception occurred evaluting XPath:
> document('xdocs/menue.xml')/project. Exception: Failed to parse
> doucment for URI: xdocs/menue.xml
> at
> org.apache.velocity.runtime.parser.node.ASTMethod.execute(ASTMethod.java:308)
>
> at
> org.apache.velocity.runtime.parser.node.ASTReference.execute(ASTReference.java:207)
>
> at
> org.apache.velocity.runtime.parser.node.ASTReference.render(ASTReference.java:250)
>
> at
> org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:94)
> at
> org.apache.tools.dvsl.TemplateHandler.render(TemplateHandler.java:143)
> at org.apache.tools.dvsl.Transformer.invoke(Transformer.java:216)
> at org.apache.tools.dvsl.Transformer.transform(Transformer.java:201)
> at org.apache.tools.dvsl.Transformer.transform(Transformer.java:179)
> at org.apache.tools.dvsl.Transformer.transform(Transformer.java:165)
> at org.apache.tools.dvsl.DVSL.xform(DVSL.java:531)
> at org.apache.tools.dvsl.DVSL.transform(DVSL.java:551)
> at org.apache.tools.dvsl.DVSLTask.transform(DVSLTask.java:654)
> at org.apache.tools.dvsl.DVSLTask.process(DVSLTask.java:579)
> at org.apache.tools.dvsl.DVSLTask.execute(DVSLTask.java:355)
> at
> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:104)
> at org.apache.tools.ant.Task.perform(Task.java:217)
> at org.apache.tools.ant.Target.execute(Target.java:184)
> at org.apache.tools.ant.Target.performTasks(Target.java:202)
> at org.apache.tools.ant.Project.executeTarget(Project.java:601)
> at org.apache.tools.ant.Project.executeTargets(Project.java:560)
> at
> org.eclipse.ant.internal.core.ant.InternalAntRunner.run(InternalAntRunner.java:262)
>
> at java.lang.reflect.Method.invoke(Native Method)
> at org.eclipse.ant.core.AntRunner.run(AntRunner.java:150)
> at
> org.eclipse.ui.externaltools.internal.core.AntFileRunner.execute(AntFileRunner.java:53)
>
> at
> org.eclipse.ui.externaltools.internal.core.DefaultRunnerContext.executeRunner(DefaultRunnerContext.java:193)
>
> at
> org.eclipse.ui.externaltools.internal.core.DefaultRunnerContext.run(DefaultRunnerContext.java:243)
>
> at
> org.eclipse.ui.externaltools.internal.ui.AntLaunchWizard$1.run(AntLaunchWizard.java:116)
>
> at
> org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:98)
>
>
>
> Thanks,
>
> Jeff Duska
> jeff.duska@noaa.gov
> jeff@duska.com
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
[Veltools] is there a problem with the Ant script?
Posted by Jeff Duska <Je...@noaa.gov>.
I've been playing around with the VelTools in the both NetBeans and
Eclipse. Both died on the project :( So, I'm building it from the Ant
script using both the built-in support in Eclipse and at the command
line. Is anyone else having problems with it?
I'm getting BUILD FAILED at the command line.
The Eclipse version shows more detail here is that output trimed to just
the errors. I think most of it has to do with creating the documenation
using and a missing template. The one seem the most imporant was the
exception. It also looks like something is just wrong in index.xml. I
just not up to speed enough on to figure what needs to be fixed.
Anyhow here it is
-------- velocity-tools-view 0.7 --------
Loading stylesheet
C:\eclipse\workspace\jakarta-velocity-tools\xdocs\site.dvsl
[error] ResourceManager : unable to find resource
'VM_global_library.vm' in any resource loader.
Transforming into C:\eclipse\workspace\jakarta-velocity-tools\view\docs
Processing
C:\eclipse\workspace\jakarta-velocity-tools\view\xdocs\velservlet.xml to
C:\eclipse\workspace\jakarta-velocity-tools\view\docs\velservlet.html
Loading stylesheet
C:\eclipse\workspace\jakarta-velocity-tools\xdocs\site.dvsl
[error] ResourceManager : unable to find resource
'VM_global_library.vm' in any resource loader.
-------- velocity-tools-library 0.2 --------
Loading stylesheet
C:\eclipse\workspace\jakarta-velocity-tools\xdocs\site.dvsl
[error] ResourceManager : unable to find resource
'VM_global_library.vm' in any resource loader.
Loading stylesheet
C:\eclipse\workspace\jakarta-velocity-tools\xdocs\site.dvsl
[error] ResourceManager : unable to find resource
'VM_global_library.vm' in any resource loader.
-------- velocity-tools-struts 0.8 --------
Loading stylesheet
C:\eclipse\workspace\jakarta-velocity-tools\xdocs\site.dvsl
[error] ResourceManager : unable to find resource
'VM_global_library.vm' in any resource loader.
Loading stylesheet
C:\eclipse\workspace\jakarta-velocity-tools\xdocs\site.dvsl
[error] ResourceManager : unable to find resource
'VM_global_library.vm' in any resource loader.
-------- VelocityStruts Example --------
Compiling 10 source files to
C:\eclipse\workspace\jakarta-velocity-tools\struts\examples\struts\WEB-INF\classes
Copying 2 files to
C:\eclipse\workspace\jakarta-velocity-tools\struts\examples\struts\WEB-INF\classes
Building jar:
C:\eclipse\workspace\jakarta-velocity-tools\struts\examples\velstruts.war
Warning: selected jar files include a META-INF/MANIFEST.MF which will be
ignored (please use manifest attribute to jar task)
-------- velocity-tools 0.1 --------
Loading stylesheet
C:\eclipse\workspace\jakarta-velocity-tools\xdocs\site.dvsl
[error] ResourceManager : unable to find resource
'VM_global_library.vm' in any resource loader.
Processing C:\eclipse\workspace\jakarta-velocity-tools\xdocs\index.xml
to C:\eclipse\workspace\jakarta-velocity-tools\docs\index.html
[error] Method selectSingleNode threw exception for reference $node in
template document at [59,22]
[error] Method applyTemplates threw exception for reference $context in
template null at [5,14]
Failed to process
C:\eclipse\workspace\jakarta-velocity-tools\xdocs\index.xml
Build exception:
C:\eclipse\workspace\jakarta-velocity-tools\build.xml:213:
org.apache.velocity.exception.MethodInvocationException: Invocation of
method 'applyTemplates' in class org.apache.tools.dvsl.Transformer
threw exception class
org.apache.velocity.exception.MethodInvocationException : Invocation of
method 'selectSingleNode' in class
org.apache.tools.dvsl.dom4j.Dom4jNodeImpl threw exception class
org.dom4j.XPathException : Exception occurred evaluting XPath:
document('xdocs/menue.xml')/project. Exception: Failed to parse doucment
for URI: xdocs/menue.xml
Build exception:
C:\eclipse\workspace\jakarta-velocity-tools\build.xml:213:
org.apache.velocity.exception.MethodInvocationException: Invocation of
method 'applyTemplates' in class org.apache.tools.dvsl.Transformer
threw exception class
org.apache.velocity.exception.MethodInvocationException : Invocation of
method 'selectSingleNode' in class
org.apache.tools.dvsl.dom4j.Dom4jNodeImpl threw exception class
org.dom4j.XPathException : Exception occurred evaluting XPath:
document('xdocs/menue.xml')/project. Exception: Failed to parse doucment
for URI: xdocs/menue.xml
C:\eclipse\workspace\jakarta-velocity-tools\build.xml:213:
org.apache.velocity.exception.MethodInvocationException: Invocation of
method 'applyTemplates' in class org.apache.tools.dvsl.Transformer
threw exception class
org.apache.velocity.exception.MethodInvocationException : Invocation of
method 'selectSingleNode' in class
org.apache.tools.dvsl.dom4j.Dom4jNodeImpl threw exception class
org.dom4j.XPathException : Exception occurred evaluting XPath:
document('xdocs/menue.xml')/project. Exception: Failed to parse doucment
for URI: xdocs/menue.xml
at org.apache.tools.dvsl.DVSLTask.process(DVSLTask.java:597)
at org.apache.tools.dvsl.DVSLTask.execute(DVSLTask.java:355)
at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:104)
at org.apache.tools.ant.Task.perform(Task.java:217)
at org.apache.tools.ant.Target.execute(Target.java:184)
at org.apache.tools.ant.Target.performTasks(Target.java:202)
at org.apache.tools.ant.Project.executeTarget(Project.java:601)
at org.apache.tools.ant.Project.executeTargets(Project.java:560)
at
org.eclipse.ant.internal.core.ant.InternalAntRunner.run(InternalAntRunner.java:262)
at java.lang.reflect.Method.invoke(Native Method)
at org.eclipse.ant.core.AntRunner.run(AntRunner.java:150)
at
org.eclipse.ui.externaltools.internal.core.AntFileRunner.execute(AntFileRunner.java:53)
at
org.eclipse.ui.externaltools.internal.core.DefaultRunnerContext.executeRunner(DefaultRunnerContext.java:193)
at
org.eclipse.ui.externaltools.internal.core.DefaultRunnerContext.run(DefaultRunnerContext.java:243)
at
org.eclipse.ui.externaltools.internal.ui.AntLaunchWizard$1.run(AntLaunchWizard.java:116)
at
org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:98)
--- Nested Exception ---
org.apache.velocity.exception.MethodInvocationException: Invocation of
method 'applyTemplates' in class org.apache.tools.dvsl.Transformer
threw exception class
org.apache.velocity.exception.MethodInvocationException : Invocation of
method 'selectSingleNode' in class
org.apache.tools.dvsl.dom4j.Dom4jNodeImpl threw exception class
org.dom4j.XPathException : Exception occurred evaluting XPath:
document('xdocs/menue.xml')/project. Exception: Failed to parse doucment
for URI: xdocs/menue.xml
at
org.apache.velocity.runtime.parser.node.ASTMethod.execute(ASTMethod.java:308)
at
org.apache.velocity.runtime.parser.node.ASTReference.execute(ASTReference.java:207)
at
org.apache.velocity.runtime.parser.node.ASTReference.render(ASTReference.java:250)
at
org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:94)
at
org.apache.tools.dvsl.TemplateHandler.render(TemplateHandler.java:143)
at org.apache.tools.dvsl.Transformer.invoke(Transformer.java:216)
at org.apache.tools.dvsl.Transformer.transform(Transformer.java:201)
at org.apache.tools.dvsl.Transformer.transform(Transformer.java:179)
at org.apache.tools.dvsl.Transformer.transform(Transformer.java:165)
at org.apache.tools.dvsl.DVSL.xform(DVSL.java:531)
at org.apache.tools.dvsl.DVSL.transform(DVSL.java:551)
at org.apache.tools.dvsl.DVSLTask.transform(DVSLTask.java:654)
at org.apache.tools.dvsl.DVSLTask.process(DVSLTask.java:579)
at org.apache.tools.dvsl.DVSLTask.execute(DVSLTask.java:355)
at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:104)
at org.apache.tools.ant.Task.perform(Task.java:217)
at org.apache.tools.ant.Target.execute(Target.java:184)
at org.apache.tools.ant.Target.performTasks(Target.java:202)
at org.apache.tools.ant.Project.executeTarget(Project.java:601)
at org.apache.tools.ant.Project.executeTargets(Project.java:560)
at
org.eclipse.ant.internal.core.ant.InternalAntRunner.run(InternalAntRunner.java:262)
at java.lang.reflect.Method.invoke(Native Method)
at org.eclipse.ant.core.AntRunner.run(AntRunner.java:150)
at
org.eclipse.ui.externaltools.internal.core.AntFileRunner.execute(AntFileRunner.java:53)
at
org.eclipse.ui.externaltools.internal.core.DefaultRunnerContext.executeRunner(DefaultRunnerContext.java:193)
at
org.eclipse.ui.externaltools.internal.core.DefaultRunnerContext.run(DefaultRunnerContext.java:243)
at
org.eclipse.ui.externaltools.internal.ui.AntLaunchWizard$1.run(AntLaunchWizard.java:116)
at
org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:98)
Thanks,
Jeff Duska
jeff.duska@noaa.gov
jeff@duska.com
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [Veltools] revised ToolboxManager proposal & code
Posted by Gabriel Sidler <si...@teamup.ch>.
Nathan, I just commited your contribution.
Gabe
PS: I am leaving for a business trip today and back to a computer
not before Sunday.
Nathan Bubna wrote:
> Gabe,
>
> I tried to send this yesterday, but the mailer-daemon returned it to me.
> Anyway, I've attached a zip file with the new classes and a patch for the
> existing ones.
>
> Changes from my last proposal are:
> -changed ContextTool to ViewTool (that's "view" as in "view layer" not
> "velocity view servlet")
> -synchronized instantiation of session tools in ServletToolboxManager
>
> To summarize the proposal:
> Add the seven attached classes:
> ToolboxManager
> XMLToolboxManager
> ViewTool
> ToolInfo
> DataInfo
> ViewToolInfo
> ServletToolInfo
>
> Remove the following classes:
> ServletViewToolLogger
> ContextViewTool
> LogEnabledViewTool
> LogEnabledViewToolImpl
> ServletViewTool
> ThreadSafeViewTool
> ViewToolLogger
>
> The following classes are changed by the attached patch:
> ServletToolboxManager (also attached as a file)
> ViewContext (javadoc change only)
> MultiViewsTool (implement ViewTool)
> ErrorsTool (implement ViewTool. log to ServletContext directly)
> FormTool (implement ViewTool)
> LinkTool (implement ViewTool. log to ServletContext directly)
> MessageTool (implement ViewTool. log to ServletContext directly)
> DateTool (removed ThreadSafeViewTool)
> MathTool (removed ThreadSafeViewTool)
> ParameterParser (removed ThreadSafeViewTool)
> ToolLoader (refactor to return class instance instead of directly
> manipulating context)
>
> Nathan Bubna
> nathan@esha.com
>
>
>
> ------------------------------------------------------------------------
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
--
--
Gabriel Sidler
Software Engineer, Eivycom GmbH, Zurich, Switzerland
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [Veltools] revised ToolboxManager proposal & code
Posted by Nathan Bubna <na...@esha.com>.
Gabe said:
> > I tried to send this yesterday, but the mailer-daemon returned it to me.
>
> A mail from you with attachments succeeded was last night on the
velocity-users
> list. I assume it's the same, right?
oops. i guess i sent it to the user list last night. i wonder why it got
returned to me as an error. oh well, it doesn't really matter. yes, the
code i sent last night is the same.
Nathan Bubna
nathan@esha.com
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [Veltools] revised ToolboxManager proposal & code
Posted by Gabriel Sidler <si...@teamup.ch>.
Thanks, got it. I'll try to get this in tonight.
Nathan Bubna wrote:
> Gabe,
>
> I tried to send this yesterday, but the mailer-daemon returned it to me.
A mail from you with attachments succeeded was last night on the velocity-users
list. I assume it's the same, right?
Gabe
> Anyway, I've attached a zip file with the new classes and a patch for the
> existing ones.
>
> Changes from my last proposal are:
> -changed ContextTool to ViewTool (that's "view" as in "view layer" not
> "velocity view servlet")
> -synchronized instantiation of session tools in ServletToolboxManager
>
> To summarize the proposal:
> Add the seven attached classes:
> ToolboxManager
> XMLToolboxManager
> ViewTool
> ToolInfo
> DataInfo
> ViewToolInfo
> ServletToolInfo
>
> Remove the following classes:
> ServletViewToolLogger
> ContextViewTool
> LogEnabledViewTool
> LogEnabledViewToolImpl
> ServletViewTool
> ThreadSafeViewTool
> ViewToolLogger
>
> The following classes are changed by the attached patch:
> ServletToolboxManager (also attached as a file)
> ViewContext (javadoc change only)
> MultiViewsTool (implement ViewTool)
> ErrorsTool (implement ViewTool. log to ServletContext directly)
> FormTool (implement ViewTool)
> LinkTool (implement ViewTool. log to ServletContext directly)
> MessageTool (implement ViewTool. log to ServletContext directly)
> DateTool (removed ThreadSafeViewTool)
> MathTool (removed ThreadSafeViewTool)
> ParameterParser (removed ThreadSafeViewTool)
> ToolLoader (refactor to return class instance instead of directly
> manipulating context)
>
> Nathan Bubna
> nathan@esha.com
>
>
>
> ------------------------------------------------------------------------
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
--
--
Gabriel Sidler
Software Engineer, Eivycom GmbH, Zurich, Switzerland
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>