[GitHub] [hudi] nsivabalan commented on a change in pull request #4977: [HUDI-2871] Decouple metrics dependencies from hudi-client-common

[GitBox <gi...@apache.org>]

nsivabalan commented on a change in pull request #4977:
URL: https://github.com/apache/hudi/pull/4977#discussion_r822175346



##########
File path: hudi-cli/src/test/java/org/apache/hudi/cli/testutils/SparkUtilTest.java
##########
@@ -7,21 +7,32 @@
  * "License"); you may not use this file except in compliance
  * with the License.  You may obtain a copy of the License at
  *
+<<<<<<< HEAD
  *      http://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
+=======
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+>>>>>>> [HUDI-2871] Decouple metrics dependencies from hudi-client-common

Review comment:
       guess the conflicts were not resolved correctly. 

##########
File path: hudi-metrics-common/src/main/java/org/apache/hudi/metrics/config/HoodieMetricsConfig.java
##########
@@ -46,6 +52,11 @@
 
   public static final String METRIC_PREFIX = "hoodie.metrics";
 
+  public static final ConfigProperty<String> TBL_NAME = ConfigProperty

Review comment:
       we don't want to duplicate the configs.can we rely on HoodieTableConfig only for table name.

##########
File path: hudi-metrics-common/src/main/java/org/apache/hudi/metrics/HoodieMetricRegistry.java
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.metrics;
+
+import com.codahale.metrics.MetricRegistry;
+import org.apache.log4j.LogManager;
+import org.apache.log4j.Logger;
+
+public class HoodieMetricRegistry {

Review comment:
       Can you add java docs as to why we need this class.

##########
File path: hudi-metrics-common/src/main/java/org/apache/hudi/metrics/config/HoodieMetricsCloudWatchConfig.java
##########
@@ -38,20 +39,37 @@
   public static final ConfigProperty<Integer> REPORT_PERIOD_SECONDS = ConfigProperty
           .key(CLOUDWATCH_PREFIX + ".report.period.seconds")
           .defaultValue(60)
-          .sinceVersion("0.10.0")

Review comment:
       can we revert any unintentional changes. tough to review just the required changes alone. 

##########
File path: packaging/hudi-kafka-connect-bundle/pom.xml
##########
@@ -80,7 +81,7 @@
                                     <include>org.apache.hudi:hudi-sync-common</include>
                                     <include>org.apache.hudi:hudi-hadoop-mr</include>
                                     <include>org.apache.hudi:hudi-timeline-service</include>
-                                    <include>org.apache.hudi:hudi-aws</include>
+                                    <!--                                    <include>org.apache.hudi:hudi-aws</include>-->

Review comment:
       can we remove this line if not required? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org