You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/06/10 11:48:45 UTC
[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request #1106: MINIFICPP-1590 Log output of exited containers in integration tests
lordgamez opened a new pull request #1106:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1106
Exited container output is logged in case of failures for easier debugging.
Jira ticket: https://issues.apache.org/jira/browse/MINIFICPP-1590
----------------------------------------------------------------------------------------------
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #1106: MINIFICPP-1590 Log output of exited containers in integration tests
Posted by GitBox <gi...@apache.org>.
arpadboda closed pull request #1106:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez edited a comment on pull request #1106: MINIFICPP-1590 Log output of exited containers in integration tests
Posted by GitBox <gi...@apache.org>.
lordgamez edited a comment on pull request #1106:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1106#issuecomment-859575961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #1106: MINIFICPP-1590 Log output of exited containers in integration tests
Posted by GitBox <gi...@apache.org>.
szaszm commented on pull request #1106:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1106#issuecomment-859560061
I checked the docker integration test output here vs your other PR #1101, and I'm not sure which part is new. We have behave logs and minifi logs in both runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #1106: MINIFICPP-1590 Log output of exited containers in integration tests
Posted by GitBox <gi...@apache.org>.
lordgamez commented on pull request #1106:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1106#issuecomment-859575961
> I checked the docker integration test output here vs your other PR #1101, and I'm not sure which part is new. We have behave logs and minifi logs in both runs.
The output only differs if the startup fails or if the process in the container crashes after startup. For example in case of configuration failure the container exits and we did not have any logs of it. One instance of this previously was when in the `PutFile does not overwrite a file that already exists` scenario of the `file_system_operations.feature` two uuids were the same and no log entries were logged from Minifi.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org