You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2019/12/24 09:15:06 UTC
[GitHub] [incubator-shardingsphere] xiyelife opened a new pull request #3795: Fixes #3770. Delete the plain columns jadge when encrypt rules are …
xiyelife opened a new pull request #3795: Fixes #3770. Delete the plain columns jadge when encrypt rules are …
URL: https://github.com/apache/incubator-shardingsphere/pull/3795
…configured like that logic columns are the same as plain columns.
Fixes #3770
Changes proposed in this pull request:
- Delete the plain columns jadge when encrypt rules are configured like that logic columns are the same as plain columns.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife commented on issue #3795: Fixes #3770. Delete the plain columns judgement when encrypt rules are …
Posted by GitBox <gi...@apache.org>.
xiyelife commented on issue #3795: Fixes #3770. Delete the plain columns judgement when encrypt rules are …
URL: https://github.com/apache/incubator-shardingsphere/pull/3795#issuecomment-568865463
sharding-core test run failed, I'll test and modify later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife commented on issue #3795: Fixes
#3770. if the logic columns are the same as the plain columns also add the
plain columns and the parameters to the rewrited SQL.
Posted by GitBox <gi...@apache.org>.
xiyelife commented on issue #3795: Fixes #3770. if the logic columns are the same as the plain columns also add the plain columns and the parameters to the rewrited SQL.
URL: https://github.com/apache/incubator-shardingsphere/pull/3795#issuecomment-569023403
@tristaZero All right，I see.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue
#3795: Fixes #3770. if the logic columns are the same as the plain columns
also add the plain columns and the parameters to the rewrited SQL.
Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on issue #3795: Fixes #3770. if the logic columns are the same as the plain columns also add the plain columns and the parameters to the rewrited SQL.
URL: https://github.com/apache/incubator-shardingsphere/pull/3795#issuecomment-569169113
#3809 answered the related issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #3795:
Fixes #3770. if the logic columns are the same as the plain columns also
add the plain columns and the parameters to the rewrited SQL.
Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #3795: Fixes #3770. if the logic columns are the same as the plain columns also add the plain columns and the parameters to the rewrited SQL.
URL: https://github.com/apache/incubator-shardingsphere/pull/3795#issuecomment-569017807
Hi @xiyelife Thanks your contribution, i found #3770 is caused by another PR, therefore we decided to rollback the last PR to solve #3770 from the source.
@KomachiSion could you refer the problem PR to this one? After that, i willl close this PR. Again @xiyelife Thank you to remind us this issue. Hope see your interaction more in community. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #3795:
Fixes #3770. if the logic columns are the same as the plain columns also
add the plain columns and the parameters to the rewrited SQL.
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #3795: Fixes #3770. if the logic columns are the same as the plain columns also add the plain columns and the parameters to the rewrited SQL.
URL: https://github.com/apache/incubator-shardingsphere/pull/3795#issuecomment-568955240
## Pull Request Test Coverage Report for [Build 1226](https://coveralls.io/builds/27793795)
* **14** of **22** **(63.64%)** changed or added relevant lines in **4** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage decreased (**-0.01%**) to **67.262%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [encrypt-core/encrypt-core-rewrite/src/main/java/org/apache/shardingsphere/encrypt/rewrite/parameter/impl/EncryptInsertValueParameterRewriter.java](https://coveralls.io/builds/27793795/source?filename=encrypt-core%2Fencrypt-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Frewrite%2Fparameter%2Fimpl%2FEncryptInsertValueParameterRewriter.java#L123) | 5 | 8 | 62.5%
| [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/strategy/encrypt/EncryptTable.java](https://coveralls.io/builds/27793795/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fstrategy%2Fencrypt%2FEncryptTable.java#L74) | 0 | 5 | 0.0%
<!-- | **Total:** | **14** | **22** | **63.64%** | -->
| Totals | [](https://coveralls.io/builds/27793795) |
| :-- | --: |
| Change from base [Build 626](https://coveralls.io/builds/27780114): | -0.01% |
| Covered Lines: | 11298 |
| Relevant Lines: | 16797 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero closed pull request #3795:
Fixes #3770. if the logic columns are the same as the plain columns also
add the plain columns and the parameters to the rewrited SQL.
Posted by GitBox <gi...@apache.org>.
tristaZero closed pull request #3795: Fixes #3770. if the logic columns are the same as the plain columns also add the plain columns and the parameters to the rewrited SQL.
URL: https://github.com/apache/incubator-shardingsphere/pull/3795
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #3795: Fixes #3770. Delete the plain columns judgement when encrypt rules are …
Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #3795: Fixes #3770. Delete the plain columns judgement when encrypt rules are …
URL: https://github.com/apache/incubator-shardingsphere/pull/3795#issuecomment-568888104
@xiyelife Sorry for that, i notified it to other colleagues. Besides, waiting for some time and trying again is always an appropriate option, you know. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #3795:
Fixes #3770. if the logic columns are the same as the plain columns also
add the plain columns and the parameters to the rewrited SQL.
Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #3795: Fixes #3770. if the logic columns are the same as the plain columns also add the plain columns and the parameters to the rewrited SQL.
URL: https://github.com/apache/incubator-shardingsphere/pull/3795#issuecomment-569169113
#3809 answears the related issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife commented on issue #3795: Fixes #3770. Delete the plain columns judgement when encrypt rules are …
Posted by GitBox <gi...@apache.org>.
xiyelife commented on issue #3795: Fixes #3770. Delete the plain columns judgement when encrypt rules are …
URL: https://github.com/apache/incubator-shardingsphere/pull/3795#issuecomment-568887030
@tristaZero I have commit pr again, but the CI is failed too......
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife edited a comment on issue #3795: Fixes #3770. Delete the plain columns judgement when encrypt rules are …
Posted by GitBox <gi...@apache.org>.
xiyelife edited a comment on issue #3795: Fixes #3770. Delete the plain columns judgement when encrypt rules are …
URL: https://github.com/apache/incubator-shardingsphere/pull/3795#issuecomment-568865463
sharding-core test run failed, I'll test and modify later
EncryptPreparedStatementTest.assertInsertWithFullColumns and EncryptPreparedStatementTest.assertInsertWithAssistedQueryColumn are testing failed for deleting the jdagement of plain columns.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife closed pull request #3795: Fixes #3770. Delete the plain columns judgement when encrypt rules are …
Posted by GitBox <gi...@apache.org>.
xiyelife closed pull request #3795: Fixes #3770. Delete the plain columns judgement when encrypt rules are …
URL: https://github.com/apache/incubator-shardingsphere/pull/3795
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #3795: Fixes #3770. Delete the plain columns judgement when encrypt rules are …
Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #3795: Fixes #3770. Delete the plain columns judgement when encrypt rules are …
URL: https://github.com/apache/incubator-shardingsphere/pull/3795#issuecomment-568886636
@xiyelife Hi, thanks for your pr. And my review would come after CI becomes ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife commented on issue #3795: Fixes #3770. Delete the plain columns judgement when encrypt rules are …
Posted by GitBox <gi...@apache.org>.
xiyelife commented on issue #3795: Fixes #3770. Delete the plain columns judgement when encrypt rules are …
URL: https://github.com/apache/incubator-shardingsphere/pull/3795#issuecomment-568830082
CI jenkins has OOM for Caused by: java.lang.OutOfMemoryError: unable to create new native thread
please replay my CI, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife edited a comment on issue #3795: Fixes #3770. Delete the plain columns judgement when encrypt rules are …
Posted by GitBox <gi...@apache.org>.
xiyelife edited a comment on issue #3795: Fixes #3770. Delete the plain columns judgement when encrypt rules are …
URL: https://github.com/apache/incubator-shardingsphere/pull/3795#issuecomment-568865463
sharding-core test run failed, I'll test and modify later
assertInsertWithFullColumns and assertInsertWithAssistedQueryColumn are testing failed for deleting the jdagement of plain columns.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife opened a new pull request #3795: Fixes #3770. Delete the plain columns judgement when encrypt rules are …
Posted by GitBox <gi...@apache.org>.
xiyelife opened a new pull request #3795: Fixes #3770. Delete the plain columns judgement when encrypt rules are …
URL: https://github.com/apache/incubator-shardingsphere/pull/3795
…configured like that logic columns are the same as plain columns.
Fixes #3770
Changes proposed in this pull request:
- Delete the plain columns judgement when encrypt rules are configured like that logic columns are the same as plain columns.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services