[GitHub] [solr] HoustonPutman commented on a change in pull request #654: SOLR-6443: Cleanup managedResourceTest

[GitBox <gi...@apache.org>]

HoustonPutman commented on a change in pull request #654:
URL: https://github.com/apache/solr/pull/654#discussion_r828262464



##########
File path: solr/core/src/test/org/apache/solr/rest/TestManagedResourceStorage.java
##########
@@ -36,28 +35,19 @@
 /**
  * Depends on ZK for testing ZooKeeper backed storage logic.
  */
-@Slow
-// commented 4-Sep-2018 @LuceneTestCase.BadApple(bugUrl = "https://issues.apache.org/jira/browse/SOLR-6443")
 public class TestManagedResourceStorage extends AbstractZkTestCase {
 
   /**
    * Runs persisted managed resource creation and update tests on Zookeeper storage.
    */
   @Test
   public void testZkBasedJsonStorage() throws Exception {
-    
-    // test using ZooKeeper
-    assertTrue("Not using ZooKeeper", h.getCoreContainer().isZooKeeperAware());
-    SolrResourceLoader loader = new SolrResourceLoader(Paths.get("./"));
     // Solr unit tests can only write to their working directory due to
     // a custom Java Security Manager installed in the test environment
-    NamedList<String> initArgs = new NamedList<>();
-    try {
+    try (SolrResourceLoader loader = new SolrResourceLoader(Paths.get("./"))) {

Review comment:
       probably a temporary directory




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org