Re: [PR] KAFKA-20220: Enable TimestampedKVStoreWithHeaders in DSL (1/N) [kafka]

["mjsax (via GitHub)" <gi...@apache.org>]

mjsax commented on code in PR #21572:
URL: https://github.com/apache/kafka/pull/21572#discussion_r2867035548


##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/AbstractConfigurableStoreFactory.java:
##########
@@ -40,13 +42,22 @@ public void configure(final StreamsConfig config) {
                 config.originals()
             );
         }
+        final String dslStoreFormatValue = config.getString(StreamsConfig.DSL_STORE_FORMAT_CONFIG);
+        if (dslStoreFormatValue.equalsIgnoreCase(StreamsConfig.DSL_STORE_FORMAT_HEADERS)) {
+            dslStoreFormat = DslStoreFormat.HEADERS;
+        }
+        // else dslStoreFormat remains null and the lower layers decide between PLAIN and TIMESTAMPED

Review Comment:
   I actually proposed, that we would pass `dslStoreFormatValue` down to lower layers, and let them translated the String config from `dsl.store.format` to the `DslStoreFormat` enum...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org