You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cloverhearts <gi...@git.apache.org> on 2016/07/18 16:29:23 UTC

[GitHub] zeppelin pull request #1202: [ZEPPELIN-1208] fixed user config button in nav...

GitHub user cloverhearts opened a pull request:

    https://github.com/apache/zeppelin/pull/1202

    [ZEPPELIN-1208] fixed user config button in navbar

    ### What is this PR for?
    icon for connect or disconnect
    invalid align in the mobile screen.
    See the screen shot.
    
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1208
    
    ### How should this be tested?
    Loading a web page from a mobile or Minimizing the width web browser.
    
    ### Screenshots (if appropriate)
    #### before
    ![cap 2016-07-19 01-22-56-717](https://cloud.githubusercontent.com/assets/10525473/16922334/213b38ea-4d50-11e6-8b15-0564ab88c570.png)
    ![cap 2016-07-19 01-23-08-542](https://cloud.githubusercontent.com/assets/10525473/16922337/22449df8-4d50-11e6-9eb6-9ba24d2e712b.png)
    
    #### after
    ![cap 2016-07-19 01-21-22-964](https://cloud.githubusercontent.com/assets/10525473/16922342/25b73e5a-4d50-11e6-87b1-005f00c79a5b.png)
    ![cap 2016-07-19 01-21-32-983](https://cloud.githubusercontent.com/assets/10525473/16922346/274d5ca4-4d50-11e6-8aed-0e1d3c4ebb5b.png)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloverhearts/zeppelin navbar-userid-padding

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1202.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1202
    
----
commit cb055f14ff2eb364d24d6deef12c88590206c336
Author: CloverHearts <cl...@gmail.com>
Date:   2016-07-18T16:20:38Z

    fixed user config button in navbar

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1202: [ZEPPELIN-1208] fixed invaild position user con...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1202


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1202: [ZEPPELIN-1208] fixed invaild position user config but...

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:

    https://github.com/apache/zeppelin/pull/1202
  
    Merging if there is no more discussions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1202: [ZEPPELIN-1208] fixed invaild position user config but...

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:

    https://github.com/apache/zeppelin/pull/1202
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---