You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org> on 2011/09/13 20:39:09 UTC

[jira] [Created] (TAP5-1643) Restore ability to contribute a library mapping that includes the "/" character (as was possible in 5.1)

Restore ability to contribute a library mapping that includes the "/" character (as was possible in 5.1)
--------------------------------------------------------------------------------------------------------

                 Key: TAP5-1643
                 URL: https://issues.apache.org/jira/browse/TAP5-1643
             Project: Tapestry 5
          Issue Type: Bug
          Components: tapestry-core
    Affects Versions: 5.3, 5.2
            Reporter: Howard M. Lewis Ship


This was allowed in 5.1 and earlier, as the value after the slash was intended to be a version number for the library.  With 5.2, there's a single version number ... but some HLS clients leverage the folder structure for some of their internal use cases and need to hack Tapestry to allow the slash in the folder name. It should be allowed (and handled efficiently).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1643) Restore ability to contribute a library mapping that includes the "/" character (as was possible in 5.1)

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104224#comment-13104224 ] 

Hudson commented on TAP5-1643:
------------------------------

Integrated in tapestry-trunk-freestyle #518 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/518/])
    TAP5-1643: Fix AssetDispatcher to handle paths that include folder names

Add test to prove it works
TAP5-1643: Allow slashes inside classpath asset aliases and paths
TAP5-1643: Allow slashes inside virtual folder names

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170395
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/AssetDispatcher.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/app1/Index.tml
* /tapestry/tapestry5/trunk/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/GroovyTapestryCoreTestCase.groovy
* /tapestry/tapestry5/trunk/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/LibraryTests.groovy
* /tapestry/tapestry5/trunk/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/appfolder/AppFolderTests.groovy
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/services/AppModule.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/locallib
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/locallib/alpha
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/locallib/alpha/pages
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/locallib/alpha/pages/AlphaRoot.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/integration/locallib
* /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/integration/locallib/alpha
* /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/integration/locallib/alpha/pages
* /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/integration/locallib/alpha/pages/AlphaRoot.tml
* /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/integration/locallib/alpha/pages/tapestry.png

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170394
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ClasspathAssetAliasManagerImpl.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/ClasspathAssetAliasManagerImplTest.java

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170393
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/InternalConstants.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/LibraryMapping.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/ComponentClassResolverImplTest.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/services/LibraryMappingTest.java
* /tapestry/tapestry5/trunk/tapestry-kaptcha/src/main/java/org/apache/tapestry5/kaptcha/services/KaptchaModule.java
* /tapestry/tapestry5/trunk/tapestry-upload/src/main/java/org/apache/tapestry5/upload/services/UploadModule.java


> Restore ability to contribute a library mapping that includes the "/" character (as was possible in 5.1)
> --------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1643
>                 URL: https://issues.apache.org/jira/browse/TAP5-1643
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3, 5.2
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>              Labels: backwards-compatibility
>             Fix For: 5.3
>
>
> This was allowed in 5.1 and earlier, as the value after the slash was intended to be a version number for the library.  With 5.2, there's a single version number ... but some HLS clients leverage the folder structure for some of their internal use cases and need to hack Tapestry to allow the slash in the folder name. It should be allowed (and handled efficiently).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (TAP5-1643) Restore ability to contribute a library mapping that includes the "/" character (as was possible in 5.1)

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship reassigned TAP5-1643:
------------------------------------------

    Assignee: Howard M. Lewis Ship

> Restore ability to contribute a library mapping that includes the "/" character (as was possible in 5.1)
> --------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1643
>                 URL: https://issues.apache.org/jira/browse/TAP5-1643
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3, 5.2
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>              Labels: backwards-compatibility
>
> This was allowed in 5.1 and earlier, as the value after the slash was intended to be a version number for the library.  With 5.2, there's a single version number ... but some HLS clients leverage the folder structure for some of their internal use cases and need to hack Tapestry to allow the slash in the folder name. It should be allowed (and handled efficiently).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (TAP5-1643) Restore ability to contribute a library mapping that includes the "/" character (as was possible in 5.1)

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-1643.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 5.3

> Restore ability to contribute a library mapping that includes the "/" character (as was possible in 5.1)
> --------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1643
>                 URL: https://issues.apache.org/jira/browse/TAP5-1643
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3, 5.2
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>              Labels: backwards-compatibility
>             Fix For: 5.3
>
>
> This was allowed in 5.1 and earlier, as the value after the slash was intended to be a version number for the library.  With 5.2, there's a single version number ... but some HLS clients leverage the folder structure for some of their internal use cases and need to hack Tapestry to allow the slash in the folder name. It should be allowed (and handled efficiently).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (TAP5-1643) Restore ability to contribute a library mapping that includes the "/" character (as was possible in 5.1)

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-1643.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 5.3

> Restore ability to contribute a library mapping that includes the "/" character (as was possible in 5.1)
> --------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1643
>                 URL: https://issues.apache.org/jira/browse/TAP5-1643
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3, 5.2
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>              Labels: backwards-compatibility
>             Fix For: 5.3
>
>
> This was allowed in 5.1 and earlier, as the value after the slash was intended to be a version number for the library.  With 5.2, there's a single version number ... but some HLS clients leverage the folder structure for some of their internal use cases and need to hack Tapestry to allow the slash in the folder name. It should be allowed (and handled efficiently).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1643) Restore ability to contribute a library mapping that includes the "/" character (as was possible in 5.1)

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104224#comment-13104224 ] 

Hudson commented on TAP5-1643:
------------------------------

Integrated in tapestry-trunk-freestyle #518 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/518/])
    TAP5-1643: Fix AssetDispatcher to handle paths that include folder names

Add test to prove it works
TAP5-1643: Allow slashes inside classpath asset aliases and paths
TAP5-1643: Allow slashes inside virtual folder names

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170395
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/AssetDispatcher.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/app1/Index.tml
* /tapestry/tapestry5/trunk/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/GroovyTapestryCoreTestCase.groovy
* /tapestry/tapestry5/trunk/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/LibraryTests.groovy
* /tapestry/tapestry5/trunk/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/appfolder/AppFolderTests.groovy
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/services/AppModule.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/locallib
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/locallib/alpha
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/locallib/alpha/pages
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/locallib/alpha/pages/AlphaRoot.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/integration/locallib
* /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/integration/locallib/alpha
* /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/integration/locallib/alpha/pages
* /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/integration/locallib/alpha/pages/AlphaRoot.tml
* /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/integration/locallib/alpha/pages/tapestry.png

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170394
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ClasspathAssetAliasManagerImpl.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/ClasspathAssetAliasManagerImplTest.java

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170393
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/InternalConstants.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/LibraryMapping.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/ComponentClassResolverImplTest.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/services/LibraryMappingTest.java
* /tapestry/tapestry5/trunk/tapestry-kaptcha/src/main/java/org/apache/tapestry5/kaptcha/services/KaptchaModule.java
* /tapestry/tapestry5/trunk/tapestry-upload/src/main/java/org/apache/tapestry5/upload/services/UploadModule.java


> Restore ability to contribute a library mapping that includes the "/" character (as was possible in 5.1)
> --------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1643
>                 URL: https://issues.apache.org/jira/browse/TAP5-1643
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3, 5.2
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>              Labels: backwards-compatibility
>             Fix For: 5.3
>
>
> This was allowed in 5.1 and earlier, as the value after the slash was intended to be a version number for the library.  With 5.2, there's a single version number ... but some HLS clients leverage the folder structure for some of their internal use cases and need to hack Tapestry to allow the slash in the folder name. It should be allowed (and handled efficiently).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (TAP5-1643) Restore ability to contribute a library mapping that includes the "/" character (as was possible in 5.1)

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship reassigned TAP5-1643:
------------------------------------------

    Assignee: Howard M. Lewis Ship

> Restore ability to contribute a library mapping that includes the "/" character (as was possible in 5.1)
> --------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1643
>                 URL: https://issues.apache.org/jira/browse/TAP5-1643
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3, 5.2
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>              Labels: backwards-compatibility
>
> This was allowed in 5.1 and earlier, as the value after the slash was intended to be a version number for the library.  With 5.2, there's a single version number ... but some HLS clients leverage the folder structure for some of their internal use cases and need to hack Tapestry to allow the slash in the folder name. It should be allowed (and handled efficiently).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira