You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/07/15 10:35:46 UTC
[GitHub] [incubator-doris] HappenLee opened a new pull request #6248: Support Vectorization Execution Engine For Doris
HappenLee opened a new pull request #6248:
URL: https://github.com/apache/incubator-doris/pull/6248
## Proposed changes
We already implement
* VSortNode
* VCrossJoinNode
* VAggregateNode
* VOlapScanNode
How to enable vectorization execution engine for doris：
* 1. set batch_size = 4096；
* 2. set enable_vectorized_engine = true;
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [x] Code refactor (Modify the code structure, format the code, etc...)
- [x] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have created an issue on (Fix #6238) and described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] If these changes need document changes, I have updated the document
- [x] Any dependent changes have been merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] hf200012 commented on pull request #6248: Support Vectorization Execution Engine For Doris
Posted by GitBox <gi...@apache.org>.
hf200012 commented on pull request #6248:
URL: https://github.com/apache/incubator-doris/pull/6248#issuecomment-880682386
We look forward to this improvement, which will bring quality improvement to Doris
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee commented on pull request #6248: Support Vectorization Execution Engine For Doris
Posted by GitBox <gi...@apache.org>.
HappenLee commented on pull request #6248:
URL: https://github.com/apache/incubator-doris/pull/6248#issuecomment-880668616
UT failed because of this issue:#6224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei commented on pull request #6248: Support Vectorization Execution Engine For Doris
Posted by GitBox <gi...@apache.org>.
yiguolei commented on pull request #6248:
URL: https://github.com/apache/incubator-doris/pull/6248#issuecomment-881106512
A very big improvement, looking forward to this feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee closed pull request #6248: Support Vectorization Execution Engine For Doris
Posted by GitBox <gi...@apache.org>.
HappenLee closed pull request #6248:
URL: https://github.com/apache/incubator-doris/pull/6248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] hf200012 commented on pull request #6248: Support Vectorization Execution Engine For Doris
Posted by GitBox <gi...@apache.org>.
hf200012 commented on pull request #6248:
URL: https://github.com/apache/incubator-doris/pull/6248#issuecomment-881143790
I very much look forward to this improvement, which will bring a great
performance improvement to doris,
yiguolei ***@***.***> 于2021年7月16日周五 上午9:13写道：
> A very big improvement, looking forward to this feature.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-doris/pull/6248#issuecomment-881106512>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAGIITJVLOS5ZDM3JF52NBDTX6BSTANCNFSM5ANIPEVQ>
> .
>
--
张家峰
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee commented on pull request #6248: Support Vectorization Execution Engine For Doris
Posted by GitBox <gi...@apache.org>.
HappenLee commented on pull request #6248:
URL: https://github.com/apache/incubator-doris/pull/6248#issuecomment-884623662
1. We will started a discussion within the community.
2. Here are some code copied from ClickHouse, before we refactor all the related and clickhouse code, I close this PR
3. We will pull some generic interface code to submit to the community, other code that involves vectorization will not
@imay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] francisoliverlee commented on pull request #6248: Support Vectorization Execution Engine For Doris
Posted by GitBox <gi...@apache.org>.
francisoliverlee commented on pull request #6248:
URL: https://github.com/apache/incubator-doris/pull/6248#issuecomment-884616885
very great improvement. watching it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zbtzbtzbt commented on pull request #6248: Support Vectorization Execution Engine For Doris
Posted by GitBox <gi...@apache.org>.
zbtzbtzbt commented on pull request #6248:
URL: https://github.com/apache/incubator-doris/pull/6248#issuecomment-884624873
look forward to this improvement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zhaojintaozhao commented on pull request #6248: Support Vectorization Execution Engine For Doris
Posted by GitBox <gi...@apache.org>.
zhaojintaozhao commented on pull request #6248:
URL: https://github.com/apache/incubator-doris/pull/6248#issuecomment-880655706
Oh, This is a long-awaited feature, Doris' performance will be on par with ClickHouse, excited.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee removed a comment on pull request #6248: Support Vectorization Execution Engine For Doris
Posted by GitBox <gi...@apache.org>.
HappenLee removed a comment on pull request #6248:
URL: https://github.com/apache/incubator-doris/pull/6248#issuecomment-880668616
UT failed because of this issue:#6224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee commented on pull request #6248: Support Vectorization Execution Engine For Doris
Posted by GitBox <gi...@apache.org>.
HappenLee commented on pull request #6248:
URL: https://github.com/apache/incubator-doris/pull/6248#issuecomment-881175876
NewDorisTest failed because of this issue#6224， fixed by:#6228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zhaojintaozhao edited a comment on pull request #6248: Support Vectorization Execution Engine For Doris
Posted by GitBox <gi...@apache.org>.
zhaojintaozhao edited a comment on pull request #6248:
URL: https://github.com/apache/incubator-doris/pull/6248#issuecomment-880655706
Oh, This is a long-awaited feature, a very big improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee edited a comment on pull request #6248: Support Vectorization Execution Engine For Doris
Posted by GitBox <gi...@apache.org>.
HappenLee edited a comment on pull request #6248:
URL: https://github.com/apache/incubator-doris/pull/6248#issuecomment-881175876
NewDorisTest failed because of this issue:#6224， fixed by:#6228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org