You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/02/07 07:21:14 UTC
[GitHub] normanmaurer commented on a change in pull request #809:
ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments
normanmaurer commented on a change in pull request #809: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments
URL: https://github.com/apache/zookeeper/pull/809#discussion_r254568223
##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
##########
@@ -82,7 +84,7 @@
ClientCnxnSocketNetty(ZKClientConfig clientConfig) throws IOException {
this.clientConfig = clientConfig;
- eventLoopGroup = NettyUtils.newNioOrEpollEventLoopGroup();
+ eventLoopGroup = NettyUtils.newNioOrEpollEventLoopGroup(1 /* nThreads */);
Review comment:
Also I wonder if you maybe want to allow configure this... Seems like there is a config object passed around anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services