You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "frankvicky (via GitHub)" <gi...@apache.org> on 2026/03/20 18:38:03 UTC

Re: [PR] KAFKA-20329: Test `headers` dsl.store.format further (1/N) [kafka]

frankvicky commented on code in PR #21806:
URL: https://github.com/apache/kafka/pull/21806#discussion_r2967375889


##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/JoinGracePeriodDurabilityIntegrationTest.java:
##########
@@ -126,6 +128,10 @@ public void shouldRecoverBufferAfterShutdown(final TestInfo testInfo) {
 
         streamsConfig.put(StreamsConfig.COMMIT_INTERVAL_MS_CONFIG, COMMIT_INTERVAL);
 
+        if (withHeaders) {

Review Comment:
   Should we add a `withHeader` parameter to `startStreams()` for reducing the repeat code ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org