You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Chris Eldredge (JIRA)" <ji...@apache.org> on 2009/08/04 19:50:15 UTC
[jira] Created: (SOLR-1332) Escape spaces in URLs in URLDataSource
Escape spaces in URLs in URLDataSource
--------------------------------------
Key: SOLR-1332
URL: https://issues.apache.org/jira/browse/SOLR-1332
Project: Solr
Issue Type: Improvement
Components: contrib - DataImportHandler
Affects Versions: 1.4
Environment: Any
Reporter: Chris Eldredge
At present the URLDataSource does not correctly escape spaces in URLs. This particularly affects usages where ${dataimporter.last_index_time} is present in the URL to support delta imports. That variable contains a space which should be escaped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1332) Escape spaces in URLs in
URLDataSource
Posted by "Chris Eldredge (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739486#action_12739486 ]
Chris Eldredge commented on SOLR-1332:
--------------------------------------
We decided to only escape spaces to avoid breaking other test cases we could think of where a well formed query string in an invariant variable would get incorrectly double-escaped. The uncodeUrl function looks like what we need so we'll try that.
> Escape spaces in URLs in URLDataSource
> --------------------------------------
>
> Key: SOLR-1332
> URL: https://issues.apache.org/jira/browse/SOLR-1332
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 1.4
> Environment: Any
> Reporter: Chris Eldredge
> Attachments: SOLR-1332.patch
>
>
> At present the URLDataSource does not correctly escape spaces in URLs. This particularly affects usages where ${dataimporter.last_index_time} is present in the URL to support delta imports. That variable contains a space which should be escaped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-1332) Escape spaces in URLs in URLDataSource
Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik Hatcher resolved SOLR-1332.
--------------------------------
Resolution: Invalid
solution: use url encoder
> Escape spaces in URLs in URLDataSource
> --------------------------------------
>
> Key: SOLR-1332
> URL: https://issues.apache.org/jira/browse/SOLR-1332
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 1.4
> Environment: Any
> Reporter: Chris Eldredge
> Attachments: SOLR-1332.patch
>
>
> At present the URLDataSource does not correctly escape spaces in URLs. This particularly affects usages where ${dataimporter.last_index_time} is present in the URL to support delta imports. That variable contains a space which should be escaped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1332) Escape spaces in URLs in
URLDataSource
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739346#action_12739346 ]
Noble Paul commented on SOLR-1332:
----------------------------------
it is possible to escape strings using the in-built functions
{code}
${dataimporter.functions.encodeUrl(dataimporter_last_index_time)}
{code}
> Escape spaces in URLs in URLDataSource
> --------------------------------------
>
> Key: SOLR-1332
> URL: https://issues.apache.org/jira/browse/SOLR-1332
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 1.4
> Environment: Any
> Reporter: Chris Eldredge
> Attachments: SOLR-1332.patch
>
>
> At present the URLDataSource does not correctly escape spaces in URLs. This particularly affects usages where ${dataimporter.last_index_time} is present in the URL to support delta imports. That variable contains a space which should be escaped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1332) Escape spaces in URLs in
URLDataSource
Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739311#action_12739311 ]
Erik Hatcher commented on SOLR-1332:
------------------------------------
Just escaping spaces isn't good enough, though certainly a workable fix in simple cases. Each substitution into a URL would need to be escaped in some fashion to do this properly, right? Sounds tricky!
> Escape spaces in URLs in URLDataSource
> --------------------------------------
>
> Key: SOLR-1332
> URL: https://issues.apache.org/jira/browse/SOLR-1332
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 1.4
> Environment: Any
> Reporter: Chris Eldredge
> Attachments: SOLR-1332.patch
>
>
> At present the URLDataSource does not correctly escape spaces in URLs. This particularly affects usages where ${dataimporter.last_index_time} is present in the URL to support delta imports. That variable contains a space which should be escaped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1332) Escape spaces in URLs in URLDataSource
Posted by "Chris Eldredge (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Eldredge updated SOLR-1332:
---------------------------------
Attachment: SOLR-1332.patch
Patch that escapes spaces.
> Escape spaces in URLs in URLDataSource
> --------------------------------------
>
> Key: SOLR-1332
> URL: https://issues.apache.org/jira/browse/SOLR-1332
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 1.4
> Environment: Any
> Reporter: Chris Eldredge
> Attachments: SOLR-1332.patch
>
>
> At present the URLDataSource does not correctly escape spaces in URLs. This particularly affects usages where ${dataimporter.last_index_time} is present in the URL to support delta imports. That variable contains a space which should be escaped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (SOLR-1332) Escape spaces in URLs in
URLDataSource
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739346#action_12739346 ]
Noble Paul edited comment on SOLR-1332 at 8/4/09 10:42 PM:
-----------------------------------------------------------
it is possible to escape strings using the in-built functions http://wiki.apache.org/solr/DataImportHandler#head-5675e913396a42eb7c6c5d3c894ada5dadbb62d7
{code}
${dataimporter.functions.encodeUrl(dataimporter_last_index_time)}
{code}
was (Author: noble.paul):
it is possible to escape strings using the in-built functions
{code}
${dataimporter.functions.encodeUrl(dataimporter_last_index_time)}
{code}
> Escape spaces in URLs in URLDataSource
> --------------------------------------
>
> Key: SOLR-1332
> URL: https://issues.apache.org/jira/browse/SOLR-1332
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 1.4
> Environment: Any
> Reporter: Chris Eldredge
> Attachments: SOLR-1332.patch
>
>
> At present the URLDataSource does not correctly escape spaces in URLs. This particularly affects usages where ${dataimporter.last_index_time} is present in the URL to support delta imports. That variable contains a space which should be escaped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.