[GitHub] [hudi] yihua commented on issue #6552: [SUPPORT] AWSDmsAvroPayload does not work correctly with any version above 0.10.0

[GitBox <gi...@apache.org>]

yihua commented on issue #6552:
URL: https://github.com/apache/hudi/issues/6552#issuecomment-1240175667

   @rahil-c and I discussed this today.  The proper fix is to call the corresponding API instead of repeating the invocation of `handleDeleteOperation`:
   ```
   FIXED ->
   @Override
     public Option<IndexedRecord> getInsertValue(Schema schema, Properties properties) throws IOException {
       return getInsertValue(schema);
     }
   
     @Override
     public Option<IndexedRecord> getInsertValue(Schema schema) throws IOException {
       IndexedRecord insertValue = super.getInsertValue(schema).get();
       return handleDeleteOperation(insertValue);
     }
   
   @Override
     public Option<IndexedRecord> combineAndGetUpdateValue(IndexedRecord currentValue, Schema schema, Properties properties)
         throws IOException {
       return combineAndGetUpdateValue(currentValue, schema);
     }
   
     @Override
     public Option<IndexedRecord> combineAndGetUpdateValue(IndexedRecord currentValue, Schema schema)
         throws IOException {
       IndexedRecord insertValue = super.getInsertValue(schema).get();
       return handleDeleteOperation(insertValue);
     }
   ```
   @rahil-c will put up a fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org