You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@baremaps.apache.org by "bchapuis (via GitHub)" <gi...@apache.org> on 2023/03/01 16:12:03 UTC

[GitHub] [incubator-baremaps-site] bchapuis opened a new pull request, #12: Use nextjs and nextra instead of Jekyll

bchapuis opened a new pull request, #12:
URL: https://github.com/apache/incubator-baremaps-site/pull/12

   Jekyll is relatively limited when it comes to integrate advanced demonstrations in web pages. The goal of this PR is to explore the use of nextjs and nextra to create Baremaps' documentation web site. These technologies allow us to embed react components in the markdown and hence to nest advanced demonstrations in the documentation. The README contains instructions to run the web site locally. 
   
   Any thought on this change? The publication pipeline has not yet been updated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-baremaps-site] bchapuis commented on pull request #12: Use nextjs and nextra instead of Jekyll

Posted by "bchapuis (via GitHub)" <gi...@apache.org>.
bchapuis commented on PR #12:
URL: https://github.com/apache/incubator-baremaps-site/pull/12#issuecomment-1450856117

   The [nextra/vercel](https://nextra.site) did a really good job and the template has sound defaults for a documentation web site. I hadn't tested the dark mode and I see that my subtitle needs some tuning.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-baremaps-site] bchapuis commented on pull request #12: Use nextjs and nextra instead of Jekyll

Posted by "bchapuis (via GitHub)" <gi...@apache.org>.
bchapuis commented on PR #12:
URL: https://github.com/apache/incubator-baremaps-site/pull/12#issuecomment-1450514559

   Ahah, it works on my machine...
   
   I have no idea where this replaceAll call come from. Which version of nodejs are you using? Mine is the following:
   
   ```bash
   node --version
   v18.12.1
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-baremaps-site] bchapuis merged pull request #12: Use nextjs and nextra instead of Jekyll

Posted by "bchapuis (via GitHub)" <gi...@apache.org>.
bchapuis merged PR #12:
URL: https://github.com/apache/incubator-baremaps-site/pull/12


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-baremaps-site] bchapuis commented on pull request #12: Use nextjs and nextra instead of Jekyll

Posted by "bchapuis (via GitHub)" <gi...@apache.org>.
bchapuis commented on PR #12:
URL: https://github.com/apache/incubator-baremaps-site/pull/12#issuecomment-1452059386

   @joshfischer1108 I merged this branch into main to test the deployment workflow and everything went smoothly. I guess we can keep this new version and improve it step by step. Similarly, do not hesitate to merge your changes if they improve the current status.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-baremaps-site] joshfischer1108 commented on pull request #12: Use nextjs and nextra instead of Jekyll

Posted by "joshfischer1108 (via GitHub)" <gi...@apache.org>.
joshfischer1108 commented on PR #12:
URL: https://github.com/apache/incubator-baremaps-site/pull/12#issuecomment-1450475228

   I think I broke it 😆 
   ```
   $ npm install && npm run dev
   ready - started server on 0.0.0.0:3000, url: http://localhost:3000
   info  - automatically enabled Fast Refresh for 3 custom loaders
   [nextra] Error compiling /Users/joshfischer/Source/apache/incubator-baremaps-site/pages/_app.mdx.
   [nextra] Error compiling /Users/joshfischer/Source/apache/incubator-baremaps-site/pages/_app.mdx.
   error - ./pages/_app.mdx
   TypeError: String(...).replaceAll is not a function
   wait  - compiling...
   [nextra] Error compiling /Users/joshfischer/Source/apache/incubator-baremaps-site/pages/_app.mdx.
   error - ./pages/_app.mdx
   TypeError: String(...).replaceAll is not a function
   wait  - compiling...
   [nextra] Error compiling /Users/joshfischer/Source/apache/incubator-baremaps-site/pages/_app.mdx.
   error - ./pages/_app.mdx
   TypeError: String(...).replaceAll is not a function
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-baremaps-site] joshfischer1108 commented on pull request #12: Use nextjs and nextra instead of Jekyll

Posted by "joshfischer1108 (via GitHub)" <gi...@apache.org>.
joshfischer1108 commented on PR #12:
URL: https://github.com/apache/incubator-baremaps-site/pull/12#issuecomment-1450586521

   That was it. Leave it to me to have my default node version at 14 🤦 .  I was able to run the new site locally and I love it. Looks super slick. + 1 to you, sir. 
   
   
   <img width="1649" alt="Screen Shot 2023-03-01 at 11 47 35 AM" src="https://user-images.githubusercontent.com/5785700/222220684-3dc3ec87-084a-46f4-a972-3f207499f00b.png">
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org