You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ch...@apache.org on 2021/11/09 12:31:21 UTC

[incubator-kyuubi] branch master updated: [KYUUBI #1348] [DEPS] Add netty and mysql jdbc driver to kyuubi-server module

This is an automated email from the ASF dual-hosted git repository.

chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git


The following commit(s) were added to refs/heads/master by this push:
     new c122a23  [KYUUBI #1348] [DEPS] Add netty and mysql jdbc driver to kyuubi-server module
c122a23 is described below

commit c122a23a0dc0da352461f3a59d4644af56075d35
Author: Cheng Pan <ch...@apache.org>
AuthorDate: Tue Nov 9 20:31:09 2021 +0800

    [KYUUBI #1348] [DEPS] Add netty and mysql jdbc driver to kyuubi-server module
    
    ### _Why are the changes needed?_
    
    This PR is one part of #1334.
    
    Add netty to `kyuubi-server` module compile scope, and mysql jdbc driver to test scope, it's required for implementing MySQL frontend protocol
    
    ### _How was this patch tested?_
    - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
    
    - [ ] Add screenshots for manual tests if appropriate
    
    - [x] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
    
    Closes #1348 from pan3793/mysql-fe-deps.
    
    Closes #1348
    
    288ad9c0 [Cheng Pan] [DEPS] Add netty to kyuubi-server module
    
    Authored-by: Cheng Pan <ch...@apache.org>
    Signed-off-by: Cheng Pan <ch...@apache.org>
---
 LICENSE-binary        |  1 +
 dev/dependencyList    |  1 +
 kyuubi-server/pom.xml | 11 +++++++++++
 pom.xml               | 14 ++++++++++++++
 4 files changed, 27 insertions(+)

diff --git a/LICENSE-binary b/LICENSE-binary
index 2c7b224..e0a3ef1 100644
--- a/LICENSE-binary
+++ b/LICENSE-binary
@@ -246,6 +246,7 @@ io.dropwizard.metrics:metrics-core
 io.dropwizard.metrics:metrics-jmx
 io.dropwizard.metrics:metrics-json
 io.dropwizard.metrics:metrics-jvm
+io.netty:netty-all
 io.prometheus:simpleclient
 io.prometheus:simpleclient_common
 io.prometheus:simpleclient_dropwizard
diff --git a/dev/dependencyList b/dev/dependencyList
index a271c28..58d9a79 100644
--- a/dev/dependencyList
+++ b/dev/dependencyList
@@ -72,6 +72,7 @@ metrics-core/4.1.1//metrics-core-4.1.1.jar
 metrics-jmx/4.1.1//metrics-jmx-4.1.1.jar
 metrics-json/4.1.1//metrics-json-4.1.1.jar
 metrics-jvm/4.1.1//metrics-jvm-4.1.1.jar
+netty-all/4.1.68.Final//netty-all-4.1.68.Final.jar
 osgi-resource-locator/1.0.3//osgi-resource-locator-1.0.3.jar
 paranamer/2.8//paranamer-2.8.jar
 scala-library/2.12.15//scala-library-2.12.15.jar
diff --git a/kyuubi-server/pom.xml b/kyuubi-server/pom.xml
index e51d073..821bde6 100644
--- a/kyuubi-server/pom.xml
+++ b/kyuubi-server/pom.xml
@@ -203,6 +203,11 @@
         </dependency>
 
         <dependency>
+            <groupId>io.netty</groupId>
+            <artifactId>netty-all</artifactId>
+        </dependency>
+
+        <dependency>
             <groupId>org.glassfish.jersey.core</groupId>
             <artifactId>jersey-server</artifactId>
         </dependency>
@@ -427,6 +432,12 @@
             <artifactId>bcpkix-jdk15on</artifactId>
             <scope>test</scope>
         </dependency>
+
+        <dependency>
+            <groupId>mysql</groupId>
+            <artifactId>mysql-connector-java</artifactId>
+            <scope>test</scope>
+        </dependency>
     </dependencies>
 
     <build>
diff --git a/pom.xml b/pom.xml
index de0a966..4c92307 100644
--- a/pom.xml
+++ b/pom.xml
@@ -117,6 +117,8 @@
         <jetty.version>9.4.41.v20210516</jetty.version>
         <kubernetes-client.version>5.5.0</kubernetes-client.version>
         <ldapsdk.version>5.1.4</ldapsdk.version>
+        <mysql.jdbc.version>8.0.27</mysql.jdbc.version>
+        <netty.version>4.1.68.Final</netty.version>
         <parquet.version>1.10.1</parquet.version>
         <prometheus.version>0.10.0</prometheus.version>
         <scalacheck.version>3.2.9.0</scalacheck.version>
@@ -589,6 +591,12 @@
             </dependency>
 
             <dependency>
+                <groupId>io.netty</groupId>
+                <artifactId>netty-all</artifactId>
+                <version>${netty.version}</version>
+            </dependency>
+
+            <dependency>
                 <groupId>jakarta.servlet</groupId>
                 <artifactId>jakarta.servlet-api</artifactId>
                 <version>${jakarta.servlet-api.version}</version>
@@ -883,6 +891,12 @@
                     </exclusion>
                 </exclusions>
             </dependency>
+
+            <dependency>
+                <groupId>mysql</groupId>
+                <artifactId>mysql-connector-java</artifactId>
+                <version>${mysql.jdbc.version}</version>
+            </dependency>
         </dependencies>
     </dependencyManagement>