[GitHub] [james-project] Arsnael commented on a change in pull request #273: [ADR] Enhance existing ADRs

[GitBox <gi...@apache.org>]

Arsnael commented on a change in pull request #273:
URL: https://github.com/apache/james-project/pull/273#discussion_r537192104



##########
File path: src/adr/0026-removing-configured-additional-mailboxListeners.md
##########
@@ -6,6 +6,8 @@ Date: 2020-04-03
 
 Accepted (lazy consensus)
 
+Not implemented yet.

Review comment:
       as it's superceded by ADR 35 (and not 34, please fix the line below), is this comment really necessary?

##########
File path: src/adr/0039-distributed-blob-garbage-collector.md
##########
@@ -58,6 +60,10 @@ store the blob for. This can make some components harder to implement as we will
 Since we will not build a distributed task scheduler. To increment the `reference generation` and launch periodically a
 `garbage collection iteration`, the scheduling will be done by an external scheduler (cron job, kubernetes cronjob ...)
  which will call a webadmin endpoint to launch this task periodically.
+ 
+## References
+
+

Review comment:
       empty references?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org