[GitHub] [airflow] Taragolis commented on a diff in pull request #33557: Remove deprecated parts from Slack provider

["Taragolis (via GitHub)" <gi...@apache.org>]

Taragolis commented on code in PR #33557:
URL: https://github.com/apache/airflow/pull/33557#discussion_r1334148490


##########
airflow/providers/slack/hooks/slack.py:
##########
@@ -113,42 +111,31 @@ class SlackHook(BaseHook):
 
     def __init__(
         self,
-        token: str | None = None,
-        slack_conn_id: str | None = None,
+        *,
+        slack_conn_id: str,

Review Comment:
   I guess it is never use any default connection ID
   https://airflow.apache.org/docs/apache-airflow-providers-slack/stable/connections/slack.html#default-connection-ids
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org