You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Filip Maj (Created) (JIRA)" <ji...@apache.org> on 2012/04/08 20:00:17 UTC
[jira] [Created] (CB-462) Refactor accelerometer JS <-> native
interactions
Refactor accelerometer JS <-> native interactions
-------------------------------------------------
Key: CB-462
URL: https://issues.apache.org/jira/browse/CB-462
Project: Apache Callback
Issue Type: Improvement
Components: CordovaJS
Affects Versions: 1.6.0
Reporter: Filip Maj
Assignee: Filip Maj
Fix For: 1.7.0
Similar to CB-359.
We use a completely different set of native actions to control Geolocation, Accelerometer and Compass sensor APIs. These all have identical APIs and really should be implemented in the same way.
For accelerometer, there is no reason to need a {{setTimeout}} and {{getTimeout}} native action.
Should use the pattern employed in CB-359 to implement the accel sensor API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CB-462) Refactor accelerometer JS <-> native
interactions
Posted by "Filip Maj (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filip Maj resolved CB-462.
--------------------------
Resolution: Fixed
As of commit [58a213|http://git-wip-us.apache.org/repos/asf?p=incubator-cordova-js.git;a=commit;h=58a213de4b6597942b17734208617dc680fa9e22], the JS is updated to resolve this issue.
Android, iOS, BlackBerry and WP7 have been updated to use the new internal API.
> Refactor accelerometer JS <-> native interactions
> -------------------------------------------------
>
> Key: CB-462
> URL: https://issues.apache.org/jira/browse/CB-462
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.6.0
> Reporter: Filip Maj
> Assignee: Filip Maj
> Fix For: 1.8.0
>
>
> Similar to CB-359.
> We use a completely different set of native actions to control Geolocation, Accelerometer and Compass sensor APIs. These all have identical APIs and really should be implemented in the same way.
> For accelerometer, there is no reason to need a {{setTimeout}} and {{getTimeout}} native action.
> Should use the pattern employed in CB-359 to implement the accel sensor API.
> CordovaJS should also be wrapping the error and success callbacks in {{accelerometer}} calls and making sure the right {{Acceleration}} and {{Error}} objects are passed to the user callbacks. Also need to add more unit tests to CordovaJS to be testing for all of this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-462) Refactor accelerometer JS <-> native
interactions
Posted by "Filip Maj (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274745#comment-13274745 ]
Filip Maj commented on CB-462:
------------------------------
The JS for this work is all done here: http://git-wip-us.apache.org/repos/asf?p=incubator-cordova-js.git;a=shortlog;h=refs/heads/462
> Refactor accelerometer JS <-> native interactions
> -------------------------------------------------
>
> Key: CB-462
> URL: https://issues.apache.org/jira/browse/CB-462
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.6.0
> Reporter: Filip Maj
> Assignee: Filip Maj
> Fix For: 1.8.0
>
>
> Similar to CB-359.
> We use a completely different set of native actions to control Geolocation, Accelerometer and Compass sensor APIs. These all have identical APIs and really should be implemented in the same way.
> For accelerometer, there is no reason to need a {{setTimeout}} and {{getTimeout}} native action.
> Should use the pattern employed in CB-359 to implement the accel sensor API.
> CordovaJS should also be wrapping the error and success callbacks in {{accelerometer}} calls and making sure the right {{Acceleration}} and {{Error}} objects are passed to the user callbacks. Also need to add more unit tests to CordovaJS to be testing for all of this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-462) Refactor accelerometer JS <-> native
interactions
Posted by "Filip Maj (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292643#comment-13292643 ]
Filip Maj commented on CB-462:
------------------------------
Sorry dude I must have blanked. I'll create one for webOS too.
> Refactor accelerometer JS <-> native interactions
> -------------------------------------------------
>
> Key: CB-462
> URL: https://issues.apache.org/jira/browse/CB-462
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.6.0
> Reporter: Filip Maj
> Assignee: Filip Maj
> Fix For: 1.8.0
>
>
> Similar to CB-359.
> We use a completely different set of native actions to control Geolocation, Accelerometer and Compass sensor APIs. These all have identical APIs and really should be implemented in the same way.
> For accelerometer, there is no reason to need a {{setTimeout}} and {{getTimeout}} native action.
> Should use the pattern employed in CB-359 to implement the accel sensor API.
> CordovaJS should also be wrapping the error and success callbacks in {{accelerometer}} calls and making sure the right {{Acceleration}} and {{Error}} objects are passed to the user callbacks. Also need to add more unit tests to CordovaJS to be testing for all of this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-462) Refactor accelerometer JS <-> native
interactions
Posted by "Anis Kadri (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290301#comment-13290301 ]
Anis Kadri commented on CB-462:
-------------------------------
Bada Acceleration is now broken because of this change. I had to use an older cordova.js to release 1.8. Why didn't you add a ticket for it :-( ? I guess I will create one and set it for 1.9.
> Refactor accelerometer JS <-> native interactions
> -------------------------------------------------
>
> Key: CB-462
> URL: https://issues.apache.org/jira/browse/CB-462
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.6.0
> Reporter: Filip Maj
> Assignee: Filip Maj
> Fix For: 1.8.0
>
>
> Similar to CB-359.
> We use a completely different set of native actions to control Geolocation, Accelerometer and Compass sensor APIs. These all have identical APIs and really should be implemented in the same way.
> For accelerometer, there is no reason to need a {{setTimeout}} and {{getTimeout}} native action.
> Should use the pattern employed in CB-359 to implement the accel sensor API.
> CordovaJS should also be wrapping the error and success callbacks in {{accelerometer}} calls and making sure the right {{Acceleration}} and {{Error}} objects are passed to the user callbacks. Also need to add more unit tests to CordovaJS to be testing for all of this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-462) Refactor accelerometer JS <-> native
interactions
Posted by "Filip Maj (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filip Maj updated CB-462:
-------------------------
Fix Version/s: (was: 1.8.0)
1.9.0
The accel refactor will get in across all cordova-js supported platforms in 1.9 (Bada was last one, due to my fault of not filing a Bada issue!)
> Refactor accelerometer JS <-> native interactions
> -------------------------------------------------
>
> Key: CB-462
> URL: https://issues.apache.org/jira/browse/CB-462
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.6.0
> Reporter: Filip Maj
> Assignee: Filip Maj
> Fix For: 1.9.0
>
>
> Similar to CB-359.
> We use a completely different set of native actions to control Geolocation, Accelerometer and Compass sensor APIs. These all have identical APIs and really should be implemented in the same way.
> For accelerometer, there is no reason to need a {{setTimeout}} and {{getTimeout}} native action.
> Should use the pattern employed in CB-359 to implement the accel sensor API.
> CordovaJS should also be wrapping the error and success callbacks in {{accelerometer}} calls and making sure the right {{Acceleration}} and {{Error}} objects are passed to the user callbacks. Also need to add more unit tests to CordovaJS to be testing for all of this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-462) Refactor accelerometer JS <-> native
interactions
Posted by "Filip Maj (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filip Maj updated CB-462:
-------------------------
Description:
Similar to CB-359.
We use a completely different set of native actions to control Geolocation, Accelerometer and Compass sensor APIs. These all have identical APIs and really should be implemented in the same way.
For accelerometer, there is no reason to need a {{setTimeout}} and {{getTimeout}} native action.
Should use the pattern employed in CB-359 to implement the accel sensor API.
CordovaJS should also be wrapping the error and success callbacks in {{accelerometer}} calls and making sure the right {{Acceleration}} and {{Error}} objects are passed to the user callbacks. Also need to add more unit tests to CordovaJS to be testing for all of this.
was:
Similar to CB-359.
We use a completely different set of native actions to control Geolocation, Accelerometer and Compass sensor APIs. These all have identical APIs and really should be implemented in the same way.
For accelerometer, there is no reason to need a {{setTimeout}} and {{getTimeout}} native action.
Should use the pattern employed in CB-359 to implement the accel sensor API.
> Refactor accelerometer JS <-> native interactions
> -------------------------------------------------
>
> Key: CB-462
> URL: https://issues.apache.org/jira/browse/CB-462
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.6.0
> Reporter: Filip Maj
> Assignee: Filip Maj
> Fix For: 1.7.0
>
>
> Similar to CB-359.
> We use a completely different set of native actions to control Geolocation, Accelerometer and Compass sensor APIs. These all have identical APIs and really should be implemented in the same way.
> For accelerometer, there is no reason to need a {{setTimeout}} and {{getTimeout}} native action.
> Should use the pattern employed in CB-359 to implement the accel sensor API.
> CordovaJS should also be wrapping the error and success callbacks in {{accelerometer}} calls and making sure the right {{Acceleration}} and {{Error}} objects are passed to the user callbacks. Also need to add more unit tests to CordovaJS to be testing for all of this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-462) Refactor accelerometer JS <-> native
interactions
Posted by "Filip Maj (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filip Maj updated CB-462:
-------------------------
Fix Version/s: (was: 1.7.0)
1.8.0
Moving to 1.8, what with 1.7 being a bug-fix-plus-docs release.
> Refactor accelerometer JS <-> native interactions
> -------------------------------------------------
>
> Key: CB-462
> URL: https://issues.apache.org/jira/browse/CB-462
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.6.0
> Reporter: Filip Maj
> Assignee: Filip Maj
> Fix For: 1.8.0
>
>
> Similar to CB-359.
> We use a completely different set of native actions to control Geolocation, Accelerometer and Compass sensor APIs. These all have identical APIs and really should be implemented in the same way.
> For accelerometer, there is no reason to need a {{setTimeout}} and {{getTimeout}} native action.
> Should use the pattern employed in CB-359 to implement the accel sensor API.
> CordovaJS should also be wrapping the error and success callbacks in {{accelerometer}} calls and making sure the right {{Acceleration}} and {{Error}} objects are passed to the user callbacks. Also need to add more unit tests to CordovaJS to be testing for all of this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira