You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/06/29 13:59:35 UTC
[GitHub] [incubator-shenyu] HaiqiQin opened a new pull request, #3634: [type:refactor] optimize logging-elasticsearch&rocketmq plugin
HaiqiQin opened a new pull request, #3634:
URL: https://github.com/apache/incubator-shenyu/pull/3634
<!-- Describe your PR here; eg. Fixes #issueNo -->
optimize logging-elasticsearch&rocketmq plugin
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 merged pull request #3634: [type:refactor] optimize logging-elasticsearch&rocketmq plugin
Posted by GitBox <gi...@apache.org>.
yu199195 merged PR #3634:
URL: https://github.com/apache/incubator-shenyu/pull/3634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter commented on pull request #3634: [type:refactor] optimize logging-elasticsearch&rocketmq plugin
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3634:
URL: https://github.com/apache/incubator-shenyu/pull/3634#issuecomment-1170060464
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3634?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3634](https://codecov.io/gh/apache/incubator-shenyu/pull/3634?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (90b0d11) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/b6e17d82bcdd6a97768e233c5b5eb5f3a23803aa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b6e17d8) will **decrease** coverage by `0.67%`.
> The diff coverage is `45.45%`.
```diff
@@ Coverage Diff @@
## master #3634 +/- ##
============================================
- Coverage 62.75% 62.07% -0.68%
+ Complexity 5866 5803 -63
============================================
Files 888 888
Lines 24717 24730 +13
Branches 2262 2261 -1
============================================
- Hits 15511 15351 -160
- Misses 7753 7917 +164
- Partials 1453 1462 +9
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/3634?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ging/elasticsearch/LoggingElasticSearchPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3634/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWVsYXN0aWNzZWFyY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vbG9nZ2luZy9lbGFzdGljc2VhcmNoL0xvZ2dpbmdFbGFzdGljU2VhcmNoUGx1Z2luLmphdmE=) | `22.72% <ø> (-72.73%)` | :arrow_down: |
| [...ch/body/LoggingElasticSearchServerHttpRequest.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3634/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWVsYXN0aWNzZWFyY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vbG9nZ2luZy9lbGFzdGljc2VhcmNoL2JvZHkvTG9nZ2luZ0VsYXN0aWNTZWFyY2hTZXJ2ZXJIdHRwUmVxdWVzdC5qYXZh) | `0.00% <ø> (-20.00%)` | :arrow_down: |
| [...earch/body/LoggingElasticSearchServerResponse.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3634/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWVsYXN0aWNzZWFyY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vbG9nZ2luZy9lbGFzdGljc2VhcmNoL2JvZHkvTG9nZ2luZ0VsYXN0aWNTZWFyY2hTZXJ2ZXJSZXNwb25zZS5qYXZh) | `53.19% <ø> (ø)` | |
| [...icsearch/client/ElasticSearchLogCollectClient.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3634/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWVsYXN0aWNzZWFyY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vbG9nZ2luZy9lbGFzdGljc2VhcmNoL2NsaWVudC9FbGFzdGljU2VhcmNoTG9nQ29sbGVjdENsaWVudC5qYXZh) | `46.00% <0.00%> (ø)` | |
| [.../elasticsearch/collector/AbstractLogCollector.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3634/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWVsYXN0aWNzZWFyY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vbG9nZ2luZy9lbGFzdGljc2VhcmNoL2NvbGxlY3Rvci9BYnN0cmFjdExvZ0NvbGxlY3Rvci5qYXZh) | `79.54% <ø> (ø)` | |
| [...g/elasticsearch/collector/DefaultLogCollector.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3634/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWVsYXN0aWNzZWFyY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vbG9nZ2luZy9lbGFzdGljc2VhcmNoL2NvbGxlY3Rvci9EZWZhdWx0TG9nQ29sbGVjdG9yLmphdmE=) | `100.00% <ø> (ø)` | |
| [...logging/elasticsearch/config/LogCollectConfig.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3634/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWVsYXN0aWNzZWFyY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vbG9nZ2luZy9lbGFzdGljc2VhcmNoL2NvbmZpZy9Mb2dDb2xsZWN0Q29uZmlnLmphdmE=) | `86.48% <ø> (ø)` | |
| [...handler/LoggingElasticSearchPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3634/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWVsYXN0aWNzZWFyY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vbG9nZ2luZy9lbGFzdGljc2VhcmNoL2hhbmRsZXIvTG9nZ2luZ0VsYXN0aWNTZWFyY2hQbHVnaW5EYXRhSGFuZGxlci5qYXZh) | `70.21% <ø> (ø)` | |
| [...plugin/logging/rocketmq/LoggingRocketMQPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3634/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLXJvY2tldG1xL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcvcm9ja2V0bXEvTG9nZ2luZ1JvY2tldE1RUGx1Z2luLmphdmE=) | `22.72% <ø> (-72.73%)` | :arrow_down: |
| [...gging/rocketmq/body/LoggingServerHttpResponse.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3634/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLXJvY2tldG1xL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcvcm9ja2V0bXEvYm9keS9Mb2dnaW5nU2VydmVySHR0cFJlc3BvbnNlLmphdmE=) | `53.19% <ø> (ø)` | |
| ... and [58 more](https://codecov.io/gh/apache/incubator-shenyu/pull/3634/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3634?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3634?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b6e17d8...90b0d11](https://codecov.io/gh/apache/incubator-shenyu/pull/3634?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org