You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/21 03:26:35 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1436: Minor fix forget in https://github.com/apache/incubator-nuttx/pull/1426
xiaoxiang781216 opened a new pull request #1436:
URL: https://github.com/apache/incubator-nuttx/pull/1436
## Summary
Follow up modification.
## Impact
Minor
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1436: Minor fix forget in https://github.com/apache/incubator-nuttx/pull/1426
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #1436:
URL: https://github.com/apache/incubator-nuttx/pull/1436#discussion_r457822668
##########
File path: arch/arm/src/arm/Toolchain.defs
##########
@@ -92,7 +92,7 @@ endif
CC = $(CROSSDEV)gcc
CXX = $(CROSSDEV)g++
-CPP = $(CROSSDEV)gcc -E
+CPP = $(CROSSDEV)gcc -E -P -x c
Review comment:
should this be `-x c++`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1436: Minor fix in CPP and ARCHCFLAGS arguments from PR #1426
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1436:
URL: https://github.com/apache/incubator-nuttx/pull/1436#discussion_r458533632
##########
File path: arch/arm/src/arm/Toolchain.defs
##########
@@ -92,7 +92,7 @@ endif
CC = $(CROSSDEV)gcc
CXX = $(CROSSDEV)g++
-CPP = $(CROSSDEV)gcc -E
+CPP = $(CROSSDEV)gcc -E -P -x c
Review comment:
Since C preprocessor is same as C++ preprocessor, so I think both will be fine. But -x option is important if we want preprocess some non C/C++ file(e.g. link script or bash script). Without this option, gcc will complain the unknown format.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1436: Minor fix in CPP and ARCHCFLAGS arguments from PR #1426
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #1436:
URL: https://github.com/apache/incubator-nuttx/pull/1436#discussion_r458537979
##########
File path: arch/arm/src/arm/Toolchain.defs
##########
@@ -92,7 +92,7 @@ endif
CC = $(CROSSDEV)gcc
CXX = $(CROSSDEV)g++
-CPP = $(CROSSDEV)gcc -E
+CPP = $(CROSSDEV)gcc -E -P -x c
Review comment:
sounds good since this is what it was before as well. There were some differences with RISC-V ABI in GCC, but it looks like those were identified as a bug and resolved. I'll merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1436: Minor fix in CPP and ARCHCFLAGS arguments from PR #1426
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #1436:
URL: https://github.com/apache/incubator-nuttx/pull/1436#discussion_r458532576
##########
File path: arch/arm/src/arm/Toolchain.defs
##########
@@ -92,7 +92,7 @@ endif
CC = $(CROSSDEV)gcc
CXX = $(CROSSDEV)g++
-CPP = $(CROSSDEV)gcc -E
+CPP = $(CROSSDEV)gcc -E -P -x c
Review comment:
@xiaoxiang781216 Did you have any thoughts on this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton merged pull request #1436: Minor fix in CPP and ARCHCFLAGS arguments from PR #1426
Posted by GitBox <gi...@apache.org>.
btashton merged pull request #1436:
URL: https://github.com/apache/incubator-nuttx/pull/1436
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1436: Minor fix in CPP and ARCHCFLAGS arguments from PR #1426
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1436:
URL: https://github.com/apache/incubator-nuttx/pull/1436#discussion_r458533632
##########
File path: arch/arm/src/arm/Toolchain.defs
##########
@@ -92,7 +92,7 @@ endif
CC = $(CROSSDEV)gcc
CXX = $(CROSSDEV)g++
-CPP = $(CROSSDEV)gcc -E
+CPP = $(CROSSDEV)gcc -E -P -x c
Review comment:
Since C preprocessor is same as C++ preprocessor, so I think both will be fine. But -x option is important if we want preprocess some non C/C++ file(e.g. link script or bash script).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org