svn commit: r1832021 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

[ma...@apache.org]

Author: markt
Date: Tue May 22 12:59:53 2018
New Revision: 1832021

URL: http://svn.apache.org/viewvc?rev=1832021&view=rev
Log:
SpotBugs: o.a.catalina false positives in test cases

Modified:
    tomcat/trunk/res/findbugs/filter-false-positives.xml

Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1832021&r1=1832020&r2=1832021&view=diff
==============================================================================
--- tomcat/trunk/res/findbugs/filter-false-positives.xml (original)
+++ tomcat/trunk/res/findbugs/filter-false-positives.xml Tue May 22 12:59:53 2018
@@ -1475,11 +1475,6 @@
     <Bug pattern="DLS_DEAD_LOCAL_STORE"/>
   </Match>
   <Match>
-    <Class name="org.apache.catalina.core.TestApplicationSessionCookieConfig$CustomContext" />
-    <Method name="getState"/>
-    <Bug code="UG" />
-  </Match>
-  <Match>
     <!-- Deliberate hack for the purposes of the test -->
     <Class name="org.apache.catalina.connector.TestCoyoteAdapter$AsyncServlet"/>
     <Field name="t"/>
@@ -1492,6 +1487,76 @@
     <Bug pattern="RV_RETURN_VALUE_IGNORED"/>
   </Match>
   <Match>
+    <Class name="org.apache.catalina.core.TestApplicationSessionCookieConfig$CustomContext" />
+    <Method name="getState"/>
+    <Bug code="UG" />
+  </Match>
+  <Match>
+    <!-- Dead store is deliberate -->
+    <Or>
+      <Class name="org.apache.catalina.core.TestAsyncContextImpl$AsyncDispatchUrlWithSpacesServlet"/>
+      <Class name="org.apache.catalina.core.TestAsyncContextImpl$ForwardDispatchUrlWithSpacesServlet"/>
+    </Or>
+    <Method name="doGet"/>
+    <Bug pattern="DLS_DEAD_LOCAL_STORE"/>
+  </Match>
+  <Match>
+    <!-- Deliberate hack for the purposes of the test -->
+    <Or>
+      <Class name="org.apache.catalina.core.TestAsyncContextImpl$Bug49528Servlet"/>
+      <Class name="org.apache.catalina.core.TestAsyncContextImpl$Bug49567Servlet"/>
+    </Or>
+    <Field name="result"/>
+    <Bug pattern="MSF_MUTABLE_SERVLET_FIELD"/>
+  </Match>
+  <Match>
+    <!-- Deliberate hack for the purposes of the test -->
+    <Class name="org.apache.catalina.core.TestAsyncContextImpl$Bug53843ServletA"/>
+    <Field name="isAsyncWhenExpected"/>
+    <Bug pattern="MSF_MUTABLE_SERVLET_FIELD"/>
+  </Match>
+  <Match>
+    <!-- Deliberate hack for the purposes of the test -->
+    <Class name="org.apache.catalina.core.TestAsyncContextImpl$AsyncISEServlet"/>
+    <Field name="asyncContext"/>
+    <Bug pattern="MSF_MUTABLE_SERVLET_FIELD"/>
+  </Match>
+  <Match>
+    <!-- Hard-coded absolute path is intentional -->
+    <Class name="org.apache.catalina.core.TestStandardContext"/>
+    <Method name="testBug57556b"/>
+    <Bug pattern="DMI_HARDCODED_ABSOLUTE_FILENAME"/>
+  </Match>
+  <Match>
+    <!-- Deliberate hack for the purposes of the test -->
+    <Class name="org.apache.catalina.core.TestStandardContext$Bug51376Servlet"/>
+    <Field name="destroyOk"/>
+    <Bug pattern="MSF_MUTABLE_SERVLET_FIELD"/>
+  </Match>
+  <Match>
+    <!-- Deliberate hack for the purposes of the test -->
+    <Class name="org.apache.catalina.filters.TestRemoteIpFilter$MockHttpServlet"/>
+    <Field name="request"/>
+    <Bug pattern="MSF_MUTABLE_SERVLET_FIELD"/>
+  </Match>
+  <Match>
+    <!-- Deliberate hack for the purposes of the test -->
+    <Class name="org.apache.catalina.startup.TesterServletWithAnnotations"/>
+    <Or>
+      <Field name="envEntry2"/>
+      <Field name="envEntry3"/>
+      <Field name="envEntry4"/>
+      <Field name="envEntry6"/>
+    </Or>
+    <Bug pattern="MSF_MUTABLE_SERVLET_FIELD"/>
+  </Match>
+  <Match>
+    <!-- Deliberate hack for the purposes of the test -->
+    <Class name="org.apache.catalina.startup.TesterServletWithLifeCycleMethods"/>
+    <Field name="result"/>
+    <Bug pattern="MSF_MUTABLE_SERVLET_FIELD"/>
+  </Match>
+  <Match>
     <!-- Return value of latch is intentionally ignored -->
     <Class name="org.apache.catalina.nonblocking.TestNonBlockingAPI"/>
     <Method name="testDelayedNBWrite"/>
@@ -1516,6 +1581,12 @@
     <Bug code="Se"/>
   </Match>
   <Match>
+    <!-- Deliberate hack for the purposes of the test -->
+    <Class name="org.apache.catalina.startup.TestTomcat$CustomContextConfig"/>
+    <Field name="used"/>
+    <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
+  </Match>
+  <Match>
     <Class name="org.apache.catalina.tribes.demos.EchoRpcTest" />
     <Method name="run"/>
     <Bug code="REC" />
@@ -1605,6 +1676,12 @@
     <Bug code="DE" />
   </Match>
   <Match>
+    <!-- Deliberate hack for the purposes of the test -->
+    <Class name="org.apache.catalina.valves.TestStuckThreadDetectionValve$StuckingServlet"/>
+    <Field name="wasInterrupted"/>
+    <Bug pattern="MSF_MUTABLE_SERVLET_FIELD"/>
+  </Match>
+  <Match>
     <!-- Concrete Map type not affected -->
     <Class name="org.apache.catalina.util.TestParameterMap" />
     <Method name="testEntrySetImmutabilityAfterLocked" />
@@ -1622,6 +1699,18 @@
     <Bug pattern="DLS_DEAD_LOCAL_STORE"/>
   </Match>
   <Match>
+    <!-- Return value ignored as this is a performance test -->
+    <Class name="org.apache.catalina.webresources.TestAbstractFileResourceSetPerformance" />
+    <Method name="testFileNameFiltering" />
+    <Bug pattern="RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT"/>
+  </Match>
+  <Match>
+    <!-- Use of hard-coded path is deliberate -->
+    <Class name="org.apache.catalina.webresources.TestStandardRoot" />
+    <Method name="&lt;clinit&gt;" />
+    <Bug pattern="DMI_HARDCODED_ABSOLUTE_FILENAME"/>
+  </Match>
+  <Match>
     <!-- Result is negated to compare result when order is reversed -->
     <Class name="org.apache.el.TestELEvaluation" />
     <Method name="compareBoth" />



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org