You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Gary Gregory <gg...@apache.org> on 2018/06/13 19:51:05 UTC

[VOTE] Release Apache Commons DBCP 2.4.0 based on RC1

We have fixed quite a few bugs and added some significant enhancements
since Apache Commons DBCP 2.3.0 was released, so I would like to release
Apache Commons DBCP 2.4.0.

Apache Commons DBCP 2.4.0 RC1 is available for review here:
    https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1 (svn
revision 27438)

The Git tag commons-dbcp-2.4.0-RC1 commit for this RC is
d7aa662fbbb99e536ae28c47d0c4e1d51e39d5b9 which you can browse here:

https://git-wip-us.apache.org/repos/asf?p=commons-dbcp.git;a=tag;h=refs/tags/commons-dbcp-2.4.0-RC1

Maven artifacts are here:

https://repository.apache.org/content/repositories/orgapachecommons-1333/org/apache/commons/commons-dbcp2/2.4.0/

These are the Maven artifacts and their hashes in Nexus:

#Release SHA-1s
#Wed Jun 13 13:32:41 MDT 2018
commons-dbcp2-2.4.0-bin-tar.gz.asc=064e744553fddd0c8c45aeb998429546c773eefc
commons-dbcp2-2.4.0-src-zip=fb3157fa431b3dd059c8bed81c93f93160daba75
commons-dbcp2-2.4.0-javadoc-jar.asc=a2fbc96c6b8553b13b4f2ed653d9aa5717e89842
commons-dbcp2-2.4.0-test-sources-java-source=a8cb680bd20e46b548413ab4f3159a1b6af370fc
commons-dbcp2-2.4.0-test-sources-jar.asc=e073bc4700757d6b6d66a84989ba9f72b85fa2d4
commons-dbcp2-2.4.0-bin-zip.asc=74d108cbbbc0099f87d1536f92b59b5eb1b3657c
commons-dbcp2-2.4.0-bin-zip=fda0585ae3d6cdb64091ffac630806cf1f781e7f
commons-dbcp2-2.4.0-sources-java-source=f3a963f855209e9b4a18ea642a3a01adb95d8946
commons-dbcp2-2.4.0-src-tar.gz=fef764329584d12053c20e50ed628822f22d2728
commons-dbcp2-2.4.0-javadoc-javadoc=46cfd110cc0002c5f37bc6965e0149ec208ef458
commons-dbcp2-2.4.0-bin-tar.gz=382feff1078882750981b91d810117fefe590047
commons-dbcp2-2.4.0-src-tar.gz.asc=00d53b490f2631b2b7515e673cd6063c58c9b4fc
commons-dbcp2-2.4.0-src-zip.asc=7aeaba88bf4a7459e8f20515ba6f26886a0f9702
commons-dbcp2-2.4.0-null-pom.asc=df3fbc3dc6460cba003b16f8eba13ed3ffd8beef
commons-dbcp2-2.4.0-tests-jar.asc=51051e26c5eb6c76e4dbf9523e9c9f22be548343
commons-dbcp2-2.4.0-sources-jar.asc=b3a3467cf022728806eb2db63ca0c1fa76f9a5f4
commons-dbcp2-2.4.0-tests-test-jar=8546d77cf33dbe35145fbcbd4890f29a673b6e97
commons-dbcp2-2.4.0-null-jar.asc=3352f1b1ab04452445709d19272449bc5238d735

#Release SHA-256s
#Wed Jun 13 13:32:41 MDT 2018
commons-dbcp2-2.4.0-bin-tar.gz.asc=530eec11fd24e47a9ef0917f6b2e34f7d3eef7e83089b421fab907c54ebcec8d
commons-dbcp2-2.4.0-src-zip=eb1ee5760dd9e8875f2950297c20dee7307eff09e02a348c621cb5fad9d44a63
commons-dbcp2-2.4.0-javadoc-jar.asc=48c4e82ed05f6ba2c0aafcddc810ef5388c5ab063cd982bec0708fe0d09f75a8
commons-dbcp2-2.4.0-test-sources-java-source=da10f54b4705e706b57b372581bdddd982bc1dcec21ee574864785c54c201fd0
commons-dbcp2-2.4.0-test-sources-jar.asc=7952567ebe6071ebc95bf9c50ad07f2fb0188876130b770d063bf81170657107
commons-dbcp2-2.4.0-bin-zip.asc=95aaa78797145eac624b03389c44a1e0f77c4babb53cf5b2cd436f342ae3a2da
commons-dbcp2-2.4.0-bin-zip=7f87a408dcfaf9ff94fbbd7c1fa6b21a071c0a61ca869c44e749a1fe579b6ca8
commons-dbcp2-2.4.0-sources-java-source=fd36da645134444813e6c12a9f101ed6f8b7838834283893dd5654a76f4c39a9
commons-dbcp2-2.4.0-src-tar.gz=a9b305f623f8c45e6bb392aaf5c045248ff7f326aba69bc6db0869947179ce0e
commons-dbcp2-2.4.0-javadoc-javadoc=27ec0b63947ba5e3bdc5a7fdac592590ca74aa35ece35e5eacee73a5cfc61dce
commons-dbcp2-2.4.0-bin-tar.gz=7a88aca498cd1547e4e15f80ce7dfa89425a6a00c9fe93bbd6f94afee2150c4d
commons-dbcp2-2.4.0-src-tar.gz.asc=115344f789d33094b6d8e8be50562337dc9f62881105b61fedeca17f9b9c20e4
commons-dbcp2-2.4.0-src-zip.asc=2f9a10da8df8bb1d283afb3a7f6567fe1354c60fb97b4bce7766dff3041c1a64
commons-dbcp2-2.4.0-null-pom.asc=a841c9899ef5c341a26b2e4145f7c215c568e577a417d5641201a24686e33450
commons-dbcp2-2.4.0-tests-jar.asc=fbe62bf9d4c0d3db92bfa53215d640d5677f7403665ccdee8f0fab6f205e42fa
commons-dbcp2-2.4.0-sources-jar.asc=550a5fd3427da1aec9fe9c6bcb2935aaf4daf68f098dd2769cab4089cc373c48
commons-dbcp2-2.4.0-tests-test-jar=6f5f5114aa25905a88f2912e2c3425dbb97ae4a6c79daaf5ee5ed98a95dfaca7
commons-dbcp2-2.4.0-null-jar.asc=a8c4e8405ecc14b9aeba997c2886bfe740dd074333bd7164bc4489ce0470bf4b

I have tested this with ***'mvn clean install site'*** using:
Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297;
2018-02-24T12:49:05-07:00)
Maven home: C:\Java\apache-maven-3.5.3\bin\..
Java version: 1.8.0_172, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.8.0_172\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Details of changes since 2.3.0 are in the release notes:

https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1/RELEASE-NOTES.txt

https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1/site/changes-report.html

Site:
    https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1/site
    (note some *relative* links are broken and the 2.4.0 directories are
not yet created - these will be OK once the site is deployed.)

CLIRR Report (compared to 2.3.0):

https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1/site/clirr-report.html
    There are no errors or warnings.

RAT Report:

https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1/site/rat-report.html

KEYS:
  https://www.apache.org/dist/commons/KEYS

Please review the release candidate and vote.
This vote will close no sooner that 72 hours from now.

  [ ] +1 Release these artifacts
  [ ] +0 OK, but...
  [ ] -0 OK, but really should fix...
  [ ] -1 I oppose this release because...

Thank you,

Gary Gregory,
Release Manager (using key 86fdc7e2a11262cb)

Re: [VOTE] Release Apache Commons DBCP 2.4.0 based on RC1

Posted by "Bruno P. Kinoshita" <br...@yahoo.com.br.INVALID>.
[ X ] +1 Release these artifacts


Building OK from commit d7aa662fbbb99e536ae28c47d0c4e1d51e39d5b9 passing OK on 


Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T20:58:13+13:00)
Maven home: /opt/apache-maven-3.5.2
Java version: 1.8.0_171, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_NZ, platform encoding: UTF-8

OS name: "linux", version: "4.4.0-127-generic", arch: "amd64", family: "unix"

Lots of Checkstyle issues fixed. But a few more FindBugs introduced, though same type, related to arrays. There are two about locks not being released, but I had a look and they look like false-positives?

Code coverage is indeed low, and after your other e-mail I added a post-it on my desk to spend some time trying to add more tests to DBCP during the next rainy day here (it rains a lot on winter, so possibly working on it next weekend?).

Checked maven artifacts and dist area zips signatures, and they look OK.

Thanks for RM'ing.

Cheers
Bruno

________________________________
From: Gary Gregory <gg...@apache.org>
To: Commons Developers List <de...@commons.apache.org> 
Sent: Thursday, 14 June 2018 7:51 AM
Subject: [VOTE] Release Apache Commons DBCP 2.4.0 based on RC1



We have fixed quite a few bugs and added some significant enhancements

since Apache Commons DBCP 2.3.0 was released, so I would like to release

Apache Commons DBCP 2.4.0.


Apache Commons DBCP 2.4.0 RC1 is available for review here:

    https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1 (svn

revision 27438)


The Git tag commons-dbcp-2.4.0-RC1 commit for this RC is

d7aa662fbbb99e536ae28c47d0c4e1d51e39d5b9 which you can browse here:


https://git-wip-us.apache.org/repos/asf?p=commons-dbcp.git;a=tag;h=refs/tags/commons-dbcp-2.4.0-RC1


Maven artifacts are here:


https://repository.apache.org/content/repositories/orgapachecommons-1333/org/apache/commons/commons-dbcp2/2.4.0/


These are the Maven artifacts and their hashes in Nexus:


#Release SHA-1s

#Wed Jun 13 13:32:41 MDT 2018

commons-dbcp2-2.4.0-bin-tar.gz.asc=064e744553fddd0c8c45aeb998429546c773eefc

commons-dbcp2-2.4.0-src-zip=fb3157fa431b3dd059c8bed81c93f93160daba75

commons-dbcp2-2.4.0-javadoc-jar.asc=a2fbc96c6b8553b13b4f2ed653d9aa5717e89842

commons-dbcp2-2.4.0-test-sources-java-source=a8cb680bd20e46b548413ab4f3159a1b6af370fc

commons-dbcp2-2.4.0-test-sources-jar.asc=e073bc4700757d6b6d66a84989ba9f72b85fa2d4

commons-dbcp2-2.4.0-bin-zip.asc=74d108cbbbc0099f87d1536f92b59b5eb1b3657c

commons-dbcp2-2.4.0-bin-zip=fda0585ae3d6cdb64091ffac630806cf1f781e7f

commons-dbcp2-2.4.0-sources-java-source=f3a963f855209e9b4a18ea642a3a01adb95d8946

commons-dbcp2-2.4.0-src-tar.gz=fef764329584d12053c20e50ed628822f22d2728

commons-dbcp2-2.4.0-javadoc-javadoc=46cfd110cc0002c5f37bc6965e0149ec208ef458

commons-dbcp2-2.4.0-bin-tar.gz=382feff1078882750981b91d810117fefe590047

commons-dbcp2-2.4.0-src-tar.gz.asc=00d53b490f2631b2b7515e673cd6063c58c9b4fc

commons-dbcp2-2.4.0-src-zip.asc=7aeaba88bf4a7459e8f20515ba6f26886a0f9702

commons-dbcp2-2.4.0-null-pom.asc=df3fbc3dc6460cba003b16f8eba13ed3ffd8beef

commons-dbcp2-2.4.0-tests-jar.asc=51051e26c5eb6c76e4dbf9523e9c9f22be548343

commons-dbcp2-2.4.0-sources-jar.asc=b3a3467cf022728806eb2db63ca0c1fa76f9a5f4

commons-dbcp2-2.4.0-tests-test-jar=8546d77cf33dbe35145fbcbd4890f29a673b6e97

commons-dbcp2-2.4.0-null-jar.asc=3352f1b1ab04452445709d19272449bc5238d735


#Release SHA-256s

#Wed Jun 13 13:32:41 MDT 2018

commons-dbcp2-2.4.0-bin-tar.gz.asc=530eec11fd24e47a9ef0917f6b2e34f7d3eef7e83089b421fab907c54ebcec8d

commons-dbcp2-2.4.0-src-zip=eb1ee5760dd9e8875f2950297c20dee7307eff09e02a348c621cb5fad9d44a63

commons-dbcp2-2.4.0-javadoc-jar.asc=48c4e82ed05f6ba2c0aafcddc810ef5388c5ab063cd982bec0708fe0d09f75a8

commons-dbcp2-2.4.0-test-sources-java-source=da10f54b4705e706b57b372581bdddd982bc1dcec21ee574864785c54c201fd0

commons-dbcp2-2.4.0-test-sources-jar.asc=7952567ebe6071ebc95bf9c50ad07f2fb0188876130b770d063bf81170657107

commons-dbcp2-2.4.0-bin-zip.asc=95aaa78797145eac624b03389c44a1e0f77c4babb53cf5b2cd436f342ae3a2da

commons-dbcp2-2.4.0-bin-zip=7f87a408dcfaf9ff94fbbd7c1fa6b21a071c0a61ca869c44e749a1fe579b6ca8

commons-dbcp2-2.4.0-sources-java-source=fd36da645134444813e6c12a9f101ed6f8b7838834283893dd5654a76f4c39a9

commons-dbcp2-2.4.0-src-tar.gz=a9b305f623f8c45e6bb392aaf5c045248ff7f326aba69bc6db0869947179ce0e

commons-dbcp2-2.4.0-javadoc-javadoc=27ec0b63947ba5e3bdc5a7fdac592590ca74aa35ece35e5eacee73a5cfc61dce

commons-dbcp2-2.4.0-bin-tar.gz=7a88aca498cd1547e4e15f80ce7dfa89425a6a00c9fe93bbd6f94afee2150c4d

commons-dbcp2-2.4.0-src-tar.gz.asc=115344f789d33094b6d8e8be50562337dc9f62881105b61fedeca17f9b9c20e4

commons-dbcp2-2.4.0-src-zip.asc=2f9a10da8df8bb1d283afb3a7f6567fe1354c60fb97b4bce7766dff3041c1a64

commons-dbcp2-2.4.0-null-pom.asc=a841c9899ef5c341a26b2e4145f7c215c568e577a417d5641201a24686e33450

commons-dbcp2-2.4.0-tests-jar.asc=fbe62bf9d4c0d3db92bfa53215d640d5677f7403665ccdee8f0fab6f205e42fa

commons-dbcp2-2.4.0-sources-jar.asc=550a5fd3427da1aec9fe9c6bcb2935aaf4daf68f098dd2769cab4089cc373c48

commons-dbcp2-2.4.0-tests-test-jar=6f5f5114aa25905a88f2912e2c3425dbb97ae4a6c79daaf5ee5ed98a95dfaca7

commons-dbcp2-2.4.0-null-jar.asc=a8c4e8405ecc14b9aeba997c2886bfe740dd074333bd7164bc4489ce0470bf4b


I have tested this with ***'mvn clean install site'*** using:

Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297;

2018-02-24T12:49:05-07:00)

Maven home: C:\Java\apache-maven-3.5.3\bin\..

Java version: 1.8.0_172, vendor: Oracle Corporation

Java home: C:\Program Files\Java\jdk1.8.0_172\jre

Default locale: en_US, platform encoding: Cp1252

OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"


Details of changes since 2.3.0 are in the release notes:


https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1/RELEASE-NOTES.txt


https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1/site/changes-report.html


Site:

    https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1/site

    (note some *relative* links are broken and the 2.4.0 directories are

not yet created - these will be OK once the site is deployed.)


CLIRR Report (compared to 2.3.0):


https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1/site/clirr-report.html

    There are no errors or warnings.


RAT Report:


https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1/site/rat-report.html


KEYS:

  https://www.apache.org/dist/commons/KEYS


Please review the release candidate and vote.

This vote will close no sooner that 72 hours from now.


  [ ] +1 Release these artifacts

  [ ] +0 OK, but...

  [ ] -0 OK, but really should fix...

  [ ] -1 I oppose this release because...


Thank you,


Gary Gregory,

Release Manager (using key 86fdc7e2a11262cb)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Apache Commons DBCP 2.4.0 based on RC1

Posted by Gary Gregory <ga...@gmail.com>.
My +1.

Gary

On Wed, Jun 13, 2018 at 1:51 PM Gary Gregory <gg...@apache.org> wrote:

> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons DBCP 2.3.0 was released, so I would like to release
> Apache Commons DBCP 2.4.0.
>
> Apache Commons DBCP 2.4.0 RC1 is available for review here:
>     https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1 (svn
> revision 27438)
>
> The Git tag commons-dbcp-2.4.0-RC1 commit for this RC is
> d7aa662fbbb99e536ae28c47d0c4e1d51e39d5b9 which you can browse here:
>
> https://git-wip-us.apache.org/repos/asf?p=commons-dbcp.git;a=tag;h=refs/tags/commons-dbcp-2.4.0-RC1
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1333/org/apache/commons/commons-dbcp2/2.4.0/
>
> These are the Maven artifacts and their hashes in Nexus:
>
> #Release SHA-1s
> #Wed Jun 13 13:32:41 MDT 2018
> commons-dbcp2-2.4.0-bin-tar.gz.asc=064e744553fddd0c8c45aeb998429546c773eefc
> commons-dbcp2-2.4.0-src-zip=fb3157fa431b3dd059c8bed81c93f93160daba75
>
> commons-dbcp2-2.4.0-javadoc-jar.asc=a2fbc96c6b8553b13b4f2ed653d9aa5717e89842
>
> commons-dbcp2-2.4.0-test-sources-java-source=a8cb680bd20e46b548413ab4f3159a1b6af370fc
>
> commons-dbcp2-2.4.0-test-sources-jar.asc=e073bc4700757d6b6d66a84989ba9f72b85fa2d4
> commons-dbcp2-2.4.0-bin-zip.asc=74d108cbbbc0099f87d1536f92b59b5eb1b3657c
> commons-dbcp2-2.4.0-bin-zip=fda0585ae3d6cdb64091ffac630806cf1f781e7f
>
> commons-dbcp2-2.4.0-sources-java-source=f3a963f855209e9b4a18ea642a3a01adb95d8946
> commons-dbcp2-2.4.0-src-tar.gz=fef764329584d12053c20e50ed628822f22d2728
>
> commons-dbcp2-2.4.0-javadoc-javadoc=46cfd110cc0002c5f37bc6965e0149ec208ef458
> commons-dbcp2-2.4.0-bin-tar.gz=382feff1078882750981b91d810117fefe590047
> commons-dbcp2-2.4.0-src-tar.gz.asc=00d53b490f2631b2b7515e673cd6063c58c9b4fc
> commons-dbcp2-2.4.0-src-zip.asc=7aeaba88bf4a7459e8f20515ba6f26886a0f9702
> commons-dbcp2-2.4.0-null-pom.asc=df3fbc3dc6460cba003b16f8eba13ed3ffd8beef
> commons-dbcp2-2.4.0-tests-jar.asc=51051e26c5eb6c76e4dbf9523e9c9f22be548343
>
> commons-dbcp2-2.4.0-sources-jar.asc=b3a3467cf022728806eb2db63ca0c1fa76f9a5f4
> commons-dbcp2-2.4.0-tests-test-jar=8546d77cf33dbe35145fbcbd4890f29a673b6e97
> commons-dbcp2-2.4.0-null-jar.asc=3352f1b1ab04452445709d19272449bc5238d735
>
> #Release SHA-256s
> #Wed Jun 13 13:32:41 MDT 2018
>
> commons-dbcp2-2.4.0-bin-tar.gz.asc=530eec11fd24e47a9ef0917f6b2e34f7d3eef7e83089b421fab907c54ebcec8d
>
> commons-dbcp2-2.4.0-src-zip=eb1ee5760dd9e8875f2950297c20dee7307eff09e02a348c621cb5fad9d44a63
>
> commons-dbcp2-2.4.0-javadoc-jar.asc=48c4e82ed05f6ba2c0aafcddc810ef5388c5ab063cd982bec0708fe0d09f75a8
>
> commons-dbcp2-2.4.0-test-sources-java-source=da10f54b4705e706b57b372581bdddd982bc1dcec21ee574864785c54c201fd0
>
> commons-dbcp2-2.4.0-test-sources-jar.asc=7952567ebe6071ebc95bf9c50ad07f2fb0188876130b770d063bf81170657107
>
> commons-dbcp2-2.4.0-bin-zip.asc=95aaa78797145eac624b03389c44a1e0f77c4babb53cf5b2cd436f342ae3a2da
>
> commons-dbcp2-2.4.0-bin-zip=7f87a408dcfaf9ff94fbbd7c1fa6b21a071c0a61ca869c44e749a1fe579b6ca8
>
> commons-dbcp2-2.4.0-sources-java-source=fd36da645134444813e6c12a9f101ed6f8b7838834283893dd5654a76f4c39a9
>
> commons-dbcp2-2.4.0-src-tar.gz=a9b305f623f8c45e6bb392aaf5c045248ff7f326aba69bc6db0869947179ce0e
>
> commons-dbcp2-2.4.0-javadoc-javadoc=27ec0b63947ba5e3bdc5a7fdac592590ca74aa35ece35e5eacee73a5cfc61dce
>
> commons-dbcp2-2.4.0-bin-tar.gz=7a88aca498cd1547e4e15f80ce7dfa89425a6a00c9fe93bbd6f94afee2150c4d
>
> commons-dbcp2-2.4.0-src-tar.gz.asc=115344f789d33094b6d8e8be50562337dc9f62881105b61fedeca17f9b9c20e4
>
> commons-dbcp2-2.4.0-src-zip.asc=2f9a10da8df8bb1d283afb3a7f6567fe1354c60fb97b4bce7766dff3041c1a64
>
> commons-dbcp2-2.4.0-null-pom.asc=a841c9899ef5c341a26b2e4145f7c215c568e577a417d5641201a24686e33450
>
> commons-dbcp2-2.4.0-tests-jar.asc=fbe62bf9d4c0d3db92bfa53215d640d5677f7403665ccdee8f0fab6f205e42fa
>
> commons-dbcp2-2.4.0-sources-jar.asc=550a5fd3427da1aec9fe9c6bcb2935aaf4daf68f098dd2769cab4089cc373c48
>
> commons-dbcp2-2.4.0-tests-test-jar=6f5f5114aa25905a88f2912e2c3425dbb97ae4a6c79daaf5ee5ed98a95dfaca7
>
> commons-dbcp2-2.4.0-null-jar.asc=a8c4e8405ecc14b9aeba997c2886bfe740dd074333bd7164bc4489ce0470bf4b
>
> I have tested this with ***'mvn clean install site'*** using:
> Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297;
> 2018-02-24T12:49:05-07:00)
> Maven home: C:\Java\apache-maven-3.5.3\bin\..
> Java version: 1.8.0_172, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.8.0_172\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>
> Details of changes since 2.3.0 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1/site/changes-report.html
>
> Site:
>     https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1/site
>     (note some *relative* links are broken and the 2.4.0 directories are
> not yet created - these will be OK once the site is deployed.)
>
> CLIRR Report (compared to 2.3.0):
>
> https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1/site/clirr-report.html
>     There are no errors or warnings.
>
> RAT Report:
>
> https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1/site/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thank you,
>
> Gary Gregory,
> Release Manager (using key 86fdc7e2a11262cb)
>

Re: [VOTE] Release Apache Commons DBCP 2.4.0 based on RC1

Posted by Rob Tompkins <ch...@gmail.com>.

> On Jun 14, 2018, at 9:52 AM, Gary Gregory <ga...@gmail.com> wrote:
> 
> On Thu, Jun 14, 2018 at 7:44 AM Rob Tompkins <ch...@gmail.com> wrote:
> 
>> 
>> 
>>> On Jun 14, 2018, at 9:37 AM, Gary Gregory <ga...@gmail.com>
>> wrote:
>>> 
>>> On Thu, Jun 14, 2018 at 6:59 AM Gary Gregory <ga...@gmail.com>
>> wrote:
>>> 
>>>> That is just a bug in the release plugin that generated the vote text:
>> it
>>>> printed null for the Maven qualifier when there is none (like "bin" for
>>>> some other files.)
>>>> 
>>> 
>>> IOW, my email text was wrong those file names should not have "-null”.
>> 
>> +1
>> 
> 
> Hi Rob,
> 
> Is this a +1 to agree with my comment or a +1 for the VOTE? -- this is a
> VOTE thread ;-)

Pardon…that was a +1 in agreement to the getting rid of the “-null”. I’ll do validation later today.

> 
> Gary
> 
> 
>>> 
>>> Gary
>>> 
>>>> 
>>>> Gary
>>>> 
>>>> On Thu, Jun 14, 2018, 04:59 Emmanuel Bourg <eb...@apache.org> wrote:
>>>> 
>>>>> Le 13/06/2018 à 21:51, Gary Gregory a écrit :
>>>>> 
>>>>>> #Release SHA-1s
>>>>>> 
>>>>> 
>> commons-dbcp2-2.4.0-null-pom.asc=df3fbc3dc6460cba003b16f8eba13ed3ffd8beef
>>>>>> 
>>>>> 
>> commons-dbcp2-2.4.0-null-jar.asc=3352f1b1ab04452445709d19272449bc5238d735
>>>>> 
>>>>> Are these "null" files excepted?
>>>>> 
>>>>> Emmanuel Bourg
>>>>> 
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>> 
>>>>> 
>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>> 
>> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Apache Commons DBCP 2.4.0 based on RC1

Posted by Gary Gregory <ga...@gmail.com>.
On Thu, Jun 14, 2018 at 7:44 AM Rob Tompkins <ch...@gmail.com> wrote:

>
>
> > On Jun 14, 2018, at 9:37 AM, Gary Gregory <ga...@gmail.com>
> wrote:
> >
> > On Thu, Jun 14, 2018 at 6:59 AM Gary Gregory <ga...@gmail.com>
> wrote:
> >
> >> That is just a bug in the release plugin that generated the vote text:
> it
> >> printed null for the Maven qualifier when there is none (like "bin" for
> >> some other files.)
> >>
> >
> > IOW, my email text was wrong those file names should not have "-null”.
>
> +1
>

Hi Rob,

Is this a +1 to agree with my comment or a +1 for the VOTE? -- this is a
VOTE thread ;-)

Gary


> >
> > Gary
> >
> >>
> >> Gary
> >>
> >> On Thu, Jun 14, 2018, 04:59 Emmanuel Bourg <eb...@apache.org> wrote:
> >>
> >>> Le 13/06/2018 à 21:51, Gary Gregory a écrit :
> >>>
> >>>> #Release SHA-1s
> >>>>
> >>>
> commons-dbcp2-2.4.0-null-pom.asc=df3fbc3dc6460cba003b16f8eba13ed3ffd8beef
> >>>>
> >>>
> commons-dbcp2-2.4.0-null-jar.asc=3352f1b1ab04452445709d19272449bc5238d735
> >>>
> >>> Are these "null" files excepted?
> >>>
> >>> Emmanuel Bourg
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >>> For additional commands, e-mail: dev-help@commons.apache.org
> >>>
> >>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

Re: [VOTE] Release Apache Commons DBCP 2.4.0 based on RC1

Posted by Rob Tompkins <ch...@gmail.com>.

> On Jun 14, 2018, at 9:37 AM, Gary Gregory <ga...@gmail.com> wrote:
> 
> On Thu, Jun 14, 2018 at 6:59 AM Gary Gregory <ga...@gmail.com> wrote:
> 
>> That is just a bug in the release plugin that generated the vote text: it
>> printed null for the Maven qualifier when there is none (like "bin" for
>> some other files.)
>> 
> 
> IOW, my email text was wrong those file names should not have "-null”.

+1

> 
> Gary
> 
>> 
>> Gary
>> 
>> On Thu, Jun 14, 2018, 04:59 Emmanuel Bourg <eb...@apache.org> wrote:
>> 
>>> Le 13/06/2018 à 21:51, Gary Gregory a écrit :
>>> 
>>>> #Release SHA-1s
>>>> 
>>> commons-dbcp2-2.4.0-null-pom.asc=df3fbc3dc6460cba003b16f8eba13ed3ffd8beef
>>>> 
>>> commons-dbcp2-2.4.0-null-jar.asc=3352f1b1ab04452445709d19272449bc5238d735
>>> 
>>> Are these "null" files excepted?
>>> 
>>> Emmanuel Bourg
>>> 
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>> 
>>> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Apache Commons DBCP 2.4.0 based on RC1

Posted by Gary Gregory <ga...@gmail.com>.
On Thu, Jun 14, 2018 at 6:59 AM Gary Gregory <ga...@gmail.com> wrote:

> That is just a bug in the release plugin that generated the vote text: it
> printed null for the Maven qualifier when there is none (like "bin" for
> some other files.)
>

IOW, my email text was wrong those file names should not have "-null".

Gary

>
> Gary
>
> On Thu, Jun 14, 2018, 04:59 Emmanuel Bourg <eb...@apache.org> wrote:
>
>> Le 13/06/2018 à 21:51, Gary Gregory a écrit :
>>
>> > #Release SHA-1s
>> >
>> commons-dbcp2-2.4.0-null-pom.asc=df3fbc3dc6460cba003b16f8eba13ed3ffd8beef
>> >
>> commons-dbcp2-2.4.0-null-jar.asc=3352f1b1ab04452445709d19272449bc5238d735
>>
>> Are these "null" files excepted?
>>
>> Emmanuel Bourg
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>

Re: [VOTE] Release Apache Commons DBCP 2.4.0 based on RC1

Posted by Gary Gregory <ga...@gmail.com>.
That is just a bug in the release plugin that generated the vote text: it
printed null for the Maven qualifier when there is none (like "bin" for
some other files.)

Gary

On Thu, Jun 14, 2018, 04:59 Emmanuel Bourg <eb...@apache.org> wrote:

> Le 13/06/2018 à 21:51, Gary Gregory a écrit :
>
> > #Release SHA-1s
> > commons-dbcp2-2.4.0-null-pom.asc=df3fbc3dc6460cba003b16f8eba13ed3ffd8beef
> > commons-dbcp2-2.4.0-null-jar.asc=3352f1b1ab04452445709d19272449bc5238d735
>
> Are these "null" files excepted?
>
> Emmanuel Bourg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

Re: [VOTE] Release Apache Commons DBCP 2.4.0 based on RC1

Posted by Gary Gregory <ga...@gmail.com>.
Hi Emmanuel,

Where you planning on reviewing further?

Gary


On Thu, Jun 14, 2018 at 4:59 AM Emmanuel Bourg <eb...@apache.org> wrote:

> Le 13/06/2018 à 21:51, Gary Gregory a écrit :
>
> > #Release SHA-1s
> > commons-dbcp2-2.4.0-null-pom.asc=df3fbc3dc6460cba003b16f8eba13ed3ffd8beef
> > commons-dbcp2-2.4.0-null-jar.asc=3352f1b1ab04452445709d19272449bc5238d735
>
> Are these "null" files excepted?
>
> Emmanuel Bourg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

Re: [VOTE] Release Apache Commons DBCP 2.4.0 based on RC1

Posted by Emmanuel Bourg <eb...@apache.org>.
Le 13/06/2018 à 21:51, Gary Gregory a écrit :

> #Release SHA-1s
> commons-dbcp2-2.4.0-null-pom.asc=df3fbc3dc6460cba003b16f8eba13ed3ffd8beef
> commons-dbcp2-2.4.0-null-jar.asc=3352f1b1ab04452445709d19272449bc5238d735

Are these "null" files excepted?

Emmanuel Bourg

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Apache Commons DBCP 2.4.0 based on RC1

Posted by Rob Tompkins <ch...@gmail.com>.
md5’s good, sha1’s good, sha256’s good, builds java 7, 8, 9, site good: +1

Nits. Coverage (known), Findbugs issues.

> On Jun 13, 2018, at 3:51 PM, Gary Gregory <gg...@apache.org> wrote:
> 
> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons DBCP 2.3.0 was released, so I would like to release
> Apache Commons DBCP 2.4.0.
> 
> Apache Commons DBCP 2.4.0 RC1 is available for review here:
>    https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1 (svn
> revision 27438)
> 
> The Git tag commons-dbcp-2.4.0-RC1 commit for this RC is
> d7aa662fbbb99e536ae28c47d0c4e1d51e39d5b9 which you can browse here:
> 
> https://git-wip-us.apache.org/repos/asf?p=commons-dbcp.git;a=tag;h=refs/tags/commons-dbcp-2.4.0-RC1
> 
> Maven artifacts are here:
> 
> https://repository.apache.org/content/repositories/orgapachecommons-1333/org/apache/commons/commons-dbcp2/2.4.0/
> 
> These are the Maven artifacts and their hashes in Nexus:
> 
> #Release SHA-1s
> #Wed Jun 13 13:32:41 MDT 2018
> commons-dbcp2-2.4.0-bin-tar.gz.asc=064e744553fddd0c8c45aeb998429546c773eefc
> commons-dbcp2-2.4.0-src-zip=fb3157fa431b3dd059c8bed81c93f93160daba75
> commons-dbcp2-2.4.0-javadoc-jar.asc=a2fbc96c6b8553b13b4f2ed653d9aa5717e89842
> commons-dbcp2-2.4.0-test-sources-java-source=a8cb680bd20e46b548413ab4f3159a1b6af370fc
> commons-dbcp2-2.4.0-test-sources-jar.asc=e073bc4700757d6b6d66a84989ba9f72b85fa2d4
> commons-dbcp2-2.4.0-bin-zip.asc=74d108cbbbc0099f87d1536f92b59b5eb1b3657c
> commons-dbcp2-2.4.0-bin-zip=fda0585ae3d6cdb64091ffac630806cf1f781e7f
> commons-dbcp2-2.4.0-sources-java-source=f3a963f855209e9b4a18ea642a3a01adb95d8946
> commons-dbcp2-2.4.0-src-tar.gz=fef764329584d12053c20e50ed628822f22d2728
> commons-dbcp2-2.4.0-javadoc-javadoc=46cfd110cc0002c5f37bc6965e0149ec208ef458
> commons-dbcp2-2.4.0-bin-tar.gz=382feff1078882750981b91d810117fefe590047
> commons-dbcp2-2.4.0-src-tar.gz.asc=00d53b490f2631b2b7515e673cd6063c58c9b4fc
> commons-dbcp2-2.4.0-src-zip.asc=7aeaba88bf4a7459e8f20515ba6f26886a0f9702
> commons-dbcp2-2.4.0-null-pom.asc=df3fbc3dc6460cba003b16f8eba13ed3ffd8beef
> commons-dbcp2-2.4.0-tests-jar.asc=51051e26c5eb6c76e4dbf9523e9c9f22be548343
> commons-dbcp2-2.4.0-sources-jar.asc=b3a3467cf022728806eb2db63ca0c1fa76f9a5f4
> commons-dbcp2-2.4.0-tests-test-jar=8546d77cf33dbe35145fbcbd4890f29a673b6e97
> commons-dbcp2-2.4.0-null-jar.asc=3352f1b1ab04452445709d19272449bc5238d735
> 
> #Release SHA-256s
> #Wed Jun 13 13:32:41 MDT 2018
> commons-dbcp2-2.4.0-bin-tar.gz.asc=530eec11fd24e47a9ef0917f6b2e34f7d3eef7e83089b421fab907c54ebcec8d
> commons-dbcp2-2.4.0-src-zip=eb1ee5760dd9e8875f2950297c20dee7307eff09e02a348c621cb5fad9d44a63
> commons-dbcp2-2.4.0-javadoc-jar.asc=48c4e82ed05f6ba2c0aafcddc810ef5388c5ab063cd982bec0708fe0d09f75a8
> commons-dbcp2-2.4.0-test-sources-java-source=da10f54b4705e706b57b372581bdddd982bc1dcec21ee574864785c54c201fd0
> commons-dbcp2-2.4.0-test-sources-jar.asc=7952567ebe6071ebc95bf9c50ad07f2fb0188876130b770d063bf81170657107
> commons-dbcp2-2.4.0-bin-zip.asc=95aaa78797145eac624b03389c44a1e0f77c4babb53cf5b2cd436f342ae3a2da
> commons-dbcp2-2.4.0-bin-zip=7f87a408dcfaf9ff94fbbd7c1fa6b21a071c0a61ca869c44e749a1fe579b6ca8
> commons-dbcp2-2.4.0-sources-java-source=fd36da645134444813e6c12a9f101ed6f8b7838834283893dd5654a76f4c39a9
> commons-dbcp2-2.4.0-src-tar.gz=a9b305f623f8c45e6bb392aaf5c045248ff7f326aba69bc6db0869947179ce0e
> commons-dbcp2-2.4.0-javadoc-javadoc=27ec0b63947ba5e3bdc5a7fdac592590ca74aa35ece35e5eacee73a5cfc61dce
> commons-dbcp2-2.4.0-bin-tar.gz=7a88aca498cd1547e4e15f80ce7dfa89425a6a00c9fe93bbd6f94afee2150c4d
> commons-dbcp2-2.4.0-src-tar.gz.asc=115344f789d33094b6d8e8be50562337dc9f62881105b61fedeca17f9b9c20e4
> commons-dbcp2-2.4.0-src-zip.asc=2f9a10da8df8bb1d283afb3a7f6567fe1354c60fb97b4bce7766dff3041c1a64
> commons-dbcp2-2.4.0-null-pom.asc=a841c9899ef5c341a26b2e4145f7c215c568e577a417d5641201a24686e33450
> commons-dbcp2-2.4.0-tests-jar.asc=fbe62bf9d4c0d3db92bfa53215d640d5677f7403665ccdee8f0fab6f205e42fa
> commons-dbcp2-2.4.0-sources-jar.asc=550a5fd3427da1aec9fe9c6bcb2935aaf4daf68f098dd2769cab4089cc373c48
> commons-dbcp2-2.4.0-tests-test-jar=6f5f5114aa25905a88f2912e2c3425dbb97ae4a6c79daaf5ee5ed98a95dfaca7
> commons-dbcp2-2.4.0-null-jar.asc=a8c4e8405ecc14b9aeba997c2886bfe740dd074333bd7164bc4489ce0470bf4b
> 
> I have tested this with ***'mvn clean install site'*** using:
> Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297;
> 2018-02-24T12:49:05-07:00)
> Maven home: C:\Java\apache-maven-3.5.3\bin\..
> Java version: 1.8.0_172, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.8.0_172\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
> 
> Details of changes since 2.3.0 are in the release notes:
> 
> https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1/RELEASE-NOTES.txt
> 
> https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1/site/changes-report.html
> 
> Site:
>    https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1/site
>    (note some *relative* links are broken and the 2.4.0 directories are
> not yet created - these will be OK once the site is deployed.)
> 
> CLIRR Report (compared to 2.3.0):
> 
> https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1/site/clirr-report.html
>    There are no errors or warnings.
> 
> RAT Report:
> 
> https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1/site/rat-report.html
> 
> KEYS:
>  https://www.apache.org/dist/commons/KEYS
> 
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
> 
>  [ ] +1 Release these artifacts
>  [ ] +0 OK, but...
>  [ ] -0 OK, but really should fix...
>  [ ] -1 I oppose this release because...
> 
> Thank you,
> 
> Gary Gregory,
> Release Manager (using key 86fdc7e2a11262cb)


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


[VOTE][RESULT] Release Apache Commons DBCP 2.4.0 based on RC1

Posted by Gary Gregory <gg...@apache.org>.
This VOTE passes with the following +1s from PMC members:

- Bruno P. Kinoshita
- Rob Tompkins
- Gary Gregory

In addition, Sergio Fernández cast a non-binding +1 vote.

Gary


On Wed, Jun 13, 2018 at 1:51 PM Gary Gregory <gg...@apache.org> wrote:

> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons DBCP 2.3.0 was released, so I would like to release
> Apache Commons DBCP 2.4.0.
>
> Apache Commons DBCP 2.4.0 RC1 is available for review here:
>     https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1 (svn
> revision 27438)
>
> The Git tag commons-dbcp-2.4.0-RC1 commit for this RC is
> d7aa662fbbb99e536ae28c47d0c4e1d51e39d5b9 which you can browse here:
>
> https://git-wip-us.apache.org/repos/asf?p=commons-dbcp.git;a=tag;h=refs/tags/commons-dbcp-2.4.0-RC1
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1333/org/apache/commons/commons-dbcp2/2.4.0/
>
> These are the Maven artifacts and their hashes in Nexus:
>
> #Release SHA-1s
> #Wed Jun 13 13:32:41 MDT 2018
> commons-dbcp2-2.4.0-bin-tar.gz.asc=064e744553fddd0c8c45aeb998429546c773eefc
> commons-dbcp2-2.4.0-src-zip=fb3157fa431b3dd059c8bed81c93f93160daba75
>
> commons-dbcp2-2.4.0-javadoc-jar.asc=a2fbc96c6b8553b13b4f2ed653d9aa5717e89842
>
> commons-dbcp2-2.4.0-test-sources-java-source=a8cb680bd20e46b548413ab4f3159a1b6af370fc
>
> commons-dbcp2-2.4.0-test-sources-jar.asc=e073bc4700757d6b6d66a84989ba9f72b85fa2d4
> commons-dbcp2-2.4.0-bin-zip.asc=74d108cbbbc0099f87d1536f92b59b5eb1b3657c
> commons-dbcp2-2.4.0-bin-zip=fda0585ae3d6cdb64091ffac630806cf1f781e7f
>
> commons-dbcp2-2.4.0-sources-java-source=f3a963f855209e9b4a18ea642a3a01adb95d8946
> commons-dbcp2-2.4.0-src-tar.gz=fef764329584d12053c20e50ed628822f22d2728
>
> commons-dbcp2-2.4.0-javadoc-javadoc=46cfd110cc0002c5f37bc6965e0149ec208ef458
> commons-dbcp2-2.4.0-bin-tar.gz=382feff1078882750981b91d810117fefe590047
> commons-dbcp2-2.4.0-src-tar.gz.asc=00d53b490f2631b2b7515e673cd6063c58c9b4fc
> commons-dbcp2-2.4.0-src-zip.asc=7aeaba88bf4a7459e8f20515ba6f26886a0f9702
> commons-dbcp2-2.4.0-null-pom.asc=df3fbc3dc6460cba003b16f8eba13ed3ffd8beef
> commons-dbcp2-2.4.0-tests-jar.asc=51051e26c5eb6c76e4dbf9523e9c9f22be548343
>
> commons-dbcp2-2.4.0-sources-jar.asc=b3a3467cf022728806eb2db63ca0c1fa76f9a5f4
> commons-dbcp2-2.4.0-tests-test-jar=8546d77cf33dbe35145fbcbd4890f29a673b6e97
> commons-dbcp2-2.4.0-null-jar.asc=3352f1b1ab04452445709d19272449bc5238d735
>
> #Release SHA-256s
> #Wed Jun 13 13:32:41 MDT 2018
>
> commons-dbcp2-2.4.0-bin-tar.gz.asc=530eec11fd24e47a9ef0917f6b2e34f7d3eef7e83089b421fab907c54ebcec8d
>
> commons-dbcp2-2.4.0-src-zip=eb1ee5760dd9e8875f2950297c20dee7307eff09e02a348c621cb5fad9d44a63
>
> commons-dbcp2-2.4.0-javadoc-jar.asc=48c4e82ed05f6ba2c0aafcddc810ef5388c5ab063cd982bec0708fe0d09f75a8
>
> commons-dbcp2-2.4.0-test-sources-java-source=da10f54b4705e706b57b372581bdddd982bc1dcec21ee574864785c54c201fd0
>
> commons-dbcp2-2.4.0-test-sources-jar.asc=7952567ebe6071ebc95bf9c50ad07f2fb0188876130b770d063bf81170657107
>
> commons-dbcp2-2.4.0-bin-zip.asc=95aaa78797145eac624b03389c44a1e0f77c4babb53cf5b2cd436f342ae3a2da
>
> commons-dbcp2-2.4.0-bin-zip=7f87a408dcfaf9ff94fbbd7c1fa6b21a071c0a61ca869c44e749a1fe579b6ca8
>
> commons-dbcp2-2.4.0-sources-java-source=fd36da645134444813e6c12a9f101ed6f8b7838834283893dd5654a76f4c39a9
>
> commons-dbcp2-2.4.0-src-tar.gz=a9b305f623f8c45e6bb392aaf5c045248ff7f326aba69bc6db0869947179ce0e
>
> commons-dbcp2-2.4.0-javadoc-javadoc=27ec0b63947ba5e3bdc5a7fdac592590ca74aa35ece35e5eacee73a5cfc61dce
>
> commons-dbcp2-2.4.0-bin-tar.gz=7a88aca498cd1547e4e15f80ce7dfa89425a6a00c9fe93bbd6f94afee2150c4d
>
> commons-dbcp2-2.4.0-src-tar.gz.asc=115344f789d33094b6d8e8be50562337dc9f62881105b61fedeca17f9b9c20e4
>
> commons-dbcp2-2.4.0-src-zip.asc=2f9a10da8df8bb1d283afb3a7f6567fe1354c60fb97b4bce7766dff3041c1a64
>
> commons-dbcp2-2.4.0-null-pom.asc=a841c9899ef5c341a26b2e4145f7c215c568e577a417d5641201a24686e33450
>
> commons-dbcp2-2.4.0-tests-jar.asc=fbe62bf9d4c0d3db92bfa53215d640d5677f7403665ccdee8f0fab6f205e42fa
>
> commons-dbcp2-2.4.0-sources-jar.asc=550a5fd3427da1aec9fe9c6bcb2935aaf4daf68f098dd2769cab4089cc373c48
>
> commons-dbcp2-2.4.0-tests-test-jar=6f5f5114aa25905a88f2912e2c3425dbb97ae4a6c79daaf5ee5ed98a95dfaca7
>
> commons-dbcp2-2.4.0-null-jar.asc=a8c4e8405ecc14b9aeba997c2886bfe740dd074333bd7164bc4489ce0470bf4b
>
> I have tested this with ***'mvn clean install site'*** using:
> Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297;
> 2018-02-24T12:49:05-07:00)
> Maven home: C:\Java\apache-maven-3.5.3\bin\..
> Java version: 1.8.0_172, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.8.0_172\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>
> Details of changes since 2.3.0 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1/site/changes-report.html
>
> Site:
>     https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1/site
>     (note some *relative* links are broken and the 2.4.0 directories are
> not yet created - these will be OK once the site is deployed.)
>
> CLIRR Report (compared to 2.3.0):
>
> https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1/site/clirr-report.html
>     There are no errors or warnings.
>
> RAT Report:
>
> https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1/site/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thank you,
>
> Gary Gregory,
> Release Manager (using key 86fdc7e2a11262cb)
>

Re: [VOTE] Release Apache Commons DBCP 2.4.0 based on RC1

Posted by Sergio Fernández <wi...@apache.org>.
+1 (non-binding)

On Wed, Jun 13, 2018, 12:51 Gary Gregory <gg...@apache.org> wrote:

> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons DBCP 2.3.0 was released, so I would like to release
> Apache Commons DBCP 2.4.0.
>
> Apache Commons DBCP 2.4.0 RC1 is available for review here:
>     https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1 (svn
> revision 27438)
>
> The Git tag commons-dbcp-2.4.0-RC1 commit for this RC is
> d7aa662fbbb99e536ae28c47d0c4e1d51e39d5b9 which you can browse here:
>
>
> https://git-wip-us.apache.org/repos/asf?p=commons-dbcp.git;a=tag;h=refs/tags/commons-dbcp-2.4.0-RC1
>
> Maven artifacts are here:
>
>
> https://repository.apache.org/content/repositories/orgapachecommons-1333/org/apache/commons/commons-dbcp2/2.4.0/
>
> These are the Maven artifacts and their hashes in Nexus:
>
> #Release SHA-1s
> #Wed Jun 13 13:32:41 MDT 2018
> commons-dbcp2-2.4.0-bin-tar.gz.asc=064e744553fddd0c8c45aeb998429546c773eefc
> commons-dbcp2-2.4.0-src-zip=fb3157fa431b3dd059c8bed81c93f93160daba75
>
> commons-dbcp2-2.4.0-javadoc-jar.asc=a2fbc96c6b8553b13b4f2ed653d9aa5717e89842
>
> commons-dbcp2-2.4.0-test-sources-java-source=a8cb680bd20e46b548413ab4f3159a1b6af370fc
>
> commons-dbcp2-2.4.0-test-sources-jar.asc=e073bc4700757d6b6d66a84989ba9f72b85fa2d4
> commons-dbcp2-2.4.0-bin-zip.asc=74d108cbbbc0099f87d1536f92b59b5eb1b3657c
> commons-dbcp2-2.4.0-bin-zip=fda0585ae3d6cdb64091ffac630806cf1f781e7f
>
> commons-dbcp2-2.4.0-sources-java-source=f3a963f855209e9b4a18ea642a3a01adb95d8946
> commons-dbcp2-2.4.0-src-tar.gz=fef764329584d12053c20e50ed628822f22d2728
>
> commons-dbcp2-2.4.0-javadoc-javadoc=46cfd110cc0002c5f37bc6965e0149ec208ef458
> commons-dbcp2-2.4.0-bin-tar.gz=382feff1078882750981b91d810117fefe590047
> commons-dbcp2-2.4.0-src-tar.gz.asc=00d53b490f2631b2b7515e673cd6063c58c9b4fc
> commons-dbcp2-2.4.0-src-zip.asc=7aeaba88bf4a7459e8f20515ba6f26886a0f9702
> commons-dbcp2-2.4.0-null-pom.asc=df3fbc3dc6460cba003b16f8eba13ed3ffd8beef
> commons-dbcp2-2.4.0-tests-jar.asc=51051e26c5eb6c76e4dbf9523e9c9f22be548343
>
> commons-dbcp2-2.4.0-sources-jar.asc=b3a3467cf022728806eb2db63ca0c1fa76f9a5f4
> commons-dbcp2-2.4.0-tests-test-jar=8546d77cf33dbe35145fbcbd4890f29a673b6e97
> commons-dbcp2-2.4.0-null-jar.asc=3352f1b1ab04452445709d19272449bc5238d735
>
> #Release SHA-256s
> #Wed Jun 13 13:32:41 MDT 2018
>
> commons-dbcp2-2.4.0-bin-tar.gz.asc=530eec11fd24e47a9ef0917f6b2e34f7d3eef7e83089b421fab907c54ebcec8d
>
> commons-dbcp2-2.4.0-src-zip=eb1ee5760dd9e8875f2950297c20dee7307eff09e02a348c621cb5fad9d44a63
>
> commons-dbcp2-2.4.0-javadoc-jar.asc=48c4e82ed05f6ba2c0aafcddc810ef5388c5ab063cd982bec0708fe0d09f75a8
>
> commons-dbcp2-2.4.0-test-sources-java-source=da10f54b4705e706b57b372581bdddd982bc1dcec21ee574864785c54c201fd0
>
> commons-dbcp2-2.4.0-test-sources-jar.asc=7952567ebe6071ebc95bf9c50ad07f2fb0188876130b770d063bf81170657107
>
> commons-dbcp2-2.4.0-bin-zip.asc=95aaa78797145eac624b03389c44a1e0f77c4babb53cf5b2cd436f342ae3a2da
>
> commons-dbcp2-2.4.0-bin-zip=7f87a408dcfaf9ff94fbbd7c1fa6b21a071c0a61ca869c44e749a1fe579b6ca8
>
> commons-dbcp2-2.4.0-sources-java-source=fd36da645134444813e6c12a9f101ed6f8b7838834283893dd5654a76f4c39a9
>
> commons-dbcp2-2.4.0-src-tar.gz=a9b305f623f8c45e6bb392aaf5c045248ff7f326aba69bc6db0869947179ce0e
>
> commons-dbcp2-2.4.0-javadoc-javadoc=27ec0b63947ba5e3bdc5a7fdac592590ca74aa35ece35e5eacee73a5cfc61dce
>
> commons-dbcp2-2.4.0-bin-tar.gz=7a88aca498cd1547e4e15f80ce7dfa89425a6a00c9fe93bbd6f94afee2150c4d
>
> commons-dbcp2-2.4.0-src-tar.gz.asc=115344f789d33094b6d8e8be50562337dc9f62881105b61fedeca17f9b9c20e4
>
> commons-dbcp2-2.4.0-src-zip.asc=2f9a10da8df8bb1d283afb3a7f6567fe1354c60fb97b4bce7766dff3041c1a64
>
> commons-dbcp2-2.4.0-null-pom.asc=a841c9899ef5c341a26b2e4145f7c215c568e577a417d5641201a24686e33450
>
> commons-dbcp2-2.4.0-tests-jar.asc=fbe62bf9d4c0d3db92bfa53215d640d5677f7403665ccdee8f0fab6f205e42fa
>
> commons-dbcp2-2.4.0-sources-jar.asc=550a5fd3427da1aec9fe9c6bcb2935aaf4daf68f098dd2769cab4089cc373c48
>
> commons-dbcp2-2.4.0-tests-test-jar=6f5f5114aa25905a88f2912e2c3425dbb97ae4a6c79daaf5ee5ed98a95dfaca7
>
> commons-dbcp2-2.4.0-null-jar.asc=a8c4e8405ecc14b9aeba997c2886bfe740dd074333bd7164bc4489ce0470bf4b
>
> I have tested this with ***'mvn clean install site'*** using:
> Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297;
> 2018-02-24T12:49:05-07:00)
> Maven home: C:\Java\apache-maven-3.5.3\bin\..
> Java version: 1.8.0_172, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.8.0_172\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>
> Details of changes since 2.3.0 are in the release notes:
>
>
> https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1/RELEASE-NOTES.txt
>
>
> https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1/site/changes-report.html
>
> Site:
>     https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1/site
>     (note some *relative* links are broken and the 2.4.0 directories are
> not yet created - these will be OK once the site is deployed.)
>
> CLIRR Report (compared to 2.3.0):
>
>
> https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1/site/clirr-report.html
>     There are no errors or warnings.
>
> RAT Report:
>
>
> https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1/site/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thank you,
>
> Gary Gregory,
> Release Manager (using key 86fdc7e2a11262cb)
>