[jira] Updated: (KARAF-423) KarafJaasPasswordAuthenticator should log reason for authentication failure.

["Torsten Mielke (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KARAF-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Torsten Mielke updated KARAF-423:
---------------------------------

    Attachment: Kara-423f.patch

Proposed patch attached. 
I personally would log the message at info level but I noticed other LoginModules also only log at debug. 

> KarafJaasPasswordAuthenticator should log reason for authentication failure.
> ----------------------------------------------------------------------------
>
>                 Key: KARAF-423
>                 URL: https://issues.apache.org/jira/browse/KARAF-423
>             Project: Karaf
>          Issue Type: Improvement
>          Components: runtime
>    Affects Versions: 2.1.3
>         Environment: Karaf trunk 
>            Reporter: Torsten Mielke
>            Priority: Minor
>         Attachments: Kara-423f.patch
>
>
> In method KarafJaasPasswordAuthenticator.authenticate() we catch any exceptions at the end and only return false in the event of an exception
> {code:java}
> } catch (Exception e) {
>   return false;
> }
> {code}
> without logging anything about the reason for the exception, e.g. in case of a FailedLoginException. 
> I propose to add some logging in the exception handling. Perhaps at INFO level so that it gets written to the log file by default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.