You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/23 00:59:41 UTC
[GitHub] [apisix-dashboard] nic-chen opened a new pull request #1498: ci: add ci check for gofmt
nic-chen opened a new pull request #1498:
URL: https://github.com/apache/apisix-dashboard/pull/1498
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- [ ] Backport patches
add ci check for gofmt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis merged pull request #1498: ci: add ci check for gofmt
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #1498:
URL: https://github.com/apache/apisix-dashboard/pull/1498
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1498: ci: add ci check for gofmt
Posted by GitBox <gi...@apache.org>.
starsz commented on a change in pull request #1498:
URL: https://github.com/apache/apisix-dashboard/pull/1498#discussion_r584440187
##########
File path: .github/workflows/go-lint.yml
##########
@@ -10,9 +10,26 @@ on:
jobs:
golangci:
runs-on: ubuntu-latest
-
steps:
- uses: actions/checkout@v2
- name: run lint
run: make go-lint
+
+ gofmt:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+ - name: setup go
+ uses: actions/setup-go@v1
+ with:
+ go-version: '1.13'
+ - name: check gofmt
+ working-directory: ./
+ run: |
+ diffs=`gofmt -l .`
Review comment:
`-d display diffs instead of rewriting files`, so that we can solve the `go fmt` problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1498: ci: add ci check for gofmt
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1498:
URL: https://github.com/apache/apisix-dashboard/pull/1498#issuecomment-783867613
@nic-chen would better request reviewers so they could see the notification.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1498: ci: add ci check for gofmt
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1498:
URL: https://github.com/apache/apisix-dashboard/pull/1498#issuecomment-783790495
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=h1) Report
> Merging [#1498](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=desc) (86721e5) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/93e55ec043260feff3f4bdc489a26344d78c8512?el=desc) (93e55ec) will **decrease** coverage by `13.77%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1498 +/- ##
===========================================
- Coverage 69.01% 55.23% -13.78%
===========================================
Files 48 48
Lines 3056 3056
===========================================
- Hits 2109 1688 -421
- Misses 707 1083 +376
- Partials 240 285 +45
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `57.25% <ø> (-7.67%)` | :arrow_down: |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `54.25% <ø> (-37.24%)` | :arrow_down: |
| [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: |
| [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: |
| [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `15.15% <0.00%> (-72.73%)` | :arrow_down: |
| [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: |
| [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `34.69% <0.00%> (-34.19%)` | :arrow_down: |
| [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `41.66% <0.00%> (-30.56%)` | :arrow_down: |
| ... and [18 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=footer). Last update [93e55ec...86721e5](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1498: ci: add ci check for gofmt
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1498:
URL: https://github.com/apache/apisix-dashboard/pull/1498#issuecomment-783790495
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=h1) Report
> Merging [#1498](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=desc) (5c97ae7) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/f574fcd07e2d53f088766cb3a7ab1ede37e527b5?el=desc) (f574fcd) will **decrease** coverage by `16.79%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1498 +/- ##
===========================================
- Coverage 68.43% 51.63% -16.80%
===========================================
Files 48 39 -9
Lines 3038 2597 -441
===========================================
- Hits 2079 1341 -738
- Misses 720 1082 +362
+ Partials 239 174 -65
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <ø> (-37.50%)` | :arrow_down: |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `68.08% <ø> (-23.41%)` | :arrow_down: |
| [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-70.41%)` | :arrow_down: |
| [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
| [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [30 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=footer). Last update [f574fcd...5c97ae7](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1498: ci: add ci check for gofmt
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1498:
URL: https://github.com/apache/apisix-dashboard/pull/1498#issuecomment-783790495
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=h1) Report
> Merging [#1498](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=desc) (86721e5) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/93e55ec043260feff3f4bdc489a26344d78c8512?el=desc) (93e55ec) will **decrease** coverage by `35.66%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1498 +/- ##
===========================================
- Coverage 69.01% 33.34% -35.67%
===========================================
Files 48 48
Lines 3056 3056
===========================================
- Hits 2109 1019 -1090
- Misses 707 1813 +1106
+ Partials 240 224 -16
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <ø> (-37.50%)` | :arrow_down: |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `21.27% <ø> (-70.22%)` | :arrow_down: |
| [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: |
| [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: |
| [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `15.15% <0.00%> (-72.73%)` | :arrow_down: |
| [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `8.91% <0.00%> (-72.28%)` | :arrow_down: |
| [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | `3.38% <0.00%> (-65.79%)` | :arrow_down: |
| [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: |
| [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `33.33% <0.00%> (-57.15%)` | :arrow_down: |
| ... and [24 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=footer). Last update [93e55ec...86721e5](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1498: ci: add ci check for gofmt
Posted by GitBox <gi...@apache.org>.
starsz commented on a change in pull request #1498:
URL: https://github.com/apache/apisix-dashboard/pull/1498#discussion_r580797776
##########
File path: .github/workflows/go-lint.yml
##########
@@ -10,9 +10,26 @@ on:
jobs:
golangci:
runs-on: ubuntu-latest
-
steps:
- uses: actions/checkout@v2
- name: run lint
run: make go-lint
+
+ gofmt:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+ - name: setup go
+ uses: actions/setup-go@v1
+ with:
+ go-version: '1.13'
+ - name: check gofmt
+ working-directory: ./
+ run: |
+ diffs=`gofmt -l .`
Review comment:
IMO, `gofmt -l -d .` would be better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1498: ci: add ci check for gofmt
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #1498:
URL: https://github.com/apache/apisix-dashboard/pull/1498#discussion_r582533107
##########
File path: .github/workflows/go-lint.yml
##########
@@ -10,9 +10,26 @@ on:
jobs:
golangci:
runs-on: ubuntu-latest
-
steps:
- uses: actions/checkout@v2
- name: run lint
run: make go-lint
+
+ gofmt:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+ - name: setup go
+ uses: actions/setup-go@v1
+ with:
+ go-version: '1.13'
+ - name: check gofmt
+ working-directory: ./
+ run: |
+ diffs=`gofmt -l .`
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1498: ci: add ci check for gofmt
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #1498:
URL: https://github.com/apache/apisix-dashboard/pull/1498#discussion_r582539035
##########
File path: .github/workflows/go-lint.yml
##########
@@ -10,9 +10,26 @@ on:
jobs:
golangci:
runs-on: ubuntu-latest
-
steps:
- uses: actions/checkout@v2
- name: run lint
run: make go-lint
+
+ gofmt:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+ - name: setup go
+ uses: actions/setup-go@v1
+ with:
+ go-version: '1.13'
+ - name: check gofmt
+ working-directory: ./
+ run: |
+ diffs=`gofmt -l .`
Review comment:
oh, no, I try this, it display too much info, it's unnecessary to show the detail in the ci.
@starsz you could try for it..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1498: ci: add ci check for gofmt
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1498:
URL: https://github.com/apache/apisix-dashboard/pull/1498#issuecomment-783790495
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=h1) Report
> Merging [#1498](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=desc) (5c97ae7) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/f574fcd07e2d53f088766cb3a7ab1ede37e527b5?el=desc) (f574fcd) will **increase** coverage by `0.26%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1498 +/- ##
==========================================
+ Coverage 68.43% 68.69% +0.26%
==========================================
Files 48 48
Lines 3038 3038
==========================================
+ Hits 2079 2087 +8
+ Misses 720 712 -8
Partials 239 239
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `64.91% <ø> (ø)` | |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `91.48% <ø> (ø)` | |
| [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `72.41% <100.00%> (ø)` | |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `87.95% <0.00%> (+1.20%)` | :arrow_up: |
| [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `47.27% <0.00%> (+5.45%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=footer). Last update [f574fcd...5c97ae7](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1498: ci: add ci check for gofmt
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1498:
URL: https://github.com/apache/apisix-dashboard/pull/1498#issuecomment-783790495
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=h1) Report
> Merging [#1498](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=desc) (5c97ae7) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/f574fcd07e2d53f088766cb3a7ab1ede37e527b5?el=desc) (f574fcd) will **decrease** coverage by `8.39%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1498 +/- ##
==========================================
- Coverage 68.43% 60.03% -8.40%
==========================================
Files 48 48
Lines 3038 3038
==========================================
- Hits 2079 1824 -255
- Misses 720 973 +253
- Partials 239 241 +2
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `30.24% <ø> (-34.68%)` | :arrow_down: |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `89.36% <ø> (-2.13%)` | :arrow_down: |
| [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `72.41% <100.00%> (ø)` | |
| [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `18.75% <0.00%> (-81.25%)` | :arrow_down: |
| [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `7.14% <0.00%> (-66.67%)` | :arrow_down: |
| [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `25.00% <0.00%> (-25.00%)` | :arrow_down: |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `45.91% <0.00%> (-24.49%)` | :arrow_down: |
| [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | `34.48% <0.00%> (-24.14%)` | :arrow_down: |
| [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `31.93% <0.00%> (-23.53%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1498/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=footer). Last update [f574fcd...5c97ae7](https://codecov.io/gh/apache/apisix-dashboard/pull/1498?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org