You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/10/09 23:25:00 UTC
[GitHub] [geode] karensmolermiller opened a new pull request #5614: GEODE-8556: Remove outdated msg from docs
karensmolermiller opened a new pull request #5614:
URL: https://github.com/apache/geode/pull/5614
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] karensmolermiller commented on a change in pull request #5614: GEODE-8556: Remove outdated msg from docs
Posted by GitBox <gi...@apache.org>.
karensmolermiller commented on a change in pull request #5614:
URL: https://github.com/apache/geode/pull/5614#discussion_r504049233
##########
File path: geode-docs/configuring/running/starting_up_shutting_down.html.md.erb
##########
@@ -36,11 +36,11 @@ Start servers before you start their client applications. In each cluster, follo
- If your cluster uses both persistent replicated and non-persistent replicated regions, you should start up all the persistent replicated members in parallel before starting the non-persistent regions. This way, persistent members will not delay their startup for other persistent members with later data.
- For a system that includes persistent regions, see [Start Up and Shut Down with Disk Stores](../../managing/disk_storage/starting_system_with_disk_stores.html).
- If you are running producer processes and consumer or event listener processes, start the consumers first. This ensures the consumers and listeners do not miss any notifications or updates.
-- If you are starting up your locators and peer members all at once, you can use the `locator-wait-time` property (in seconds) upon process start up. This timeout allows peers to wait for the locators to finish starting up before attempting to join the cluster. If a process has been configured to wait for a locator to start, it will log an info-level message
+- If you are starting up your locators and peer members all at once, you can use the `locator-wait-time` property (in seconds) upon process start up. This timeout allows peers to wait for the locators to finish starting up before attempting to join the cluster.
- > `GemFire startup was unable to contact a locator. Waiting for one to start. Configured locators are frodo[12345],pippin[12345]. `
-
- The process will then sleep for a second and retry until it either connects or the number of seconds specified in `locator-wait-time` has elapsed. By default, `locator-wait-time` is set to zero meaning that a process that cannot connect to a locator upon startup will throw an exception.
+ If the process cannot initially reach a locator,
+ it will sleep for `join-retry-sleep` milliseconds
+ between retries until it either connects or the number of seconds specified in `locator-wait-time` has elapsed. By default, `locator-wait-time` is set to zero meaning that a process that cannot connect to a locator upon startup will throw an exception.
Review comment:
It is markdown, so newlines don't change formatting for this. I checked the formatting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] Bill commented on a change in pull request #5614: GEODE-8556: Remove outdated msg from docs
Posted by GitBox <gi...@apache.org>.
Bill commented on a change in pull request #5614:
URL: https://github.com/apache/geode/pull/5614#discussion_r502715870
##########
File path: geode-docs/configuring/running/starting_up_shutting_down.html.md.erb
##########
@@ -36,11 +36,11 @@ Start servers before you start their client applications. In each cluster, follo
- If your cluster uses both persistent replicated and non-persistent replicated regions, you should start up all the persistent replicated members in parallel before starting the non-persistent regions. This way, persistent members will not delay their startup for other persistent members with later data.
- For a system that includes persistent regions, see [Start Up and Shut Down with Disk Stores](../../managing/disk_storage/starting_system_with_disk_stores.html).
- If you are running producer processes and consumer or event listener processes, start the consumers first. This ensures the consumers and listeners do not miss any notifications or updates.
-- If you are starting up your locators and peer members all at once, you can use the `locator-wait-time` property (in seconds) upon process start up. This timeout allows peers to wait for the locators to finish starting up before attempting to join the cluster. If a process has been configured to wait for a locator to start, it will log an info-level message
+- If you are starting up your locators and peer members all at once, you can use the `locator-wait-time` property (in seconds) upon process start up. This timeout allows peers to wait for the locators to finish starting up before attempting to join the cluster.
- > `GemFire startup was unable to contact a locator. Waiting for one to start. Configured locators are frodo[12345],pippin[12345]. `
-
- The process will then sleep for a second and retry until it either connects or the number of seconds specified in `locator-wait-time` has elapsed. By default, `locator-wait-time` is set to zero meaning that a process that cannot connect to a locator upon startup will throw an exception.
+ If the process cannot initially reach a locator,
+ it will sleep for `join-retry-sleep` milliseconds
+ between retries until it either connects or the number of seconds specified in `locator-wait-time` has elapsed. By default, `locator-wait-time` is set to zero meaning that a process that cannot connect to a locator upon startup will throw an exception.
Review comment:
This content change looks right. I'm only concerned about the formatting. I can't tell how this will get formatted but it looks like there are some extra newlines.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] karensmolermiller merged pull request #5614: GEODE-8556: Remove outdated msg from docs
Posted by GitBox <gi...@apache.org>.
karensmolermiller merged pull request #5614:
URL: https://github.com/apache/geode/pull/5614
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org