You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Mikhail Khludnev (JIRA)" <ji...@apache.org> on 2015/06/27 10:30:04 UTC
[jira] [Updated] (SOLR-7730) don't merge FieldInfos on
SlowCompositeReaderWrapper.getSortedSetDocValues() getSortedDocValues()
[ https://issues.apache.org/jira/browse/SOLR-7730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Khludnev updated SOLR-7730:
-----------------------------------
Attachment: LUCENE-7730.patch
> don't merge FieldInfos on SlowCompositeReaderWrapper.getSortedSetDocValues() getSortedDocValues()
> -------------------------------------------------------------------------------------------------
>
> Key: SOLR-7730
> URL: https://issues.apache.org/jira/browse/SOLR-7730
> Project: Solr
> Issue Type: Improvement
> Components: faceting
> Reporter: Mikhail Khludnev
> Attachments: LUCENE-7730.patch
>
>
> every time we count facets on DocValues fields in Solr on many segments index we see the unnecessary hotspot:
> {code}
> ....
> at org.apache.lucene.index.MultiFields.getMergedFieldInfos(MultiFields.java:248)
> at org.apache.lucene.index.SlowCompositeReaderWrapper.getFieldInfos(SlowCompositeReaderWrapper.java:239)
> at org.apache.lucene.index.SlowCompositeReaderWrapper.getSortedSetDocValues(SlowCompositeReaderWrapper.java:176)
> at org.apache.solr.request.DocValuesFacets.getCounts(DocValuesFacets.java:72)
> at org.apache.solr.request.SimpleFacets.getTermCounts(SimpleFacets.java:460) ....
> {code}
> the reason is [SCWR.getSortedSetDocValues()|https://github.com/apache/lucene-solr/blob/trunk/lucene/core/src/java/org/apache/lucene/index/SlowCompositeReaderWrapper.java#L136] and [SCWR.getSortedDocValues()|https://github.com/apache/lucene-solr/blob/trunk/lucene/core/src/java/org/apache/lucene/index/SlowCompositeReaderWrapper.java#L174]
> before return composite doc values, SCWR merges segment field infos, which is expensive, but after fieldinfo is merged, it checks *only* docvalue type in it. This dv type check can be done much easier in per segment basis.
> This patch gets some performance gain for those who count DV facets in Solr.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org