You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/12/22 13:16:59 UTC
[GitHub] [camel-quarkus] gus-maurizio opened a new pull request #3408: Update CamelRoute.java
gus-maurizio opened a new pull request #3408:
URL: https://github.com/apache/camel-quarkus/pull/3408
Change delay to 20000 (20 seconds) to allow the application.properties camel.main.durationMaxSeconds (set at 10 seconds) to stop the JVM before the timer kicks in
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #3408: Update CamelRoute.java
Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #3408:
URL: https://github.com/apache/camel-quarkus/pull/3408#issuecomment-1003989526
@gus-maurizio Many thanks for stepping in. Contributions from all around the world are welcomed :)
It looks that this PR is not reproducing #3394 yet as the CI checks report green. By any chance, have you changed `application.properties` locally to reproduce the issue ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger closed pull request #3408: Update CamelRoute.java
Posted by GitBox <gi...@apache.org>.
aldettinger closed pull request #3408:
URL: https://github.com/apache/camel-quarkus/pull/3408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #3408: Update CamelRoute.java
Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #3408:
URL: https://github.com/apache/camel-quarkus/pull/3408#issuecomment-1004214611
@gus-maurizio I was not able to reproduce any issue with this PR. This PR merely change the value of delay from -1 to -20000. As far as I know, the behavior of the timer component is the same with both values.
A bit of exploration around `durationMaxMessage` may show a bug in #3434.
Are you ok to close this PR is favor of #3434 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] gus-maurizio commented on pull request #3408: Update CamelRoute.java
Posted by GitBox <gi...@apache.org>.
gus-maurizio commented on pull request #3408:
URL: https://github.com/apache/camel-quarkus/pull/3408#issuecomment-1004034296
Thanks Alexandre. Not sure how to reproduce the issue of something that is not working. The PR shows it is not working, since the whole exchange should terminate when maxDuration is reached but does not. Any ideas?
Sent from my iPad
> On Jan 3, 2022, at 5:13 AM, Alexandre Gallice ***@***.***> wrote:
>
>
> @gus-maurizio Many thanks for stepping in. Contributions from all around the world are welcomed :)
>
> It looks that this PR is not reproducing #3394 yet as the CI checks report green. By any chance, have you changed application.properties locally to reproduce the issue ?
>
> —
> Reply to this email directly, view it on GitHub, or unsubscribe.
> You are receiving this because you were mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] gus-maurizio commented on pull request #3408: Update CamelRoute.java
Posted by GitBox <gi...@apache.org>.
gus-maurizio commented on pull request #3408:
URL: https://github.com/apache/camel-quarkus/pull/3408#issuecomment-1004230879
Yes. That makes sense.
G
> On Jan 3, 2022, at 11:40 AM, Alexandre Gallice ***@***.***> wrote:
>
>
> @gus-maurizio I was not able to reproduce any issue with this PR. This PR merely change the value of delay from -1 to -20000. As far as I know, the behavior of the timer component is the same with both values.
>
> A bit of exploration around durationMaxMessage may show a bug in #3434.
> Are you ok to close this PR is favor of #3434 ?
>
> —
> Reply to this email directly, view it on GitHub, or unsubscribe.
> You are receiving this because you were mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org