You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "PurelyApplied (GitHub)" <gi...@apache.org> on 2018/10/25 21:16:40 UTC

[GitHub] [geode] PurelyApplied opened pull request #2722: GEODE-5937: Made dependencies explicit in geode-protobuf modules.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2722 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied closed pull request #2722: GEODE-5937: Made dependencies explicit in geode-protobuf modules.

Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
[ pull request closed by PurelyApplied ]

[ Full content available at: https://github.com/apache/geode/pull/2722 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] rhoughton-pivot commented on pull request #2722: GEODE-5937: Made dependencies explicit in geode-protobuf modules.

Posted by "rhoughton-pivot (GitHub)" <gi...@apache.org>.
Can we group the configurations together?

[ Full content available at: https://github.com/apache/geode/pull/2722 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on issue #2722: GEODE-5937: Made dependencies explicit in geode-protobuf modules.

Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
Test failure appears to be in an unrelated, already flaky test?

See GEODE-1770, GEODE-4712.

[ Full content available at: https://github.com/apache/geode/pull/2722 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] rhoughton-pivot commented on pull request #2722: GEODE-5937: Made dependencies explicit in geode-protobuf modules.

Posted by "rhoughton-pivot (GitHub)" <gi...@apache.org>.
Lets restore the project dependencies to be at the top of the list

[ Full content available at: https://github.com/apache/geode/pull/2722 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org