Re: [PR] feat: Add fallback checks in nativeDataFusionScan for unsupported features [datafusion-comet]

["andygrove (via GitHub)" <gi...@apache.org>]

andygrove commented on code in PR #3322:
URL: https://github.com/apache/datafusion-comet/pull/3322#discussion_r2764777877


##########
spark/src/main/scala/org/apache/comet/serde/operator/CometNativeScan.scala:
##########
@@ -77,6 +78,18 @@ object CometNativeScan extends CometOperatorSerde[CometScanExec] with Logging {
       withInfo(scanExec, "Full native scan disabled because ignoreMissingFiles enabled")
     }
 
+    if (scanExec.fileConstantMetadataColumns.nonEmpty) {
+      withInfo(scanExec, "Native DataFusion scan does not support metadata columns")
+    }
+
+    if (scanExec.bucketedScan) {
+      withInfo(scanExec, "Native DataFusion scan does not support bucketed scans")

Review Comment:
   See https://github.com/apache/datafusion-comet/pull/3392 for Spark SQL test updates related to bucketed scans. I will remove this fallback from this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org