[GitHub] ttanay commented on a change in pull request #4601: [AIRFLOW-3758] Fix circular import in WasbTaskHandler

[GitBox <gi...@apache.org>]

ttanay commented on a change in pull request #4601: [AIRFLOW-3758] Fix circular import in WasbTaskHandler
URL: https://github.com/apache/airflow/pull/4601#discussion_r259624411
 
 

 ##########
 File path: tests/test_logging_config.py
 ##########
 @@ -95,6 +95,55 @@
 }
 """
 
+SETTINGS_FILE_WASB_HANDLER = """
+REMOTE_BASE_LOG_FOLDER = 'wasb'
 
 Review comment:
   > Would it be possible to test this with the _default_ logging config and the core__remote_logging settings instead?
   
   I dug through the code for loading the log configs for remote logging. 
   Looks like its as simple as changing the following settings:
   1. `core__remote_logging`
   2. `core__remote_log_conn_id`
   3. `core__remote_base_log_folder`
   
   This is in line with the changes that need to be made in order to [write logs to S3 or GCS.](https://airflow.apache.org/howto/write-logs.html#writing-logs-to-amazon-s3)
   The docs describe a longer process for [writing logs to Azure Blob Storage](https://airflow.apache.org/howto/write-logs.html#writing-logs-to-azure-blob-storage). 
   The docs also need to be updated. Will update them in a separate [AIRFLOW-XXX] PR.
   Updating the test.
   
   Thanks @ashb 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services