[GitHub] gianm commented on a change in pull request #6107: Order rows during incremental index persist when rollup is disabled.

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #6107: Order rows during incremental index persist when rollup is disabled.
URL: https://github.com/apache/incubator-druid/pull/6107#discussion_r207743101
 
 

 ##########
 File path: processing/src/main/java/io/druid/segment/incremental/IncrementalIndex.java
 ##########
 @@ -372,6 +374,16 @@ public Builder setSimpleTestingIndexSchema(final AggregatorFactory... metrics)
       return this;
     }
 
+    @VisibleForTesting
+    public Builder setSimpleTestingIndexSchema(boolean rollup, final AggregatorFactory... metrics)
 
 Review comment:
   Could you modify the other `setSimpleTestingIndexSchema` to call this one, and add a javadoc to this one?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org