You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2014/09/11 00:28:02 UTC
svn commit: r1624157 - in
/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile: Attribute.java
Constant.java ConstantPool.java FieldOrMethod.java JavaClass.java
Author: markt
Date: Wed Sep 10 22:28:01 2014
New Revision: 1624157
URL: http://svn.apache.org/r1624157
Log:
Remove unused clone() methods and references to Cloneable
Modified:
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Attribute.java
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Constant.java
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ConstantPool.java
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/FieldOrMethod.java
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/JavaClass.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Attribute.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Attribute.java?rev=1624157&r1=1624156&r2=1624157&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Attribute.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Attribute.java Wed Sep 10 22:28:01 2014
@@ -33,7 +33,7 @@ import org.apache.tomcat.util.bcel.Const
*
* @author <A HREF="mailto:m.dahm@gmx.de">M. Dahm</A>
*/
-public abstract class Attribute implements Cloneable, Serializable
+public abstract class Attribute implements Serializable
{
private static final long serialVersionUID = 1514136303496688899L;
@@ -173,27 +173,4 @@ public abstract class Attribute implemen
Constants.CONSTANT_Utf8);
return c.getBytes();
}
-
-
- /**
- * Use copy() if you want to have a deep copy(), i.e., with all references
- * copied correctly.
- *
- * @return shallow copy of this attribute
- */
- @Override
- public Attribute clone()
- {
- Attribute attr = null;
- try
- {
- attr = (Attribute) super.clone();
- }
- catch (CloneNotSupportedException e)
- {
- throw new Error("Clone Not Supported"); // never happens
- }
- return attr;
- }
-
}
Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Constant.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Constant.java?rev=1624157&r1=1624156&r2=1624157&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Constant.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Constant.java Wed Sep 10 22:28:01 2014
@@ -31,7 +31,7 @@ import org.apache.tomcat.util.bcel.util.
*
* @author <A HREF="mailto:m.dahm@gmx.de">M. Dahm</A>
*/
-public abstract class Constant implements Cloneable, Serializable {
+public abstract class Constant implements Serializable {
private static final long serialVersionUID = 2827409182154809454L;
private static BCELComparator _cmp = new BCELComparator() {
@@ -75,16 +75,6 @@ public abstract class Constant implement
}
- @Override
- public Object clone() {
- try {
- return super.clone();
- } catch (CloneNotSupportedException e) {
- throw new Error("Clone Not Supported"); // never happens
- }
- }
-
-
/**
* Read one constant from the given file, the type depends on a tag byte.
*
Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ConstantPool.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ConstantPool.java?rev=1624157&r1=1624156&r2=1624157&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ConstantPool.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ConstantPool.java Wed Sep 10 22:28:01 2014
@@ -34,7 +34,7 @@ import org.apache.tomcat.util.bcel.Const
* @see Constant
* @author <A HREF="mailto:m.dahm@gmx.de">M. Dahm</A>
*/
-public class ConstantPool implements Cloneable, Serializable {
+public class ConstantPool implements Serializable {
private static final long serialVersionUID = -6765503791185687014L;
private int constant_pool_count;
Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/FieldOrMethod.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/FieldOrMethod.java?rev=1624157&r1=1624156&r2=1624157&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/FieldOrMethod.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/FieldOrMethod.java Wed Sep 10 22:28:01 2014
@@ -28,7 +28,7 @@ import org.apache.tomcat.util.bcel.util.
*
* @author <A HREF="mailto:m.dahm@gmx.de">M. Dahm</A>
*/
-public class FieldOrMethod extends AccessFlags implements Cloneable {
+public class FieldOrMethod extends AccessFlags {
private static final long serialVersionUID = -3383525930205542157L;
private static BCELComparator _cmp = new BCELComparator() {
Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/JavaClass.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/JavaClass.java?rev=1624157&r1=1624156&r2=1624157&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/JavaClass.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/JavaClass.java Wed Sep 10 22:28:01 2014
@@ -33,8 +33,7 @@ import org.apache.tomcat.util.bcel.util.
* @author <A HREF="mailto:m.dahm@gmx.de">M. Dahm</A>
*/
-public class JavaClass extends AccessFlags
- implements Cloneable, Comparable<JavaClass> {
+public class JavaClass extends AccessFlags implements Comparable<JavaClass> {
private static final long serialVersionUID = 7029227708237523236L;
private String class_name;
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org