You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "yashmayya (via GitHub)" <gi...@apache.org> on 2023/05/08 15:02:50 UTC
[GitHub] [kafka] yashmayya opened a new pull request, #13688: KAFKA-14974: Restore backward compatibility in KafkaBasedLog
yashmayya opened a new pull request, #13688:
URL: https://github.com/apache/kafka/pull/13688
From https://issues.apache.org/jira/browse/KAFKA-14974:
> `KafkaBasedLog` is a widely used utility class that provides a generic implementation of a shared, compacted log of records in a Kafka topic. It isn't in Connect's public API, but has been used outside of Connect and we try to preserve backward compatibility whenever possible. https://issues.apache.org/jira/browse/KAFKA-14455 modified the two overloaded void `KafkaBasedLog::send` methods to return a `Future`. While this change is source compatible, it isn't binary compatible. We can restore backward compatibility simply by re-instating the older send methods, and renaming the new Future returning send methods.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] yashmayya commented on pull request #13688: KAFKA-14974: Restore backward compatibility in KafkaBasedLog
Posted by "yashmayya (via GitHub)" <gi...@apache.org>.
yashmayya commented on PR #13688:
URL: https://github.com/apache/kafka/pull/13688#issuecomment-1538658594
Thanks for taking a look @rhauch and your understanding here is correct. We should try to backport this to `3.3`, `3.4` and `3.5` as well (before the `3.5.0` release ideally, if possible).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] yashmayya commented on pull request #13688: KAFKA-14974: Restore backward compatibility in KafkaBasedLog
Posted by "yashmayya (via GitHub)" <gi...@apache.org>.
yashmayya commented on PR #13688:
URL: https://github.com/apache/kafka/pull/13688#issuecomment-1539275733
@rhauch looks like there are 4 test failures - none of them are new failures or related to this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] yashmayya commented on pull request #13688: KAFKA-14974: Restore backward compatibility in KafkaBasedLog
Posted by "yashmayya (via GitHub)" <gi...@apache.org>.
yashmayya commented on PR #13688:
URL: https://github.com/apache/kafka/pull/13688#issuecomment-1538608185
Yep, that's right. We should backport this to `3.3`, `3.4` and `3.5` as well (before the `3.5.0` release ideally, if possible).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] yashmayya commented on pull request #13688: KAFKA-14974: Restore backward compatibility in KafkaBasedLog
Posted by "yashmayya (via GitHub)" <gi...@apache.org>.
yashmayya commented on PR #13688:
URL: https://github.com/apache/kafka/pull/13688#issuecomment-1538509105
@rhauch could you please take a look whenever you get a chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rhauch merged pull request #13688: KAFKA-14974: Restore backward compatibility in KafkaBasedLog
Posted by "rhauch (via GitHub)" <gi...@apache.org>.
rhauch merged PR #13688:
URL: https://github.com/apache/kafka/pull/13688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org