You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-dev@db.apache.org by GitBox <gi...@apache.org> on 2022/04/14 18:29:17 UTC
[GitHub] [db-jdo] tzaeschke opened a new pull request, #43: Fix Java Warnings
tzaeschke opened a new pull request, #43:
URL: https://github.com/apache/db-jdo/pull/43
Fix compiler warnings from Java 9. See https://issues.apache.org/jira/browse/JDO-810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscribe@db.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [db-jdo] tzaeschke commented on pull request #43: Fix Java Warnings
Posted by GitBox <gi...@apache.org>.
tzaeschke commented on PR #43:
URL: https://github.com/apache/db-jdo/pull/43#issuecomment-1100900839
This is ready to merge. Any comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscribe@db.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [db-jdo] clr-apache commented on a diff in pull request #43: Fix Java Warnings
Posted by GitBox <gi...@apache.org>.
clr-apache commented on code in PR #43:
URL: https://github.com/apache/db-jdo/pull/43#discussion_r853332204
##########
tck/src/main/java/org/apache/jdo/tck/pc/fieldtypes/FieldsOfBoolean.java:
##########
@@ -36,7 +36,7 @@ public class FieldsOfBoolean {
private transient Boolean Boolean12;
private transient Boolean Boolean13;
private transient Boolean Boolean14;
- private final Boolean Boolean15 = new Boolean(false);
+ private final Boolean Boolean15 = Boolean.valueOf(false);
Review Comment:
With the added benefit of making the TCK run 0.04% faster!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscribe@db.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [db-jdo] tzaeschke merged pull request #43: Fix Java Warnings
Posted by GitBox <gi...@apache.org>.
tzaeschke merged PR #43:
URL: https://github.com/apache/db-jdo/pull/43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscribe@db.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [db-jdo] tzaeschke commented on a diff in pull request #43: Fix Java Warnings
Posted by GitBox <gi...@apache.org>.
tzaeschke commented on code in PR #43:
URL: https://github.com/apache/db-jdo/pull/43#discussion_r853321855
##########
tck/src/main/java/org/apache/jdo/tck/pc/fieldtypes/FieldsOfBoolean.java:
##########
@@ -36,7 +36,7 @@ public class FieldsOfBoolean {
private transient Boolean Boolean12;
private transient Boolean Boolean13;
private transient Boolean Boolean14;
- private final Boolean Boolean15 = new Boolean(false);
+ private final Boolean Boolean15 = Boolean.valueOf(false);
Review Comment:
That makes sense. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscribe@db.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [db-jdo] clr-apache commented on a diff in pull request #43: Fix Java Warnings
Posted by GitBox <gi...@apache.org>.
clr-apache commented on code in PR #43:
URL: https://github.com/apache/db-jdo/pull/43#discussion_r852426056
##########
tck/src/main/java/org/apache/jdo/tck/pc/fieldtypes/FieldsOfBoolean.java:
##########
@@ -36,7 +36,7 @@ public class FieldsOfBoolean {
private transient Boolean Boolean12;
private transient Boolean Boolean13;
private transient Boolean Boolean14;
- private final Boolean Boolean15 = new Boolean(false);
+ private final Boolean Boolean15 = Boolean.valueOf(false);
Review Comment:
It's not important, but instead of Boolean.valueOf(false) you could just use Boolean.FALSE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscribe@db.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org