You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Siyao Meng (Jira)" <ji...@apache.org> on 2019/12/11 14:52:00 UTC

[jira] [Updated] (HDDS-2709) Maven skipShade profile should not skip ozonefs compilation

     [ https://issues.apache.org/jira/browse/HDDS-2709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Siyao Meng updated HDDS-2709:
-----------------------------
    Description: 
Currently, if {{-DskipShade}} is specified when running {{mvn}}, it will skip {{ozonefs}} module ({{hadoop-ozone-filesystem}} / Apache Hadoop Ozone FileSystem) compilation:
{code:xml}
    <profile>
      <id>build-with-ozonefs</id>
      <activation>
        <property>
          <name>!skipShade</name>
        </property>
      </activation>
      <modules>
        <module>ozonefs</module>
        <module>ozonefs-lib-current</module>
        <module>ozonefs-lib-legacy</module>
      </modules>
    </profile>
{code}

As result of this, when I make code change under {{./hadoop-ozone/ozonefs/}} then run {{mvn clean install -Pdist -DskipTests -e -Dmaven.javadoc.skip=true -DskipShade}}, the change won't be reflected in the dist. Profile {{skipShade}} should not be expected to do this.

We should compile {{ozonefs}} regardless of {{-DskipShade}}.

  was:
Currently, if {{-DskipShade}} is specified when running {{mvn}}, it will skip {{ozonefs}} module ({{hadoop-ozone-filesystem}} / Apache Hadoop Ozone FileSystem) compilation:
{code:xml}
    <profile>
      <id>build-with-ozonefs</id>
      <activation>
        <property>
          <name>!skipShade</name>
        </property>
      </activation>
      <modules>
        <module>ozonefs</module>
        <module>ozonefs-lib-current</module>
        <module>ozonefs-lib-legacy</module>
      </modules>
    </profile>
{code}

As result of this, when I make code change under {{./hadoop-ozone/ozonefs/}} then run {{mvn clean install -Pdist -DskipTests -e -Dmaven.javadoc.skip=true -DskipShade}}, the change won't be reflected in the dist. Argument {{skipShade}} should not be expected to do this.

We should compile {{ozonefs}} regardless of {{-DskipShade}}.


> Maven skipShade profile should not skip ozonefs compilation
> -----------------------------------------------------------
>
>                 Key: HDDS-2709
>                 URL: https://issues.apache.org/jira/browse/HDDS-2709
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>            Reporter: Siyao Meng
>            Assignee: Siyao Meng
>            Priority: Major
>
> Currently, if {{-DskipShade}} is specified when running {{mvn}}, it will skip {{ozonefs}} module ({{hadoop-ozone-filesystem}} / Apache Hadoop Ozone FileSystem) compilation:
> {code:xml}
>     <profile>
>       <id>build-with-ozonefs</id>
>       <activation>
>         <property>
>           <name>!skipShade</name>
>         </property>
>       </activation>
>       <modules>
>         <module>ozonefs</module>
>         <module>ozonefs-lib-current</module>
>         <module>ozonefs-lib-legacy</module>
>       </modules>
>     </profile>
> {code}
> As result of this, when I make code change under {{./hadoop-ozone/ozonefs/}} then run {{mvn clean install -Pdist -DskipTests -e -Dmaven.javadoc.skip=true -DskipShade}}, the change won't be reflected in the dist. Profile {{skipShade}} should not be expected to do this.
> We should compile {{ozonefs}} regardless of {{-DskipShade}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org