You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/31 06:24:26 UTC

[GitHub] [incubator-nuttx-apps] yamt opened a new pull request #154: CI: Tweak workflow to make it simpler to sync with other repos

yamt opened a new pull request #154: CI: Tweak workflow to make it simpler to sync with other repos
URL: https://github.com/apache/incubator-nuttx-apps/pull/154
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-apps] yamt commented on a change in pull request #154: CI: Tweak workflow to make it simpler to sync with other repos

Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #154: CI: Tweak workflow to make it simpler to sync with other repos
URL: https://github.com/apache/incubator-nuttx-apps/pull/154#discussion_r400705499
 
 

 ##########
 File path: .github/workflows/main.yml
 ##########
 @@ -16,32 +16,6 @@ on:
   pull_request:
 
 jobs:
-  check:
 
 Review comment:
   replied in https://github.com/apache/incubator-nuttx/pull/666

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-apps] liuguo09 commented on issue #154: CI: Tweak workflow to make it simpler to sync with other repos

Posted by GitBox <gi...@apache.org>.
liuguo09 commented on issue #154: CI: Tweak workflow to make it simpler to sync with other repos
URL: https://github.com/apache/incubator-nuttx-apps/pull/154#issuecomment-606452407
 
 
   LGTM. Besides xiang's comment, one thing I worry a little bit is: would we keep on matrix build jobs donot depends on check job always as in https://github.com/apache/incubator-nuttx/pull/552 does? If the answer is yes, it's good and reasonable to split into check.yml and build.yml. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-apps] yamt commented on issue #154: CI: Tweak workflow to make it simpler to sync with other repos

Posted by GitBox <gi...@apache.org>.
yamt commented on issue #154: CI: Tweak workflow to make it simpler to sync with other repos
URL: https://github.com/apache/incubator-nuttx-apps/pull/154#issuecomment-606456860
 
 
   @liuguo09 we can merge it back if/when we want to put back the dependency. i separated it for now because at this point it seems little point to run it on testing repo.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #154: CI: Tweak workflow to make it simpler to sync with other repos

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #154: CI: Tweak workflow to make it simpler to sync with other repos
URL: https://github.com/apache/incubator-nuttx-apps/pull/154
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #154: CI: Tweak workflow to make it simpler to sync with other repos

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #154: CI: Tweak workflow to make it simpler to sync with other repos
URL: https://github.com/apache/incubator-nuttx-apps/pull/154#discussion_r400690982
 
 

 ##########
 File path: .github/workflows/main.yml
 ##########
 @@ -16,32 +16,6 @@ on:
   pull_request:
 
 jobs:
-  check:
 
 Review comment:
   Should we change line 13 to:
   name: PR Check CI (build)
   and rename main.yml to build.yml?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services