[GitHub] wujimin commented on a change in pull request #461: [JAV-591] Completable future response mapper

[GitBox <gi...@apache.org>]

wujimin commented on a change in pull request #461: [JAV-591] Completable future response mapper
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/461#discussion_r158663630
 
 

 ##########
 File path: swagger/swagger-invocation/invocation-core/src/main/java/io/servicecomb/swagger/engine/SwaggerEnvironment.java
 ##########
 @@ -45,14 +47,20 @@
   @Inject
   private ProducerArgumentsMapperFactory producerArgumentsFactory;
 
-  @Inject
-  private ProducerResponseMapperFactory producerResponseMapperFactory;
+  private ResponseMapperFactorys<ProducerResponseMapper> producerResponseMapperFactorys =
 
 Review comment:
   1.old mechanism only support one level mapper, like:
   `ResponseEntity<String> -> String -> ResponseEntity<String>`
   
   but after we support CompletableFuture, we need multiple level mapper, like:
   `CompletableFuture<ResponseEntity<String>> -> String -> CompletableFuture<ResponseEntity<String>>`
   
   2.old mechanism is complex and not flexible, hard to extend
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services