You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by "egalpin (via GitHub)" <gi...@apache.org> on 2023/04/27 16:22:28 UTC

[GitHub] [beam] egalpin commented on pull request #26424: Handle response exception from Elasticsearch client

egalpin commented on PR #26424:
URL: https://github.com/apache/beam/pull/26424#issuecomment-1525991570

   thanks @mrkm4ntr for the contribution!  I'll take a look more closely as soon as I can.  In the meantime, based on the spotless checker output[1] you need to run `./gradlew :sdks:java:io:elasticsearch:spotlessApply` on your local machine and commit any changes to auto-fix java style.
   
   Could you also double-check that there is an existing test for the failure mode that your code aims to address? I'll also verify in my review.  Thanks!
   
   [1] https://ci-beam.apache.org/job/beam_PreCommit_Spotless_Commit/26535/console


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org