You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2019/06/12 14:32:23 UTC
Review Request 70844: Implemented `cleanup` method of the
`namespaces/ipc` isolator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70844/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik and Gilbert Song.
Bugs: MESOS-9826
https://issues.apache.org/jira/browse/MESOS-9826
Repository: mesos
Description
-------
Implemented `cleanup` method of the `namespaces/ipc` isolator.
Diffs
-----
src/slave/containerizer/mesos/isolators/namespaces/ipc.hpp 32c888309ca536d944e4d73641aed214805ccce2
src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp 6c8e8eed69ed355094f7d9b54bde25a8a9bc63f7
Diff: https://reviews.apache.org/r/70844/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 70844: Implemented `cleanup` method of the
`namespaces/ipc` isolator.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70844/#review216549
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp
Lines 397-398 (patched)
<https://reviews.apache.org/r/70844/#comment303763>
I would add containerID and the dir.
- Gilbert Song
On June 12, 2019, 7:36 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70844/
> -----------------------------------------------------------
>
> (Updated June 12, 2019, 7:36 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9788
> https://issues.apache.org/jira/browse/MESOS-9788
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented `cleanup` method of the `namespaces/ipc` isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/namespaces/ipc.hpp 32c888309ca536d944e4d73641aed214805ccce2
> src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp 6c8e8eed69ed355094f7d9b54bde25a8a9bc63f7
>
>
> Diff: https://reviews.apache.org/r/70844/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 70844: Implemented `cleanup` method of the
`namespaces/ipc` isolator.
Posted by Qian Zhang <zh...@gmail.com>.
> On June 21, 2019, 8:26 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp
> > Lines 400 (patched)
> > <https://reviews.apache.org/r/70844/diff/1/?file=2149226#file2149226line400>
> >
> > if the shmPath not exists, should we log a warning?
No, because shmPath not exists is a normal case for the containers which share its parent's shm.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70844/#review216029
-----------------------------------------------------------
On June 12, 2019, 10:36 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70844/
> -----------------------------------------------------------
>
> (Updated June 12, 2019, 10:36 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9788
> https://issues.apache.org/jira/browse/MESOS-9788
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented `cleanup` method of the `namespaces/ipc` isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/namespaces/ipc.hpp 32c888309ca536d944e4d73641aed214805ccce2
> src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp 6c8e8eed69ed355094f7d9b54bde25a8a9bc63f7
>
>
> Diff: https://reviews.apache.org/r/70844/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 70844: Implemented `cleanup` method of the
`namespaces/ipc` isolator.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70844/#review216029
-----------------------------------------------------------
src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp
Lines 400 (patched)
<https://reviews.apache.org/r/70844/#comment302992>
if the shmPath not exists, should we log a warning?
- Gilbert Song
On June 12, 2019, 7:36 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70844/
> -----------------------------------------------------------
>
> (Updated June 12, 2019, 7:36 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9788
> https://issues.apache.org/jira/browse/MESOS-9788
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented `cleanup` method of the `namespaces/ipc` isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/namespaces/ipc.hpp 32c888309ca536d944e4d73641aed214805ccce2
> src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp 6c8e8eed69ed355094f7d9b54bde25a8a9bc63f7
>
>
> Diff: https://reviews.apache.org/r/70844/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 70844: Implemented `cleanup` method of the
`namespaces/ipc` isolator.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70844/
-----------------------------------------------------------
(Updated June 12, 2019, 10:36 p.m.)
Review request for mesos, Andrei Budnik and Gilbert Song.
Bugs: MESOS-9788
https://issues.apache.org/jira/browse/MESOS-9788
Repository: mesos
Description
-------
Implemented `cleanup` method of the `namespaces/ipc` isolator.
Diffs
-----
src/slave/containerizer/mesos/isolators/namespaces/ipc.hpp 32c888309ca536d944e4d73641aed214805ccce2
src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp 6c8e8eed69ed355094f7d9b54bde25a8a9bc63f7
Diff: https://reviews.apache.org/r/70844/diff/1/
Testing
-------
Thanks,
Qian Zhang