You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/01/19 07:22:54 UTC
[GitHub] [lucene-solr] MarcusSorealheis opened a new pull request #2220: LUCENE-8626: Lucene standardize tests part 3 and final
MarcusSorealheis opened a new pull request #2220:
URL: https://github.com/apache/lucene-solr/pull/2220
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
* https://issues.apache.org/jira/projects/LUCENE
* https://issues.apache.org/jira/projects/SOLR
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* LUCENE-####: <short description of problem or changes>
* SOLR-####: <short description of problem or changes>
LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
I've added the final set of standardizations to test files in Lucene so that they conform to the new pattern.
# Solution
Lead with Test instead of `{something}Test.java`
# Tests
All files here are test classes.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `master` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] MarcusSorealheis commented on pull request #2220: LUCENE-8626: Lucene standardize tests part 3 and final
Posted by GitBox <gi...@apache.org>.
MarcusSorealheis commented on pull request #2220:
URL: https://github.com/apache/lucene-solr/pull/2220#issuecomment-762655240
also, for a bit of fun to show the dirty work is done:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] erikhatcher commented on pull request #2220: LUCENE-8626: Lucene standardize tests part 3 and final
Posted by GitBox <gi...@apache.org>.
erikhatcher commented on pull request #2220:
URL: https://github.com/apache/lucene-solr/pull/2220#issuecomment-763715268
lgtm!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] MarcusSorealheis commented on pull request #2220: LUCENE-8626: Lucene standardize tests part 3 and final
Posted by GitBox <gi...@apache.org>.
MarcusSorealheis commented on pull request #2220:
URL: https://github.com/apache/lucene-solr/pull/2220#issuecomment-764035674
> also, for a bit of fun to show the dirty work is done:
> 
You will notice this file returned is not actually a test class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] MarcusSorealheis commented on pull request #2220: LUCENE-8626: Lucene standardize tests part 3 and final
Posted by GitBox <gi...@apache.org>.
MarcusSorealheis commented on pull request #2220:
URL: https://github.com/apache/lucene-solr/pull/2220#issuecomment-762850831
I'll fix the test failure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] msokolov merged pull request #2220: LUCENE-8626: Lucene standardize tests part 3 and final
Posted by GitBox <gi...@apache.org>.
msokolov merged pull request #2220:
URL: https://github.com/apache/lucene-solr/pull/2220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] MarcusSorealheis commented on pull request #2220: LUCENE-8626: Lucene standardize tests part 3 and final
Posted by GitBox <gi...@apache.org>.
MarcusSorealheis commented on pull request #2220:
URL: https://github.com/apache/lucene-solr/pull/2220#issuecomment-764035674
> also, for a bit of fun to show the dirty work is done:
> 
You will notice this file returned is not actually a test class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] msokolov commented on a change in pull request #2220: LUCENE-8626: Lucene standardize tests part 3 and final
Posted by GitBox <gi...@apache.org>.
msokolov commented on a change in pull request #2220:
URL: https://github.com/apache/lucene-solr/pull/2220#discussion_r562792732
##########
File path: lucene/queryparser/src/test/org/apache/lucene/queryparser/surround/query/Test02Boolean.java
##########
@@ -46,11 +46,11 @@ public void setUp() throws Exception {
SingleFieldTestDb db1;
public void normalTest1(String query, int[] expdnrs) throws Exception {
- BooleanQueryTst bqt =
- new BooleanQueryTst(
+ TestBooleanQuery tbq =
Review comment:
ooh fancy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org