[jira] [Commented] (KARAF-6342) Log Appender is always adding location information causing an expensive new Throwable() to be called for every log

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KARAF-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958511#comment-16958511 ] 

ASF GitHub Bot commented on KARAF-6342:
---------------------------------------

jbonofre commented on pull request #93: [KARAF-6342] adding location disable configuration to karaf decanter co…
URL: https://github.com/apache/karaf-decanter/pull/93
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Log Appender is always adding location information causing an expensive new Throwable() to be called for every log
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: KARAF-6342
>                 URL: https://issues.apache.org/jira/browse/KARAF-6342
>             Project: Karaf
>          Issue Type: Improvement
>          Components: decanter
>    Affects Versions: decanter-2.2.0
>            Reporter: Ravi Undupitiya
>            Assignee: Jean-Baptiste Onofré
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: decanter-2.3.0
>
>
> This Jira is to propose an improvement to the Karaf Decanter Log Appender. 
> The current LogAppender does the following for every invocation of a log message: 
> {code:java}
> putLocation(data, event.getLocationInformation());
> {code}
> This operation calls log4j's org.apache.log4j.spi.LoggingEvent#getLocationInformation() which does a new Throwable() and this can be expensive. 
> For some uses cases, the location information is not important for every log and therefore it would be great if we can disable location info when not required. 
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)