You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/20 06:27:16 UTC

[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request #4859: Remove replaced mysql protocol classes in sharding-scaling-mysql

KomachiSion opened a new pull request #4859: Remove replaced mysql protocol classes in sharding-scaling-mysql
URL: https://github.com/apache/incubator-shardingsphere/pull/4859
 
 
   For #4594 .
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4859: Remove replaced mysql protocol classes in sharding-scaling-mysql

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4859: Remove replaced mysql protocol classes in sharding-scaling-mysql
URL: https://github.com/apache/incubator-shardingsphere/pull/4859#issuecomment-601559984
 
 
   ## Pull Request Test Coverage Report for [Build 2183](https://coveralls.io/builds/29493611)
   
   * **5** of **6**   **(83.33%)**  changed or added relevant lines in **3** files are covered.
   * **2** unchanged lines in **1** file lost coverage.
   * Overall coverage decreased (**-0.9%**) to **58.715%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-scaling/sharding-scaling-mysql/src/main/java/org/apache/shardingsphere/shardingscaling/mysql/MySQLBinlogReader.java](https://coveralls.io/builds/29493611/source?filename=sharding-scaling%2Fsharding-scaling-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fmysql%2FMySQLBinlogReader.java#L81) | 0 | 1 | 0.0%
   <!-- | **Total:** | **5** | **6** | **83.33%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29493611/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L72) | 2 | 80.0% |
   <!-- | **Total:** | **2** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29493611/badge)](https://coveralls.io/builds/29493611) |
   | :-- | --: |
   | Change from base [Build 10426](https://coveralls.io/builds/29492407): |  -0.9% |
   | Covered Lines: | 11915 |
   | Relevant Lines: | 20293 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4859: Remove replaced mysql protocol classes in sharding-scaling-mysql

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4859: Remove replaced mysql protocol classes in sharding-scaling-mysql
URL: https://github.com/apache/incubator-shardingsphere/pull/4859#issuecomment-601560342
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4859?src=pr&el=h1) Report
   > Merging [#4859](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4859?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/ce1ee6b617c94859923549c7967f7f166aca2e50?src=pr&el=desc) will **decrease** coverage by `0.93%`.
   > The diff coverage is `83.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4859/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4859?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4859      +/-   ##
   ============================================
   - Coverage     56.03%   55.09%   -0.94%     
   + Complexity      449      436      -13     
   ============================================
     Files          1166     1136      -30     
     Lines         20863    20293     -570     
     Branches       3882     3747     -135     
   ============================================
   - Hits          11690    11181     -509     
   + Misses         8445     8406      -39     
   + Partials        728      706      -22
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4859?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ngscaling/mysql/client/MySQLPasswordEncryptor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4859/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3NjYWxpbmcvbXlzcWwvY2xpZW50L015U1FMUGFzc3dvcmRFbmNyeXB0b3IuamF2YQ==) | `91.66% <ø> (ø)` | `0 <0> (?)` | |
   | [...re/shardingscaling/mysql/binlog/BinlogContext.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4859/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3NjYWxpbmcvbXlzcWwvYmlubG9nL0JpbmxvZ0NvbnRleHQuamF2YQ==) | `100% <ø> (ø)` | `0 <0> (?)` | |
   | [...phere/shardingscaling/mysql/client/ServerInfo.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4859/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3NjYWxpbmcvbXlzcWwvY2xpZW50L1NlcnZlckluZm8uamF2YQ==) | `100% <ø> (ø)` | `1 <0> (?)` | |
   | [...ql/client/netty/MySQLBinlogEventPacketDecoder.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4859/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3NjYWxpbmcvbXlzcWwvY2xpZW50L25ldHR5L015U1FMQmlubG9nRXZlbnRQYWNrZXREZWNvZGVyLmphdmE=) | `96.2% <ø> (ø)` | `0 <0> (?)` | |
   | [...re/shardingscaling/mysql/client/ServerVersion.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4859/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3NjYWxpbmcvbXlzcWwvY2xpZW50L1NlcnZlclZlcnNpb24uamF2YQ==) | `94.11% <ø> (ø)` | `0 <0> (?)` | |
   | [...ling/mysql/client/netty/MySQLNegotiateHandler.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4859/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3NjYWxpbmcvbXlzcWwvY2xpZW50L25ldHR5L015U1FMTmVnb3RpYXRlSGFuZGxlci5qYXZh) | `90.47% <ø> (ø)` | `0 <0> (?)` | |
   | [...phere/shardingscaling/mysql/MySQLBinlogReader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4859/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3NjYWxpbmcvbXlzcWwvTXlTUUxCaW5sb2dSZWFkZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../mysql/client/netty/MySQLCommandPacketDecoder.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4859/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3NjYWxpbmcvbXlzcWwvY2xpZW50L25ldHR5L015U1FMQ29tbWFuZFBhY2tldERlY29kZXIuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (?)` | |
   | [...here/shardingscaling/mysql/client/MySQLClient.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4859/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3NjYWxpbmcvbXlzcWwvY2xpZW50L015U1FMQ2xpZW50LmphdmE=) | `61.72% <100%> (ø)` | `0 <0> (?)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4859?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4859?src=pr&el=footer). Last update [ce1ee6b...a8171f2](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4859?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4859: Remove replaced mysql protocol classes in sharding-scaling-mysql

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4859: Remove replaced mysql protocol classes in sharding-scaling-mysql
URL: https://github.com/apache/incubator-shardingsphere/pull/4859#issuecomment-601559984
 
 
   ## Pull Request Test Coverage Report for [Build 10430](https://coveralls.io/builds/29493676)
   
   * **5** of **6**   **(83.33%)**  changed or added relevant lines in **3** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage decreased (**-0.9%**) to **58.636%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-scaling/sharding-scaling-mysql/src/main/java/org/apache/shardingsphere/shardingscaling/mysql/MySQLBinlogReader.java](https://coveralls.io/builds/29493676/source?filename=sharding-scaling%2Fsharding-scaling-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fmysql%2FMySQLBinlogReader.java#L81) | 0 | 1 | 0.0%
   <!-- | **Total:** | **5** | **6** | **83.33%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29493676/badge)](https://coveralls.io/builds/29493676) |
   | :-- | --: |
   | Change from base [Build 10426](https://coveralls.io/builds/29492407): |  -0.9% |
   | Covered Lines: | 11899 |
   | Relevant Lines: | 20293 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4859: Remove replaced mysql protocol classes in sharding-scaling-mysql

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #4859: Remove replaced mysql protocol classes in sharding-scaling-mysql
URL: https://github.com/apache/incubator-shardingsphere/pull/4859
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services