[jira] [Commented] (BIGTOP-2455) support pre-installed java environment

["Konstantin Boudnik (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15301470#comment-15301470 ] 

Konstantin Boudnik commented on BIGTOP-2455:
--------------------------------------------

Looks good. However, I am not sure why this file {{bigtop-deploy/puppet/manifests/site.pp}} is in the patch? It doesn't seem like it is relevant to the patch, no?

> support pre-installed java environment
> --------------------------------------
>
>                 Key: BIGTOP-2455
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-2455
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: deployment
>    Affects Versions: 1.1.0
>            Reporter: Kevin W Monroe
>            Assignee: Kevin W Monroe
>            Priority: Minor
>         Attachments: BIGTOP-2455.patch
>
>
> Ignore jdk_package_name if a user indicates they have a pre-installed java environment.
> Some users may want a version of java that is not available (or not required) for puppet to install via the normal 'jdk_package_name' mechanism.  For example, special architectures or custom/optimized java environments for which there is no jdk package to install.
> It would be nice to expose a 'jdk_preinstalled' configuration option that would turn the jdk_package_name handler into a no-op for these users.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)