[GitHub] [geode] kohlmu-pivotal commented on a change in pull request #7330: GEODE-9984: Avoid flakyness of testCommandDoesNotCopyEntriesUpdatedAf…

[GitBox <gi...@apache.org>]

kohlmu-pivotal commented on a change in pull request #7330:
URL: https://github.com/apache/geode/pull/7330#discussion_r810430356



##########
File path: geode-wan/src/distributedTest/java/org/apache/geode/cache/wan/internal/cli/commands/WanCopyRegionCommandDUnitTest.java
##########
@@ -1460,11 +1460,15 @@ public void createServersAndRegions(int locatorPort, List<VM> servers,
   }
 
   private void waitForWanCopyRegionCommandToStart(boolean useParallel, boolean usePartitionedRegion,
-      List<VM> servers) {
+      List<VM> servers) throws InterruptedException {
+    // Wait for the command execution to be registered in the service
     final int executionsExpected = useParallel && usePartitionedRegion ? servers.size() : 1;
     await().untilAsserted(
         () -> assertThat(getNumberOfCurrentExecutionsInServers(servers))
             .isEqualTo(executionsExpected));
+    // Wait some extra milliseconds to allow for the command to actually start to
+    // avoid flakyness in the tests.
+    Thread.sleep(100);

Review comment:
       @albertogpz I've looked at the code relating to the test and the functionality. I don't believe that the `Thread.sleep` should be the only recourse in resolving the flakiness of the test. I have raised [GEODE-10067](https://issues.apache.org/jira/browse/GEODE-10067) [GEODE-10068](https://issues.apache.org/jira/browse/GEODE-10068) [GEODE-10069](https://issues.apache.org/jira/browse/GEODE-10069) [GEODE-10070](https://issues.apache.org/jira/browse/GEODE-10070) [GEODE-10071](https://issues.apache.org/jira/browse/GEODE-10071) as starting points on how to possibly improve the underlying feature. With some improvements in the underlying implementation might help in resolving some of the flakiness of the test.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org