You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "csun5285 (via GitHub)" <gi...@apache.org> on 2025/10/15 10:43:01 UTC
[PR] [fix](variant) fix variant cast [doris]
csun5285 opened a new pull request, #57003:
URL: https://github.com/apache/doris/pull/57003
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Improve](variant) optimize cast performance when variant only contains null values [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57003:
URL: https://github.com/apache/doris/pull/57003#issuecomment-3409671799
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (8/8)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57003_32008860b3859cce9a7f30fa625e235b917131b9_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57003_32008860b3859cce9a7f30fa625e235b917131b9_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.20% (23615/33166) |
| Line Coverage | 57.62% (246474/427761) |
| Region Coverage | 52.71% (204338/387630) |
| Branch Coverage | 54.60% (88383/161882) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) fix variant cast [doris]
Posted by "csun5285 (via GitHub)" <gi...@apache.org>.
csun5285 commented on PR #57003:
URL: https://github.com/apache/doris/pull/57003#issuecomment-3405803575
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Improve](variant) optimize cast performance when variant only contains null values [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57003:
URL: https://github.com/apache/doris/pull/57003#issuecomment-3409291791
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Improve](variant) optimize cast performance when variant only contains null values [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57003:
URL: https://github.com/apache/doris/pull/57003#issuecomment-3409332857
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (8/8)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57003_32008860b3859cce9a7f30fa625e235b917131b9_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57003_32008860b3859cce9a7f30fa625e235b917131b9_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.24% (23626/33166) |
| Line Coverage | 57.66% (246640/427761) |
| Region Coverage | 52.73% (204391/387630) |
| Branch Coverage | 54.64% (88447/161882) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) fix variant cast [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57003:
URL: https://github.com/apache/doris/pull/57003#issuecomment-3406564959
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (8/8)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57003_32008860b3859cce9a7f30fa625e235b917131b9_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57003_32008860b3859cce9a7f30fa625e235b917131b9_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.24% (23626/33166) |
| Line Coverage | 57.66% (246640/427761) |
| Region Coverage | 52.73% (204391/387630) |
| Branch Coverage | 54.64% (88447/161882) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Improve](variant) optimize cast performance when variant only contains null values [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57003:
URL: https://github.com/apache/doris/pull/57003#issuecomment-3409291662
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Improve](variant) optimize cast performance when variant only contains null values [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57003:
URL: https://github.com/apache/doris/pull/57003#issuecomment-3409682704
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (8/8)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57003_32008860b3859cce9a7f30fa625e235b917131b9_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57003_32008860b3859cce9a7f30fa625e235b917131b9_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.20% (23615/33166) |
| Line Coverage | 57.62% (246474/427761) |
| Region Coverage | 52.71% (204338/387630) |
| Branch Coverage | 54.60% (88383/161882) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) fix variant cast [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57003:
URL: https://github.com/apache/doris/pull/57003#issuecomment-3405803229
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) fix variant cast [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57003:
URL: https://github.com/apache/doris/pull/57003#issuecomment-3406281044
# BE UT Coverage Report
Increment line coverage `100.00% (8/8)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/32008860b3859cce9a7f30fa625e235b917131b9_32008860b3859cce9a7f30fa625e235b917131b9/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/32008860b3859cce9a7f30fa625e235b917131b9_32008860b3859cce9a7f30fa625e235b917131b9/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.57% (17788/33834) |
| Line Coverage | 37.77% (161671/428018) |
| Region Coverage | 32.20% (123239/382683) |
| Branch Coverage | 33.63% (54148/160993) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Improve](variant) optimize cast performance when variant only contains null values [doris]
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon merged PR #57003:
URL: https://github.com/apache/doris/pull/57003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) fix variant cast [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57003:
URL: https://github.com/apache/doris/pull/57003#issuecomment-3406005318
<details>
<summary>TPC-DS: <b>Total hot run time: 190848 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 32008860b3859cce9a7f30fa625e235b917131b9, data reload: false
query1 1102 420 406 406
query2 6575 1735 1640 1640
query3 6755 238 229 229
query4 26444 23710 23292 23292
query5 5296 645 510 510
query6 333 256 227 227
query7 4656 493 314 314
query8 317 261 258 258
query9 8701 2594 2593 2593
query10 536 349 315 315
query11 15266 15137 14997 14997
query12 190 119 114 114
query13 1711 577 439 439
query14 11681 9246 9255 9246
query15 223 191 185 185
query16 7681 700 555 555
query17 1604 780 617 617
query18 2109 520 373 373
query19 243 219 190 190
query20 146 139 141 139
query21 227 143 132 132
query22 4807 4667 4544 4544
query23 34884 33757 34056 33757
query24 8927 2444 2491 2444
query25 586 570 457 457
query26 1314 280 161 161
query27 2924 538 406 406
query28 4453 2272 2219 2219
query29 786 690 503 503
query30 313 225 207 207
query31 951 864 792 792
query32 92 90 77 77
query33 617 415 370 370
query34 849 876 550 550
query35 880 862 751 751
query36 1019 1070 981 981
query37 134 114 92 92
query38 3688 3709 3560 3560
query39 1456 1412 1591 1412
query40 223 126 118 118
query41 65 59 60 59
query42 133 124 115 115
query43 487 511 481 481
query44 1346 845 845 845
query45 193 185 183 183
query46 834 997 652 652
query47 1749 1759 1725 1725
query48 421 456 323 323
query49 782 509 426 426
query50 648 694 414 414
query51 3913 3934 3919 3919
query52 117 115 107 107
query53 248 273 211 211
query54 625 615 533 533
query55 95 87 90 87
query56 342 332 320 320
query57 1255 1181 1129 1129
query58 293 278 278 278
query59 2507 2684 2481 2481
query60 348 348 320 320
query61 158 163 149 149
query62 795 732 695 695
query63 232 201 193 193
query64 4439 1180 875 875
query65 4102 3988 4071 3988
query66 1072 477 329 329
query67 15650 15206 15056 15056
query68 9133 934 597 597
query69 502 328 286 286
query70 1386 1378 1250 1250
query71 500 339 309 309
query72 5967 5002 4904 4904
query73 718 575 362 362
query74 9455 8977 8951 8951
query75 4389 3343 2906 2906
query76 3765 1157 740 740
query77 854 421 324 324
query78 9724 9751 8934 8934
query79 2606 849 602 602
query80 682 564 514 514
query81 485 266 238 238
query82 484 156 135 135
query83 299 272 254 254
query84 299 116 93 93
query85 893 473 433 433
query86 376 329 312 312
query87 3788 3744 3679 3679
query88 3465 2253 2336 2253
query89 426 328 294 294
query90 2059 219 216 216
query91 165 165 138 138
query92 82 67 61 61
query93 1955 992 638 638
query94 687 440 353 353
query95 396 321 311 311
query96 493 585 287 287
query97 2938 2973 2901 2901
query98 259 217 215 215
query99 1470 1398 1293 1293
Total cold run time: 284248 ms
Total hot run time: 190848 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) fix variant cast [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57003:
URL: https://github.com/apache/doris/pull/57003#issuecomment-3406022461
<details>
<summary>ClickBench: <b>Total hot run time: 30.1 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 32008860b3859cce9a7f30fa625e235b917131b9, data reload: false
query1 0.05 0.06 0.05
query2 0.10 0.06 0.07
query3 0.26 0.08 0.08
query4 1.61 0.12 0.12
query5 0.28 0.26 0.25
query6 1.15 0.66 0.65
query7 0.04 0.03 0.02
query8 0.06 0.05 0.05
query9 0.64 0.53 0.52
query10 0.58 0.58 0.58
query11 0.17 0.11 0.12
query12 0.16 0.12 0.13
query13 0.64 0.62 0.61
query14 1.03 1.03 1.02
query15 0.89 0.87 0.86
query16 0.40 0.40 0.38
query17 1.10 1.08 1.02
query18 0.22 0.21 0.20
query19 2.00 1.84 1.87
query20 0.01 0.01 0.02
query21 15.44 0.95 0.56
query22 0.77 1.21 0.65
query23 14.97 1.41 0.65
query24 7.47 1.38 0.51
query25 0.48 0.18 0.08
query26 0.76 0.16 0.15
query27 0.07 0.06 0.06
query28 8.71 1.37 0.92
query29 12.58 3.94 3.27
query30 0.29 0.15 0.11
query31 2.84 0.59 0.40
query32 3.27 0.57 0.49
query33 3.07 3.07 3.12
query34 16.27 5.49 4.84
query35 4.93 4.93 4.90
query36 0.72 0.51 0.51
query37 0.11 0.08 0.08
query38 0.08 0.05 0.04
query39 0.03 0.03 0.03
query40 0.18 0.15 0.14
query41 0.09 0.03 0.04
query42 0.04 0.03 0.03
query43 0.04 0.04 0.03
Total cold run time: 104.6 s
Total hot run time: 30.1 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org