You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/10/19 23:12:38 UTC
[GitHub] [fineract] vorburger opened a new pull request #1447: Apply Checkstyle, Errorprone etc. for all Java modules (FINERACT-1171)
vorburger opened a new pull request #1447:
URL: https://github.com/apache/fineract/pull/1447
This is a subset (extract) from #1416
Attribution to Aleks is preserved!
for FINERACT-1171
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger edited a comment on pull request #1447: Apply Checkstyle, Errorprone etc. for all Java modules (FINERACT-1171)
Posted by GitBox <gi...@apache.org>.
vorburger edited a comment on pull request #1447:
URL: https://github.com/apache/fineract/pull/1447#issuecomment-712493733
FTR: I've stared at this a bit, and it's just moves (I've actually verified we don't "loose" anything) - so LGTM from me on this!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1447: Apply Checkstyle, Errorprone etc. for all Java modules (FINERACT-1171)
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1447:
URL: https://github.com/apache/fineract/pull/1447#issuecomment-712492218
@vidakovic as per comment in #1416, how about we already do (just) this, and hold off with the `fineract-api` a little? Would you LGTM this? Note how while this PR appears to be from me, which doesn't really matter, the commit itself is still attributed (authored) by you!
@ptuomola do you want to review and LGTM this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic merged pull request #1447: Apply Checkstyle, Errorprone etc. for all Java modules (FINERACT-1171)
Posted by GitBox <gi...@apache.org>.
vidakovic merged pull request #1447:
URL: https://github.com/apache/fineract/pull/1447
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1447: Apply Checkstyle, Errorprone etc. for all Java modules (FINERACT-1171)
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1447:
URL: https://github.com/apache/fineract/pull/1447#issuecomment-712493733
@vidakovic as per comment in #1416, how about we already do (just) this, and hold off with the `fineract-api` a little? Would you LGTM this?
@ptuomola do you want to review and LGTM this?
FTR: I've stared at this a bit, and it's just moves (I've actually verified we don't "loose" anything) - so LGTM from me on this!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org